TenantAtlas/tests/Feature/Filament/PanelNavigationSegregationTest.php
ahmido 45a804970e feat: complete admin canonical tenant rollout (#165)
## Summary
- complete Spec 136 canonical admin tenant rollout across admin-visible and shared Filament surfaces
- add the shared panel-aware tenant resolver helper, persisted filter-state synchronization, and admin navigation segregation for tenant-sensitive resources
- expand regression, guard, and parity coverage for admin-path tenant resolution, stale filters, workspace-wide tenant-default surfaces, and panel split behavior

## Validation
- `vendor/bin/sail artisan test --compact tests/Feature/Guards/AdminTenantResolverGuardTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Filament/TableStatePersistenceTest.php`
- `vendor/bin/sail artisan test --compact --filter='CanonicalAdminTenantFilterState|PolicyResource|BackupSchedule|BackupSet|FindingResource|BaselineCompareLanding|RestoreRunResource|InventoryItemResource|PolicyVersionResource|ProviderConnectionResource|TenantDiagnostics|InventoryCoverage|InventoryKpiHeader|AuditLog|EntraGroup'`
- `vendor/bin/sail bin pint --dirty --format agent`

## Notes
- Livewire v4.0+ compliance is preserved with Filament v5.
- Provider registration remains unchanged in `bootstrap/providers.php`.
- `PolicyResource` and `PolicyVersionResource` have admin global search disabled explicitly; `EntraGroupResource` keeps admin-aware scoped search with a View page.
- Destructive and governance-sensitive actions retain existing confirmation and authorization behavior while using canonical tenant parity.
- No new assets were introduced, so deployment asset strategy is unchanged and does not add new `filament:assets` work.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #165
2026-03-13 08:09:20 +00:00

127 lines
4.4 KiB
PHP

<?php
declare(strict_types=1);
use App\Filament\Clusters\Inventory\InventoryCluster;
use App\Filament\Pages\InventoryCoverage;
use App\Filament\Resources\BackupScheduleResource;
use App\Filament\Resources\BackupSetResource;
use App\Filament\Resources\BaselineProfileResource;
use App\Filament\Resources\BaselineSnapshotResource;
use App\Filament\Resources\EntraGroupResource;
use App\Filament\Resources\FindingResource;
use App\Filament\Resources\InventoryItemResource;
use App\Filament\Resources\PolicyResource;
use App\Filament\Resources\PolicyVersionResource;
use App\Filament\Resources\RestoreRunResource;
use App\Support\Workspaces\WorkspaceContext;
use Filament\Facades\Filament;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
afterEach(function (): void {
Filament::setCurrentPanel(null);
});
dataset('admin hidden navigation classes', [
InventoryCluster::class,
InventoryCoverage::class,
InventoryItemResource::class,
PolicyResource::class,
PolicyVersionResource::class,
BackupScheduleResource::class,
BackupSetResource::class,
RestoreRunResource::class,
EntraGroupResource::class,
FindingResource::class,
]);
dataset('tenant visible navigation classes', [
InventoryCluster::class,
InventoryCoverage::class,
InventoryItemResource::class,
PolicyResource::class,
PolicyVersionResource::class,
BackupScheduleResource::class,
BackupSetResource::class,
RestoreRunResource::class,
EntraGroupResource::class,
FindingResource::class,
]);
it('keeps tenant-sensitive surfaces out of admin navigation registration', function (string $class): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
(string) $tenant->workspace_id => (int) $tenant->getKey(),
],
])
->get('/admin')
->assertOk();
expect($class::shouldRegisterNavigation())->toBeFalse();
})->with('admin hidden navigation classes');
it('registers tenant-sensitive surfaces in the tenant panel navigation', function (string $class): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
])
->get("/admin/t/{$tenant->external_id}")
->assertOk();
expect($class::shouldRegisterNavigation())->toBeTrue();
})->with('tenant visible navigation classes');
it('keeps baseline navigation in the workspace panel and out of the tenant panel', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
])
->get('/admin')
->assertOk();
expect(BaselineProfileResource::shouldRegisterNavigation())->toBeTrue();
expect(BaselineSnapshotResource::shouldRegisterNavigation())->toBeTrue();
$this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
])
->get("/admin/t/{$tenant->external_id}")
->assertOk();
expect(BaselineProfileResource::shouldRegisterNavigation())->toBeFalse();
expect(BaselineSnapshotResource::shouldRegisterNavigation())->toBeFalse();
});
it('keeps the workspace panel sidebar free of tenant-sensitive entries even with a remembered tenant', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
$response = $this->actingAs($user)
->withSession([
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
(string) $tenant->workspace_id => (int) $tenant->getKey(),
],
])
->get('/admin')
->assertOk();
$response->assertDontSee('>Items</span>', false);
$response->assertDontSee('>Policies</span>', false);
$response->assertDontSee('>Policy Versions</span>', false);
$response->assertDontSee('>Backup Schedules</span>', false);
$response->assertDontSee('>Backup Sets</span>', false);
$response->assertDontSee('>Restore Runs</span>', false);
$response->assertDontSee('>Findings</span>', false);
});