ahmido
9f6985291e
## Summary - implement Spec 192 across the targeted Filament record, detail, and edit pages with explicit action-surface inventory and guard coverage - add the focused Spec 192 browser smoke, feature tests, and spec artifacts under `specs/192-record-header-discipline` - improve unhandled promise rejection diagnostics by correlating 419s to the underlying Livewire request URL - disable panel-wide database notification polling on the admin, tenant, and system panels and cover the mitigation with focused tests ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/DatabaseNotificationsPollingTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/DatabaseNotificationsPollingTest.php tests/Feature/Filament/UnhandledRejectionLoggerAssetTest.php tests/Feature/Filament/FilamentNotificationsAssetsTest.php tests/Feature/Workspaces/ManagedTenantsLivewireUpdateTest.php tests/Feature/Filament/AdminSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - manual integrated-browser verification of the Spec 192 surfaces and the notification-polling mitigation ## Notes - Livewire v4 / Filament v5 compliance remains unchanged. - Provider registration stays in `bootstrap/providers.php`. - No Global Search behavior was expanded. - No destructive action confirmation semantics were relaxed. - The full test suite was not run in this PR. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #226
82 lines
2.9 KiB
PHP
82 lines
2.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\TenantReviewResource\Pages\ViewTenantReview;
|
|
use App\Models\TenantReview;
|
|
use App\Support\TenantReviewStatus;
|
|
use Filament\Actions\Action;
|
|
use Filament\Actions\ActionGroup;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Features\SupportTesting\Testable;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function tenantReviewHeaderActions(Testable $component): array
|
|
{
|
|
$instance = $component->instance();
|
|
|
|
if ($instance->getCachedHeaderActions() === []) {
|
|
$instance->cacheInteractsWithHeaderActions();
|
|
}
|
|
|
|
return $instance->getCachedHeaderActions();
|
|
}
|
|
|
|
function tenantReviewHeaderPrimaryNames(Testable $component): array
|
|
{
|
|
return collect(tenantReviewHeaderActions($component))
|
|
->reject(static fn ($action): bool => $action instanceof ActionGroup)
|
|
->map(static fn ($action): ?string => $action instanceof Action ? $action->getName() : null)
|
|
->filter()
|
|
->values()
|
|
->all();
|
|
}
|
|
|
|
function tenantReviewHeaderGroupLabels(Testable $component): array
|
|
{
|
|
return collect(tenantReviewHeaderActions($component))
|
|
->filter(static fn ($action): bool => $action instanceof ActionGroup)
|
|
->map(static fn (ActionGroup $action): string => (string) $action->getLabel())
|
|
->values()
|
|
->all();
|
|
}
|
|
|
|
it('keeps ready reviews to one primary action and renders related navigation in the summary context', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$review = composeTenantReviewForTest($tenant, $user);
|
|
|
|
setTenantPanelContext($tenant);
|
|
|
|
$component = Livewire::actingAs($user)
|
|
->test(ViewTenantReview::class, ['record' => $review->getKey()])
|
|
->assertSee('Related context')
|
|
->assertSee('Evidence snapshot');
|
|
|
|
expect(tenantReviewHeaderPrimaryNames($component))->toBe(['publish_review'])
|
|
->and(tenantReviewHeaderGroupLabels($component))->toBe(['More', 'Danger']);
|
|
});
|
|
|
|
it('promotes executive-pack export as the only visible primary action after publication', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$review = composeTenantReviewForTest($tenant, $user);
|
|
|
|
$review->forceFill([
|
|
'status' => TenantReviewStatus::Published->value,
|
|
'published_at' => now(),
|
|
'published_by_user_id' => (int) $user->getKey(),
|
|
])->save();
|
|
|
|
setTenantPanelContext($tenant);
|
|
|
|
$component = Livewire::actingAs($user)
|
|
->test(ViewTenantReview::class, ['record' => $review->getKey()])
|
|
->assertActionVisible('export_executive_pack')
|
|
->assertActionEnabled('export_executive_pack');
|
|
|
|
expect(tenantReviewHeaderPrimaryNames($component))->toBe(['export_executive_pack'])
|
|
->and(tenantReviewHeaderGroupLabels($component))->toContain('More')
|
|
->and(tenantReviewHeaderPrimaryNames($component))->not->toContain('refresh_review', 'publish_review');
|
|
});
|