TenantAtlas/apps/platform/tests/Feature/Filament/EntraGroupGlobalSearchScopeTest.php
ahmido 5248654691 feat: retire tenant panel runtime dead code (#359)
## Summary
- retire remaining legacy tenant-panel runtime assumptions in the Filament admin runtime and route resolution paths
- centralize canonical admin environment context handling for shared surfaces instead of relying on deprecated `tenant` panel behavior
- harden guard coverage so legacy `/admin/t` and `/admin/tenants` route families cannot regress
- update scoped navigation, drillthrough, reference-link, and global-search tests to use the admin panel environment runtime
- add the Spec 304 package under `specs/304-tenant-panel-dead-code-retirement/` and document the rollout in the product ledger

## Test Coverage Updated
- `AdminSharedSurfacePanelParityTest`
- `NoActiveTenantResourceRoutesTest`
- `NoLegacyTenantPanelRuntimeTest`
- `AdminTenantResolverGuardTest`
- `PolicyVersionResolvedReferenceLinksTest`
- `EntraGroupGlobalSearchScopeTest`
- `OperationsDashboardDrillthroughTest`

## Runtime Notes
- remains compliant with Filament v5 on Livewire v4
- no provider registration changes; provider registration location remains `apps/platform/bootstrap/providers.php`
- no new globally searchable resource was introduced; existing scoped search assertions were updated only
- no destructive actions were added or changed
- no asset registration changes; deploy posture for `cd apps/platform && php artisan filament:assets` is unchanged

## Validation
- updated tests and docs/spec artifacts were committed in this branch
- tests were not re-run in this turn

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #359
2026-05-14 23:57:36 +00:00

127 lines
4.0 KiB
PHP

<?php
declare(strict_types=1);
use App\Filament\Resources\EntraGroupResource;
use App\Models\EntraGroup;
use App\Models\ManagedEnvironment;
use App\Support\Workspaces\WorkspaceContext;
use Filament\Facades\Filament;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
function entraGroupSearchTitles($results): array
{
return collect($results)->map(fn ($result): string => (string) $result->title)->all();
}
it('returns no admin global-search results without canonical tenant context', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
EntraGroup::factory()->for($tenant)->create([
'display_name' => 'Admin search group',
]);
$this->actingAs($user);
Filament::setCurrentPanel('admin');
Filament::setTenant(null, true);
Filament::bootCurrentPanel();
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
expect(EntraGroupResource::getGlobalSearchResults('Admin search'))
->toHaveCount(0);
});
it('scopes admin global-search results to the remembered tenant context', function (): void {
$tenantA = ManagedEnvironment::factory()->create();
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
$tenantB = ManagedEnvironment::factory()->create([
'workspace_id' => (int) $tenantA->workspace_id,
]);
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
$tenantC = ManagedEnvironment::factory()->create();
createUserWithTenant(tenant: $tenantC, user: $user, role: 'owner');
$groupA = EntraGroup::factory()->for($tenantA)->create([
'display_name' => 'Remembered search group',
]);
EntraGroup::factory()->for($tenantB)->create([
'display_name' => 'Other search group',
]);
EntraGroup::factory()->for($tenantC)->create([
'display_name' => 'Other workspace search group',
]);
$this->actingAs($user);
Filament::setCurrentPanel('admin');
Filament::setTenant(null, true);
Filament::bootCurrentPanel();
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenantA->workspace_id);
session()->put(WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY, [
(string) $tenantA->workspace_id => (int) $tenantA->getKey(),
]);
$results = EntraGroupResource::getGlobalSearchResults('search group');
expect(entraGroupSearchTitles($results))->toBe([
'Remembered search group',
]);
$url = $results->first()?->url;
expect($url)
->toBe(EntraGroupResource::getUrl('view', ['record' => $groupA], panel: 'admin', tenant: $tenantA))
->not->toContain('/admin/t/');
$this->get($url)->assertOk();
});
it('scopes admin global-search results to the selected environment context', function (): void {
$tenantA = ManagedEnvironment::factory()->create();
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
$tenantB = ManagedEnvironment::factory()->create([
'workspace_id' => (int) $tenantA->workspace_id,
]);
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
$groupA = EntraGroup::factory()->for($tenantA)->create([
'display_name' => 'Selected environment group',
]);
EntraGroup::factory()->for($tenantB)->create([
'display_name' => 'Selected environment outsider',
]);
$this->actingAs($user);
Filament::setCurrentPanel('admin');
Filament::setTenant($tenantA, true);
Filament::bootCurrentPanel();
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenantA->workspace_id);
$results = EntraGroupResource::getGlobalSearchResults('Selected environment');
expect(entraGroupSearchTitles($results))->toBe([
'Selected environment group',
]);
$url = $results->first()?->url;
expect($url)
->toBe(EntraGroupResource::getUrl('view', ['record' => $groupA], panel: 'admin', tenant: $tenantA))
->not->toContain('/admin/tenants')
->not->toContain('/admin/t/');
$this->get($url)->assertOk();
});