## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
174 lines
7.4 KiB
PHP
174 lines
7.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
final class CanonicalOperationViewerContextMismatchTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_shows_non_blocking_mismatch_context_when_the_selected_tenant_differs_from_the_run_tenant(): void
|
|
{
|
|
$runTenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Run ManagedEnvironment',
|
|
'workspace_id' => null,
|
|
]);
|
|
[$user, $runTenant] = createUserWithTenant(tenant: $runTenant, role: 'owner');
|
|
|
|
$currentTenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Current ManagedEnvironment',
|
|
'workspace_id' => (int) $runTenant->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $currentTenant, user: $user, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $runTenant->workspace_id,
|
|
'managed_environment_id' => (int) $runTenant->getKey(),
|
|
'type' => 'policy.sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant($currentTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $runTenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Current tenant context differs from this operation')
|
|
->assertSee('Current tenant context: Current ManagedEnvironment.')
|
|
->assertSee('Operation tenant: Run ManagedEnvironment.')
|
|
->assertSee('canonical workspace view');
|
|
}
|
|
|
|
public function test_frames_tenantless_runs_as_workspace_level_even_when_tenant_context_is_selected(): void
|
|
{
|
|
$selectedTenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Selected ManagedEnvironment',
|
|
]);
|
|
[$user, $selectedTenant] = createUserWithTenant(tenant: $selectedTenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $selectedTenant->workspace_id,
|
|
'managed_environment_id' => null,
|
|
'type' => 'provider.connection.check',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant($selectedTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $selectedTenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Workspace-level operation')
|
|
->assertSee('This canonical workspace view is not tied to the current tenant context (Selected ManagedEnvironment).');
|
|
}
|
|
|
|
public function test_keeps_onboarding_tenant_runs_viewable_with_lifecycle_aware_context(): void
|
|
{
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Onboarding ManagedEnvironment',
|
|
'status' => ManagedEnvironment::STATUS_ONBOARDING,
|
|
]);
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Operation tenant is not available in the current tenant selector')
|
|
->assertSee('Operation tenant: Onboarding ManagedEnvironment.')
|
|
->assertSee('This tenant is currently onboarding')
|
|
->assertSee('Back to Operations')
|
|
->assertDontSee('This tenant is currently active')
|
|
->assertDontSee('← Back to Onboarding ManagedEnvironment');
|
|
}
|
|
|
|
public function test_keeps_archived_tenant_runs_viewable_with_lifecycle_aware_context(): void
|
|
{
|
|
$activeTenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Active ManagedEnvironment',
|
|
]);
|
|
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
|
|
|
|
$archivedTenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Archived ManagedEnvironment',
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'status' => ManagedEnvironment::STATUS_ACTIVE,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner');
|
|
$archivedTenant->delete();
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'managed_environment_id' => (int) $archivedTenant->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Operation tenant is not available in the current tenant selector')
|
|
->assertSee('Operation tenant: Archived ManagedEnvironment.')
|
|
->assertSee('This tenant is currently archived')
|
|
->assertSee('Back to Operations')
|
|
->assertDontSee('deactivated')
|
|
->assertDontSee('← Back to Archived ManagedEnvironment');
|
|
}
|
|
|
|
public function test_keeps_selector_excluded_draft_tenant_runs_viewable_with_lifecycle_aware_context(): void
|
|
{
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Draft ManagedEnvironment',
|
|
'status' => ManagedEnvironment::STATUS_DRAFT,
|
|
]);
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'type' => 'policy.sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Operation tenant is not available in the current tenant selector')
|
|
->assertSee('Operation tenant: Draft ManagedEnvironment.')
|
|
->assertSee('This tenant is currently draft')
|
|
->assertDontSee('Resume onboarding');
|
|
}
|
|
}
|