ahmido
360d20e881
## Summary - retire the tenant panel runtime and converge operator routing on the workspace-first admin shell - update tenant, operations, and required-permissions navigation helpers to use canonical workspace-scoped URLs - repair the focused feature coverage, add the Spec 280 browser smoke, and record the implementation close-out in the requirements checklist ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/WorkspaceFoundation tests/Feature/Workspaces tests/Feature/ManagedEnvironment tests/Feature/RequiredPermissions tests/Feature/Operations tests/Feature/MonitoringOperationsTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec280WorkspaceTenancyEnvironmentRoutingSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Note - `origin/platform` is not present on the remote; `platform-dev` is the clean base branch that limits this PR to the Spec 280 prep commit plus the implementation commit. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #340
60 lines
2.1 KiB
PHP
60 lines
2.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\ChooseWorkspace;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('keeps workspace switching out of sidebar navigation while management stays on its dedicated admin path', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$workspace = Workspace::factory()->create();
|
|
$secondaryWorkspace = Workspace::factory()->create();
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspace->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $secondaryWorkspace->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'operator',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$response = $this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspace->getKey()])
|
|
->get(route('admin.operations.index', ['workspace' => $workspace]))
|
|
->assertOk();
|
|
|
|
$response->assertSee('Switch workspace')
|
|
->assertSee(ChooseWorkspace::getUrl(panel: 'admin').'?choose=1', false);
|
|
|
|
$panel = Filament::getCurrentOrDefaultPanel();
|
|
|
|
$navigationItems = collect($panel->getNavigationItems());
|
|
$labels = $navigationItems
|
|
->map(static fn ($item): string => $item->getLabel())
|
|
->all();
|
|
$manageWorkspaces = $navigationItems
|
|
->first(static fn ($item): bool => $item->getLabel() === 'Manage workspaces');
|
|
|
|
expect($labels)->not->toContain('Switch workspace');
|
|
expect($labels)->toContain('Manage workspaces');
|
|
expect($labels)->not->toContain('Workspaces');
|
|
expect($manageWorkspaces)->not->toBeNull();
|
|
expect($manageWorkspaces->getUrl())->toBe(route('filament.admin.resources.workspaces.index'));
|
|
expect(OperationRunLinks::index())->toBe(route('admin.operations.index', ['workspace' => $workspace]));
|
|
});
|