## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
128 lines
4.7 KiB
PHP
128 lines
4.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\TenantDiagnostics;
|
|
use App\Models\AuditLog;
|
|
use App\Models\ManagedEnvironmentMembership;
|
|
use App\Support\Audit\AuditActionId;
|
|
use App\Support\Rbac\UiTooltips;
|
|
use Filament\Actions\Action;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Database\Schema\Blueprint;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Facades\Schema;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
describe('ManagedEnvironment diagnostics repairs', function () {
|
|
it('hides repair actions when no defect is present', function () {
|
|
[$owner, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($owner);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(TenantDiagnostics::class)
|
|
->assertSee('All good')
|
|
->assertActionHidden('bootstrapOwner')
|
|
->assertActionHidden('mergeDuplicateMemberships');
|
|
});
|
|
|
|
it('allows an authorized member to bootstrap an owner when a tenant has no owners', function () {
|
|
[$manager, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$this->actingAs($manager);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
expect(ManagedEnvironmentMembership::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('role', 'owner')
|
|
->count())->toBe(0);
|
|
|
|
Livewire::test(TenantDiagnostics::class)
|
|
->assertSee('Missing owner')
|
|
->assertActionVisible('bootstrapOwner')
|
|
->assertActionEnabled('bootstrapOwner')
|
|
->mountAction('bootstrapOwner')
|
|
->callMountedAction()
|
|
->assertSuccessful();
|
|
|
|
expect(ManagedEnvironmentMembership::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('role', 'owner')
|
|
->count())->toBe(1);
|
|
|
|
expect(AuditLog::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('action', AuditActionId::TenantMembershipBootstrapRecover->value)
|
|
->exists())->toBeTrue();
|
|
});
|
|
|
|
it('shows repair actions as disabled for readonly members', function () {
|
|
[$readonly, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$this->actingAs($readonly);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
// Force missing-owner state.
|
|
ManagedEnvironmentMembership::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->update(['role' => 'readonly']);
|
|
|
|
Livewire::test(TenantDiagnostics::class)
|
|
->assertActionVisible('bootstrapOwner')
|
|
->assertActionDisabled('bootstrapOwner')
|
|
->assertActionExists('bootstrapOwner', function (Action $action): bool {
|
|
return $action->getTooltip() === UiTooltips::INSUFFICIENT_PERMISSION;
|
|
});
|
|
});
|
|
|
|
it('merges duplicate memberships for the current user (diagnostics repair)', function () {
|
|
[$owner, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($owner);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
// Intentionally create a broken state by temporarily dropping the current uniqueness enforcement.
|
|
Schema::table('managed_environment_memberships', function (Blueprint $table): void {
|
|
$table->dropUnique(['managed_environment_id', 'user_id']);
|
|
});
|
|
|
|
ManagedEnvironmentMembership::query()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'user_id' => (int) $owner->getKey(),
|
|
'role' => 'readonly',
|
|
'source' => 'manual',
|
|
'created_by_user_id' => (int) $owner->getKey(),
|
|
]);
|
|
|
|
expect(ManagedEnvironmentMembership::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('user_id', (int) $owner->getKey())
|
|
->count())->toBeGreaterThan(1);
|
|
|
|
Livewire::test(TenantDiagnostics::class)
|
|
->assertActionVisible('mergeDuplicateMemberships')
|
|
->assertActionEnabled('mergeDuplicateMemberships')
|
|
->mountAction('mergeDuplicateMemberships')
|
|
->callMountedAction()
|
|
->assertSuccessful();
|
|
|
|
expect(ManagedEnvironmentMembership::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('user_id', (int) $owner->getKey())
|
|
->count())->toBe(1);
|
|
|
|
expect(AuditLog::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('action', AuditActionId::TenantMembershipDuplicatesMerged->value)
|
|
->exists())->toBeTrue();
|
|
});
|
|
});
|