ahmido
c0f4587d90
## Summary - standardize the shared verification report family across operation detail, onboarding, and tenant verification widget hosts - standardize normalized settings and normalized diff family wrappers across policy, policy version, and finding detail hosts - add parity and guard coverage plus the full Spec 197 artifacts, including recorded manual smoke evidence ## Testing - focused Sail regression pack from `specs/197-shared-detail-contract/quickstart.md` - local integrated-browser manual smoke for SC-197-003 and SC-197-004 Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #237
112 lines
4.4 KiB
PHP
112 lines
4.4 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\PolicyVersionResource;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\Tenant;
|
|
use App\Services\Intune\PolicyNormalizer;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
test('group policy configuration normalized diff keys use definition display names', function () {
|
|
$flat = app(PolicyNormalizer::class)->flattenForDiff(
|
|
snapshot: [
|
|
'id' => 'gpo-1',
|
|
'displayName' => 'Admin Templates Alpha',
|
|
'@odata.type' => '#microsoft.graph.groupPolicyConfiguration',
|
|
'definitionValues' => [
|
|
[
|
|
'enabled' => true,
|
|
'definition@odata.bind' => 'https://graph.microsoft.com/beta/deviceManagement/groupPolicyDefinitions(\'def-1\')',
|
|
'#Definition_Id' => 'def-1',
|
|
'#Definition_displayName' => 'Block legacy auth',
|
|
'#Definition_categoryPath' => 'Windows Components\\Security Options',
|
|
],
|
|
],
|
|
],
|
|
policyType: 'groupPolicyConfiguration',
|
|
platform: 'windows',
|
|
);
|
|
|
|
$keys = array_keys($flat);
|
|
|
|
expect($keys)->toContain('Administrative Template settings > Windows Components\\Security Options > Block legacy auth (def-1)');
|
|
expect(implode("\n", $keys))->not->toContain('graph.microsoft.com');
|
|
});
|
|
|
|
test('group policy configuration policy-version detail renders the shared normalized diff family', function () {
|
|
$tenant = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
]);
|
|
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'external_id' => 'gpo-policy-1',
|
|
'policy_type' => 'groupPolicyConfiguration',
|
|
'display_name' => 'Admin Templates Alpha',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'version_number' => 1,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'created_by' => 'tester@example.com',
|
|
'captured_at' => CarbonImmutable::now()->subMinute(),
|
|
'snapshot' => [
|
|
'id' => 'gpo-1',
|
|
'displayName' => 'Admin Templates Alpha',
|
|
'@odata.type' => '#microsoft.graph.groupPolicyConfiguration',
|
|
'definitionValues' => [
|
|
[
|
|
'enabled' => false,
|
|
'definition@odata.bind' => 'https://graph.microsoft.com/beta/deviceManagement/groupPolicyDefinitions(\'def-1\')',
|
|
'#Definition_Id' => 'def-1',
|
|
'#Definition_displayName' => 'Block legacy auth',
|
|
'#Definition_categoryPath' => 'Windows Components\\Security Options',
|
|
],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'version_number' => 2,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'created_by' => 'tester@example.com',
|
|
'captured_at' => CarbonImmutable::now(),
|
|
'snapshot' => [
|
|
'id' => 'gpo-1',
|
|
'displayName' => 'Admin Templates Alpha',
|
|
'@odata.type' => '#microsoft.graph.groupPolicyConfiguration',
|
|
'definitionValues' => [
|
|
[
|
|
'enabled' => true,
|
|
'definition@odata.bind' => 'https://graph.microsoft.com/beta/deviceManagement/groupPolicyDefinitions(\'def-1\')',
|
|
'#Definition_Id' => 'def-1',
|
|
'#Definition_displayName' => 'Block legacy auth',
|
|
'#Definition_categoryPath' => 'Windows Components\\Security Options',
|
|
],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$response = $this->actingAs($user)
|
|
->get(PolicyVersionResource::getUrl('view', ['record' => $version], tenant: $tenant));
|
|
|
|
$response->assertSuccessful()->assertSee('Block legacy auth');
|
|
|
|
expect($response->getContent())
|
|
->toContain('data-shared-detail-family="normalized-diff"')
|
|
->toContain('data-shared-normalized-diff-host="policy_version"')
|
|
->toContain('data-shared-zone="groups"');
|
|
});
|