ahmido
bc846d7c5c
Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
39 lines
1.1 KiB
PHP
39 lines
1.1 KiB
PHP
<?php
|
|
|
|
use App\Jobs\EntraGroupSyncJob;
|
|
use App\Models\EntraGroupSyncRun;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Support\Facades\Artisan;
|
|
use Illuminate\Support\Facades\Config;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
it('scheduled dispatcher creates a run without a user initiator', function () {
|
|
Queue::fake();
|
|
|
|
$tenant = \App\Models\Tenant::factory()->create();
|
|
|
|
Config::set('directory_groups.schedule.enabled', true);
|
|
Config::set('directory_groups.schedule.time_utc', '02:00');
|
|
|
|
CarbonImmutable::setTestNow(CarbonImmutable::parse('2026-01-11 02:00:00', 'UTC'));
|
|
|
|
Artisan::call('tenantpilot:directory-groups:dispatch', [
|
|
'--tenant' => [$tenant->tenant_id],
|
|
]);
|
|
|
|
$slotKey = CarbonImmutable::now('UTC')->format('YmdHi').'Z';
|
|
|
|
$run = EntraGroupSyncRun::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('selection_key', 'groups-v1:all')
|
|
->where('slot_key', $slotKey)
|
|
->first();
|
|
|
|
expect($run)->not->toBeNull()
|
|
->and($run->initiator_user_id)->toBeNull();
|
|
|
|
Queue::assertPushed(EntraGroupSyncJob::class);
|
|
|
|
CarbonImmutable::setTestNow();
|
|
});
|