Summary Kurz: Implementiert Feature 054 — canonical OperationRun-flow, Monitoring UI, dispatch-safety, notifications, dedupe, plus small UX safety clarifications (RBAC group search delegated; Restore group mapping DB-only). What Changed Core service: OperationRun lifecycle, dedupe and dispatch helpers — OperationRunService.php. Model + migration: OperationRun model and migration — OperationRun.php, 2026_01_16_180642_create_operation_runs_table.php. Notifications: queued + terminal DB notifications (initiator-only) — OperationRunQueued.php, OperationRunCompleted.php. Monitoring UI: Filament list/detail + Livewire pieces (DB-only render) — OperationRunResource.php and related pages/views. Start surfaces / Jobs: instrumented start surfaces, job middleware, and job updates to use canonical runs — multiple app/Jobs/* and app/Filament/* updates (see tests for full coverage). RBAC + Restore UX clarifications: RBAC group search is delegated-Graph-based and disabled without delegated token; Restore group mapping remains DB-only (directory cache) and helper text always visible — TenantResource.php, RestoreRunResource.php. Specs / Constitution: updated spec & quickstart and added one-line constitution guideline about Graph usage: spec.md quickstart.md constitution.md Tests & Verification Unit / Feature tests added/updated for run lifecycle, notifications, idempotency, and UI guards: see tests/Feature/* (notably OperationRunServiceTest, MonitoringOperationsTest, OperationRunNotificationTest, and various Filament feature tests). Full test run locally: ./vendor/bin/sail artisan test → 587 passed, 5 skipped. Migrations Adds create_operation_runs_table migration; run php artisan migrate in staging after review. Notes / Rationale Monitoring pages are explicitly DB-only at render time (no Graph calls). Start surfaces enqueue work only and return a “View run” link. Delegated Graph access is used only for explicit user actions (RBAC group search); restore mapping intentionally uses cached DB data only to avoid render-time Graph calls. Dispatch wrapper marks runs failed immediately if background dispatch throws synchronously to avoid misleading “queued” states. Upgrade / Deploy Considerations Run migrations: ./vendor/bin/sail artisan migrate. Background workers should be running to process queued jobs (recommended to monitor queue health during rollout). No secret or token persistence changes. PR checklist Tests updated/added for changed behavior Specs updated: 054-unify-runs-suitewide docs + quickstart Constitution note added (.specify) Pint formatting applied Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #63
44 lines
1.1 KiB
PHP
44 lines
1.1 KiB
PHP
<?php
|
|
|
|
namespace App\Support;
|
|
|
|
enum OperationRunOutcome: string
|
|
{
|
|
case Pending = 'pending';
|
|
case Succeeded = 'succeeded';
|
|
case PartiallySucceeded = 'partially_succeeded';
|
|
case Failed = 'failed';
|
|
|
|
/**
|
|
* Reserved for future use. MUST NOT be produced by feature 054.
|
|
*/
|
|
case Cancelled = 'cancelled';
|
|
|
|
public static function values(bool $includeReserved = true): array
|
|
{
|
|
$cases = self::cases();
|
|
|
|
if (! $includeReserved) {
|
|
$cases = array_filter($cases, static fn (self $case): bool => $case !== self::Cancelled);
|
|
}
|
|
|
|
return array_map(static fn (self $case): string => $case->value, $cases);
|
|
}
|
|
|
|
public static function uiLabels(bool $includeReserved = false): array
|
|
{
|
|
$labels = [
|
|
self::Pending->value => 'Pending',
|
|
self::Succeeded->value => 'Succeeded',
|
|
self::PartiallySucceeded->value => 'Partially succeeded',
|
|
self::Failed->value => 'Failed',
|
|
];
|
|
|
|
if ($includeReserved) {
|
|
$labels[self::Cancelled->value] = 'Cancelled';
|
|
}
|
|
|
|
return $labels;
|
|
}
|
|
}
|