Beschreibung Implementiert das Drift MVP Feature (Spec: 044-drift-mvp) mit Fokus auf automatische Drift-Erkennung zwischen Inventory Sync Runs und Bulk-Triage für Findings. Was wurde implementiert? Drift-Erkennung: Vergleicht Policy-Snapshots, Assignments und Scope Tags zwischen Baseline- und Current-Runs. Deterministische Fingerprints verhindern Duplikate. Findings UI: Neue Filament Resource für Findings mit Listen- und Detail-Ansicht. DB-only Diffs (keine Graph-Calls zur Laufzeit). Bulk Acknowledge: "Acknowledge selected" (Bulk-Action auf der Liste) "Acknowledge all matching" (Header-Action, respektiert aktuelle Filter; Type-to-Confirm bei >100 Findings) Scope Tag Fix: Behebt False Positives bei Legacy-Daten ohne scope_tags.ids (inferiert Default-Werte). Authorization: Tenant-isoliert, Rollen-basiert (Owner/Manager/Operator können acknowledge). Tests: Vollständige Pest-Coverage (28 Tests, 347 Assertions) für Drift-Logik, UI und Bulk-Actions. Warum diese Änderungen? Problem: Keine automatisierte Drift-Erkennung; manuelle Triage bei vielen Findings ist mühsam. Lösung: Async Drift-Generierung mit persistenter Findings-Tabelle. Safe Bulk-Tools für Massen-Triage ohne Deletes. Konformität: Folgt AGENTS.md Workflow, Spec-Kit (Tasks + Checklists abgehakt), Laravel/Filament Best Practices. Technische Details Neue Dateien: ~40 (Models, Services, Tests, Views, Migrations) Änderungen: Filament Resources, Jobs, Policies DB: Neue findings Tabelle (JSONB für Evidence, Indexes für Performance) Tests: ./vendor/bin/sail artisan test tests/Feature/Drift --parallel → 28 passed Migration: ./vendor/bin/sail artisan migrate (neue Tabelle + Indexes) Screenshots / Links Spec: spec.md Tasks: tasks.md (alle abgehakt) UI: Findings-Liste mit Bulk-Actions; Detail-View mit Diffs Checklist Tests passieren (parallel + serial) Code formatiert (./vendor/bin/pint --dirty) Migration reversibel Tenant-Isolation enforced No Graph-Calls in Views Authorization checks Spec + Tasks aligned Deployment Notes Neue Migration: create_findings_table Neue Permissions: drift.view, drift.acknowledge Queue-Job: GenerateDriftFindingsJob (async, deduped)
105 lines
3.4 KiB
PHP
105 lines
3.4 KiB
PHP
<?php
|
|
|
|
namespace App\Jobs;
|
|
|
|
use App\Models\BulkOperationRun;
|
|
use App\Models\InventorySyncRun;
|
|
use App\Models\Tenant;
|
|
use App\Services\BulkOperationService;
|
|
use App\Services\Drift\DriftFindingGenerator;
|
|
use Illuminate\Bus\Queueable;
|
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
|
use Illuminate\Foundation\Bus\Dispatchable;
|
|
use Illuminate\Queue\InteractsWithQueue;
|
|
use Illuminate\Queue\SerializesModels;
|
|
use Illuminate\Support\Facades\Log;
|
|
use RuntimeException;
|
|
use Throwable;
|
|
|
|
class GenerateDriftFindingsJob implements ShouldQueue
|
|
{
|
|
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
|
|
|
|
public function __construct(
|
|
public int $tenantId,
|
|
public int $userId,
|
|
public int $baselineRunId,
|
|
public int $currentRunId,
|
|
public string $scopeKey,
|
|
public int $bulkOperationRunId,
|
|
) {}
|
|
|
|
/**
|
|
* Execute the job.
|
|
*/
|
|
public function handle(DriftFindingGenerator $generator, BulkOperationService $bulkOperationService): void
|
|
{
|
|
Log::info('GenerateDriftFindingsJob: started', [
|
|
'tenant_id' => $this->tenantId,
|
|
'baseline_run_id' => $this->baselineRunId,
|
|
'current_run_id' => $this->currentRunId,
|
|
'scope_key' => $this->scopeKey,
|
|
'bulk_operation_run_id' => $this->bulkOperationRunId,
|
|
]);
|
|
|
|
$tenant = Tenant::query()->find($this->tenantId);
|
|
if (! $tenant instanceof Tenant) {
|
|
throw new RuntimeException('Tenant not found.');
|
|
}
|
|
|
|
$baseline = InventorySyncRun::query()->find($this->baselineRunId);
|
|
if (! $baseline instanceof InventorySyncRun) {
|
|
throw new RuntimeException('Baseline run not found.');
|
|
}
|
|
|
|
$current = InventorySyncRun::query()->find($this->currentRunId);
|
|
if (! $current instanceof InventorySyncRun) {
|
|
throw new RuntimeException('Current run not found.');
|
|
}
|
|
|
|
$run = BulkOperationRun::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->find($this->bulkOperationRunId);
|
|
|
|
if (! $run instanceof BulkOperationRun) {
|
|
throw new RuntimeException('Bulk operation run not found.');
|
|
}
|
|
|
|
$bulkOperationService->start($run);
|
|
|
|
try {
|
|
$created = $generator->generate(
|
|
tenant: $tenant,
|
|
baseline: $baseline,
|
|
current: $current,
|
|
scopeKey: $this->scopeKey,
|
|
);
|
|
|
|
Log::info('GenerateDriftFindingsJob: completed', [
|
|
'tenant_id' => $this->tenantId,
|
|
'baseline_run_id' => $this->baselineRunId,
|
|
'current_run_id' => $this->currentRunId,
|
|
'scope_key' => $this->scopeKey,
|
|
'bulk_operation_run_id' => $this->bulkOperationRunId,
|
|
'created_findings_count' => $created,
|
|
]);
|
|
|
|
$bulkOperationService->recordSuccess($run);
|
|
$bulkOperationService->complete($run);
|
|
} catch (Throwable $e) {
|
|
Log::error('GenerateDriftFindingsJob: failed', [
|
|
'tenant_id' => $this->tenantId,
|
|
'baseline_run_id' => $this->baselineRunId,
|
|
'current_run_id' => $this->currentRunId,
|
|
'scope_key' => $this->scopeKey,
|
|
'bulk_operation_run_id' => $this->bulkOperationRunId,
|
|
'error' => $e->getMessage(),
|
|
]);
|
|
|
|
$bulkOperationService->fail($run, $e->getMessage());
|
|
|
|
throw $e;
|
|
}
|
|
}
|
|
}
|