Implements platform feature branch `285-workspace-rbac-environment-access`. Summary: - switch managed environment authorization to workspace-first role resolution with explicit environment-scope narrowing - rewire Filament pages, resources, policies, and user tenant access helpers to the shared access-scope resolver - add Spec 285 coverage across unit, feature, and browser tests plus full spec artifacts Validation: - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Auth/WorkspaceFirstCapabilityResolverTest.php tests/Unit/Auth/ManagedEnvironmentAccessScopeResolverTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Filament/WorkspaceMembershipRoleManagementTest.php tests/Feature/Rbac/GovernanceArtifactsWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/OperationRunWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Verification/ProviderExecutionReauthorizationTest.php tests/Feature/ProviderConnections/ProviderConnectionHealthCheckStartSurfaceTest.php tests/Feature/Tenants/TenantProviderBackedActionStartTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Audit/TenantMembershipAuditLogTest.php tests/Feature/Filament/TenantMembersTest.php tests/Feature/TenantRBAC/TenantMembershipCrudTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Target branch: `platform-dev`. Follow-up integration path after merge: - `platform-dev` -> `dev`. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #344
128 lines
3.7 KiB
PHP
128 lines
3.7 KiB
PHP
<?php
|
|
|
|
namespace App\Services\Auth;
|
|
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\Auth\WorkspaceRole;
|
|
use Illuminate\Support\Facades\Log;
|
|
|
|
/**
|
|
* Workspace Capability Resolver
|
|
*
|
|
* Resolves user memberships and capabilities for a given workspace.
|
|
* Caches results per request to avoid N+1 queries.
|
|
*/
|
|
class WorkspaceCapabilityResolver
|
|
{
|
|
private array $resolvedMemberships = [];
|
|
|
|
private array $loggedDenials = [];
|
|
|
|
public function getRole(User $user, Workspace $workspace): ?WorkspaceRole
|
|
{
|
|
$membership = $this->getMembership($user, $workspace);
|
|
|
|
if ($membership === null) {
|
|
return null;
|
|
}
|
|
|
|
return WorkspaceRole::tryFrom($membership['role']);
|
|
}
|
|
|
|
public function can(User $user, Workspace $workspace, string $capability): bool
|
|
{
|
|
if (! Capabilities::isKnown($capability)) {
|
|
throw new \InvalidArgumentException("Unknown capability: {$capability}");
|
|
}
|
|
|
|
$role = $this->getRole($user, $workspace);
|
|
|
|
if ($role === null) {
|
|
$this->logDenial($user, $workspace, $capability);
|
|
|
|
return false;
|
|
}
|
|
|
|
$allowed = WorkspaceRoleCapabilityMap::hasCapability($role, $capability);
|
|
|
|
if (! $allowed) {
|
|
$this->logDenial($user, $workspace, $capability);
|
|
}
|
|
|
|
return $allowed;
|
|
}
|
|
|
|
public function isMember(User $user, Workspace $workspace): bool
|
|
{
|
|
return $this->getMembership($user, $workspace) !== null;
|
|
}
|
|
|
|
public function clearCache(): void
|
|
{
|
|
$this->resolvedMemberships = [];
|
|
}
|
|
|
|
/**
|
|
* Prime workspace membership cache for a set of workspaces in one query.
|
|
*
|
|
* @param array<int, int|string> $workspaceIds
|
|
*/
|
|
public function primeMemberships(User $user, array $workspaceIds): void
|
|
{
|
|
$workspaceIds = array_values(array_unique(array_map(static fn ($id): int => (int) $id, $workspaceIds)));
|
|
|
|
if ($workspaceIds === []) {
|
|
return;
|
|
}
|
|
|
|
$memberships = WorkspaceMembership::query()
|
|
->where('user_id', (int) $user->getKey())
|
|
->whereIn('workspace_id', $workspaceIds)
|
|
->get(['workspace_id', 'role']);
|
|
|
|
$byWorkspaceId = $memberships->keyBy('workspace_id');
|
|
|
|
foreach ($workspaceIds as $workspaceId) {
|
|
$cacheKey = "workspace_membership_{$user->id}_{$workspaceId}";
|
|
$membership = $byWorkspaceId->get($workspaceId);
|
|
$this->resolvedMemberships[$cacheKey] = $membership?->toArray();
|
|
}
|
|
}
|
|
|
|
private function logDenial(User $user, Workspace $workspace, string $capability): void
|
|
{
|
|
$key = implode(':', [(string) $user->getKey(), (string) $workspace->getKey(), $capability]);
|
|
|
|
if (isset($this->loggedDenials[$key])) {
|
|
return;
|
|
}
|
|
|
|
$this->loggedDenials[$key] = true;
|
|
|
|
Log::warning('rbac.workspace.denied', [
|
|
'capability' => $capability,
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'actor_user_id' => (int) $user->getKey(),
|
|
]);
|
|
}
|
|
|
|
private function getMembership(User $user, Workspace $workspace): ?array
|
|
{
|
|
$cacheKey = "workspace_membership_{$user->id}_{$workspace->id}";
|
|
|
|
if (! array_key_exists($cacheKey, $this->resolvedMemberships)) {
|
|
$membership = WorkspaceMembership::query()
|
|
->where('user_id', $user->id)
|
|
->where('workspace_id', $workspace->id)
|
|
->first(['role']);
|
|
|
|
$this->resolvedMemberships[$cacheKey] = $membership?->toArray();
|
|
}
|
|
|
|
return $this->resolvedMemberships[$cacheKey];
|
|
}
|
|
}
|