Implements platform feature branch `285-workspace-rbac-environment-access`. Summary: - switch managed environment authorization to workspace-first role resolution with explicit environment-scope narrowing - rewire Filament pages, resources, policies, and user tenant access helpers to the shared access-scope resolver - add Spec 285 coverage across unit, feature, and browser tests plus full spec artifacts Validation: - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Auth/WorkspaceFirstCapabilityResolverTest.php tests/Unit/Auth/ManagedEnvironmentAccessScopeResolverTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Filament/WorkspaceMembershipRoleManagementTest.php tests/Feature/Rbac/GovernanceArtifactsWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/OperationRunWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Verification/ProviderExecutionReauthorizationTest.php tests/Feature/ProviderConnections/ProviderConnectionHealthCheckStartSurfaceTest.php tests/Feature/Tenants/TenantProviderBackedActionStartTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Audit/TenantMembershipAuditLogTest.php tests/Feature/Filament/TenantMembersTest.php tests/Feature/TenantRBAC/TenantMembershipCrudTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Target branch: `platform-dev`. Follow-up integration path after merge: - `platform-dev` -> `dev`. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #344
159 lines
6.0 KiB
PHP
159 lines
6.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\ChooseTenant;
|
|
use App\Filament\Resources\TenantResource;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\User;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Filament\PanelRegistry;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('only returns active membership tenants for normal users', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$allowed = ManagedEnvironment::factory()->active()->create(['name' => 'Allowed']);
|
|
$onboarding = ManagedEnvironment::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $allowed->workspace_id,
|
|
'name' => 'Onboarding',
|
|
]);
|
|
$archived = ManagedEnvironment::factory()->archived()->create([
|
|
'workspace_id' => (int) $allowed->workspace_id,
|
|
'name' => 'Archived',
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $allowed->workspace_id,
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'readonly',
|
|
]);
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $allowed->workspace_id);
|
|
|
|
/** @var \Filament\Panel $panel */
|
|
$panel = app(PanelRegistry::class)->get('admin');
|
|
|
|
$tenants = $user->getTenants($panel);
|
|
|
|
expect($tenants)->toHaveCount(1);
|
|
expect($tenants->first()?->getKey())->toBe($allowed->getKey());
|
|
expect($tenants->contains(fn (ManagedEnvironment $tenant): bool => $tenant->name === 'Onboarding'))->toBeFalse();
|
|
expect($tenants->contains(fn (ManagedEnvironment $tenant): bool => $tenant->name === 'Archived'))->toBeFalse();
|
|
});
|
|
|
|
it('returns no tenants for users without active tenant memberships', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$draft = ManagedEnvironment::factory()->draft()->create(['name' => 'Draft']);
|
|
$archived = ManagedEnvironment::factory()->archived()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'name' => 'Archived',
|
|
]);
|
|
|
|
/** @var \Filament\Panel $panel */
|
|
$panel = app(PanelRegistry::class)->get('admin');
|
|
|
|
expect($user->getTenants($panel))->toHaveCount(0);
|
|
});
|
|
|
|
it('rejects selecting non-active memberships as tenant context', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$active = ManagedEnvironment::factory()->active()->create(['name' => 'Allowed']);
|
|
$onboarding = ManagedEnvironment::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Onboarding',
|
|
]);
|
|
$archived = ManagedEnvironment::factory()->archived()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Archived',
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'readonly',
|
|
]);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $active->workspace_id);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(ChooseTenant::class)
|
|
->call('selectTenant', $onboarding->getKey())
|
|
->assertStatus(404);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(ChooseTenant::class)
|
|
->call('selectTenant', $archived->getKey())
|
|
->assertStatus(404);
|
|
});
|
|
|
|
it('keeps tenant global-search broader than selector eligibility when the user only has administratively discoverable memberships', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$draft = ManagedEnvironment::factory()->draft()->create(['name' => 'Search Draft']);
|
|
$onboarding = ManagedEnvironment::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'name' => 'Search Onboarding',
|
|
]);
|
|
$archived = ManagedEnvironment::factory()->archived()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'name' => 'Search Archived',
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $draft->workspace_id,
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'readonly',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $draft->workspace_id);
|
|
|
|
expect(TenantResource::getGlobalSearchResults('Search'))
|
|
->toHaveCount(3)
|
|
->sequence(
|
|
fn ($result) => $result->title->toContain('Search'),
|
|
fn ($result) => $result->title->toContain('Search'),
|
|
fn ($result) => $result->title->toContain('Search'),
|
|
);
|
|
});
|
|
|
|
it('does not render onboarding or archived tenants in the header selector on workspace pages', function (): void {
|
|
$activeTenant = ManagedEnvironment::factory()->active()->create(['name' => 'Header Active ManagedEnvironment']);
|
|
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
|
|
|
|
$onboardingTenant = ManagedEnvironment::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'name' => 'Header Onboarding ManagedEnvironment',
|
|
]);
|
|
$archivedTenant = ManagedEnvironment::factory()->archived()->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'name' => 'Header Archived ManagedEnvironment',
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $onboardingTenant, user: $user, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
|
->get(route('admin.operations.index', ['workspace' => $activeTenant->workspace]))
|
|
->assertSuccessful()
|
|
->assertSee('Header Active ManagedEnvironment')
|
|
->assertDontSee('Header Onboarding ManagedEnvironment')
|
|
->assertDontSee('Header Archived ManagedEnvironment')
|
|
->assertSee('No tenant selected');
|
|
});
|