Implements platform feature branch `285-workspace-rbac-environment-access`. Summary: - switch managed environment authorization to workspace-first role resolution with explicit environment-scope narrowing - rewire Filament pages, resources, policies, and user tenant access helpers to the shared access-scope resolver - add Spec 285 coverage across unit, feature, and browser tests plus full spec artifacts Validation: - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Auth/WorkspaceFirstCapabilityResolverTest.php tests/Unit/Auth/ManagedEnvironmentAccessScopeResolverTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Filament/WorkspaceMembershipRoleManagementTest.php tests/Feature/Rbac/GovernanceArtifactsWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/OperationRunWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Verification/ProviderExecutionReauthorizationTest.php tests/Feature/ProviderConnections/ProviderConnectionHealthCheckStartSurfaceTest.php tests/Feature/Tenants/TenantProviderBackedActionStartTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Audit/TenantMembershipAuditLogTest.php tests/Feature/Filament/TenantMembersTest.php tests/Feature/TenantRBAC/TenantMembershipCrudTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Target branch: `platform-dev`. Follow-up integration path after merge: - `platform-dev` -> `dev`. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #344
162 lines
5.6 KiB
PHP
162 lines
5.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ProviderConnectionResource\Pages\ListProviderConnections;
|
|
use App\Jobs\ProviderConnectionHealthCheckJob;
|
|
use App\Models\OperationRun;
|
|
use App\Models\ProviderConnection;
|
|
use App\Services\Auth\CapabilityResolver;
|
|
use App\Services\Auth\ManagedEnvironmentAccessScopeResolver;
|
|
use App\Services\Auth\WorkspaceCapabilityResolver;
|
|
use App\Support\Auth\Capabilities;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Livewire\Livewire;
|
|
|
|
function runQueuedJobThroughMiddleware(object $job, Closure $terminal): mixed
|
|
{
|
|
$pipeline = array_reduce(
|
|
array_reverse($job->middleware()),
|
|
fn (Closure $next, object $middleware): Closure => fn (object $job): mixed => $middleware->handle($job, $next),
|
|
$terminal,
|
|
);
|
|
|
|
return $pipeline($job);
|
|
}
|
|
|
|
it('stores actor-bound execution metadata when verification is queued', function (): void {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'operator', fixtureProfile: 'credential-enabled');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$connection = ProviderConnection::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('provider', 'microsoft')
|
|
->where('is_default', true)
|
|
->firstOrFail();
|
|
|
|
Livewire::test(ListProviderConnections::class)
|
|
->callTableAction('check_connection', $connection);
|
|
|
|
$opRun = OperationRun::query()
|
|
->where('managed_environment_id', $tenant->getKey())
|
|
->where('type', 'provider.connection.check')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($opRun)->not->toBeNull()
|
|
->and($opRun?->context)->toMatchArray([
|
|
'execution_authority_mode' => 'actor_bound',
|
|
'required_capability' => 'provider.run',
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
});
|
|
|
|
it('blocks verification execution when the initiator loses provider capability before start', function (): void {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'operator', fixtureProfile: 'credential-enabled');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$connection = ProviderConnection::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('provider', 'microsoft')
|
|
->where('is_default', true)
|
|
->firstOrFail();
|
|
|
|
Livewire::test(ListProviderConnections::class)
|
|
->callTableAction('check_connection', $connection);
|
|
|
|
$capturedJob = null;
|
|
|
|
Queue::assertPushed(ProviderConnectionHealthCheckJob::class, function (ProviderConnectionHealthCheckJob $job) use (&$capturedJob): bool {
|
|
$capturedJob = $job;
|
|
|
|
return true;
|
|
});
|
|
|
|
expect($capturedJob)->toBeInstanceOf(ProviderConnectionHealthCheckJob::class);
|
|
|
|
$user->workspaceMemberships()->where('workspace_id', (int) $tenant->workspace_id)->update(['role' => 'readonly']);
|
|
app(CapabilityResolver::class)->clearCache();
|
|
app(WorkspaceCapabilityResolver::class)->clearCache();
|
|
app(ManagedEnvironmentAccessScopeResolver::class)->clearCache();
|
|
|
|
$terminalInvoked = false;
|
|
|
|
runQueuedJobThroughMiddleware(
|
|
$capturedJob,
|
|
function (ProviderConnectionHealthCheckJob $job) use (&$terminalInvoked): mixed {
|
|
$terminalInvoked = true;
|
|
|
|
return $job;
|
|
},
|
|
);
|
|
|
|
$capturedJob->operationRun?->refresh();
|
|
|
|
expect($terminalInvoked)->toBeFalse()
|
|
->and($capturedJob->operationRun?->outcome?->value ?? $capturedJob->operationRun?->outcome)->toBe('blocked')
|
|
->and($capturedJob->operationRun?->context['reason_code'] ?? null)->toBe('missing_capability')
|
|
->and($capturedJob->operationRun?->context['execution_legitimacy']['metadata']['required_capability'] ?? null)->toBe(Capabilities::PROVIDER_RUN);
|
|
});
|
|
|
|
it('blocks verification execution when the initiator loses workspace membership before start', function (): void {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'operator', fixtureProfile: 'credential-enabled');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$connection = ProviderConnection::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('provider', 'microsoft')
|
|
->where('is_default', true)
|
|
->firstOrFail();
|
|
|
|
Livewire::test(ListProviderConnections::class)
|
|
->callTableAction('check_connection', $connection);
|
|
|
|
$capturedJob = null;
|
|
|
|
Queue::assertPushed(ProviderConnectionHealthCheckJob::class, function (ProviderConnectionHealthCheckJob $job) use (&$capturedJob): bool {
|
|
$capturedJob = $job;
|
|
|
|
return true;
|
|
});
|
|
|
|
expect($capturedJob)->toBeInstanceOf(ProviderConnectionHealthCheckJob::class);
|
|
|
|
$user->workspaceMemberships()->where('workspace_id', (int) $tenant->workspace_id)->delete();
|
|
app(CapabilityResolver::class)->clearCache();
|
|
app(WorkspaceCapabilityResolver::class)->clearCache();
|
|
app(ManagedEnvironmentAccessScopeResolver::class)->clearCache();
|
|
|
|
$terminalInvoked = false;
|
|
|
|
runQueuedJobThroughMiddleware(
|
|
$capturedJob,
|
|
function (ProviderConnectionHealthCheckJob $job) use (&$terminalInvoked): mixed {
|
|
$terminalInvoked = true;
|
|
|
|
return $job;
|
|
},
|
|
);
|
|
|
|
$capturedJob->operationRun?->refresh();
|
|
|
|
expect($terminalInvoked)->toBeFalse()
|
|
->and($capturedJob->operationRun?->outcome?->value ?? $capturedJob->operationRun?->outcome)->toBe('blocked')
|
|
->and($capturedJob->operationRun?->context['reason_code'] ?? null)->toBe('initiator_not_entitled');
|
|
});
|