ahmido
c86b399b43
Some checks failed
Main Confidence / confidence (push) Failing after 53s
## Summary This PR delivers three related improvements: ### 1. Finding Ownership Semantics (Spec 219) - Add responsibility/accountability labels to findings and finding exceptions - `owner_user_id` = accountable party (governance owner) - `assignee_user_id` = responsible party (technical implementer) - Expose Assign/Reassign actions in FindingResource with audit logging - Add ownership columns and filters to finding list - Propagate owner from finding to exception on creation - Tests: ownership semantics, assignment audit, workflow actions ### 2. Constitution v2.7.0 — LEAN-001 Pre-Production Lean Doctrine - New principle forbidding legacy aliases, migration shims, dual-write logic, and compatibility fixtures in a pre-production codebase - AI-agent 4-question verification gate before adding any compatibility path - Review rule: compatibility shims without answering the gate questions = merge blocker - Exit condition: LEAN-001 expires at first production deployment - Spec template: added default "Compatibility posture" block - Agent instructions: added "Pre-production compatibility check" section ### 3. Backup Set Operation Type Unification - Unified `backup_set.add_policies` and `backup_set.remove_policies` into single canonical `backup_set.update` - Removed all legacy aliases, constants, and test fixtures - Added lifecycle coverage for `backup_set.update` in config - Updated all 14+ test files referencing legacy types ### Spec Artifacts - `specs/219-finding-ownership-semantics/` — full spec, plan, tasks, research, data model, contracts, checklist ### Tests - All affected tests pass (OperationCatalog, backup set, finding workflow, ownership semantics) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #256
82 lines
2.8 KiB
PHP
82 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\BackupSet;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('renders operation run related context with backup set details', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$backupSet = BackupSet::factory()->for($tenant)->create([
|
|
'name' => 'Nightly backup',
|
|
]);
|
|
|
|
$run = OperationRun::factory()->for($tenant)->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'backup_set.update',
|
|
'context' => [
|
|
'backup_set_id' => (int) $backupSet->getKey(),
|
|
],
|
|
]);
|
|
|
|
$this->get(OperationRunLinks::tenantlessView($run))
|
|
->assertOk()
|
|
->assertSee('Nightly backup')
|
|
->assertSee('Backup set #'.$backupSet->getKey());
|
|
});
|
|
|
|
it('keeps archived run references viewable with lifecycle-aware framing', function (): void {
|
|
$activeTenant = Tenant::factory()->create([
|
|
'name' => 'Active Tenant',
|
|
]);
|
|
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$archivedTenant = Tenant::factory()->create([
|
|
'name' => 'Archived Tenant',
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner');
|
|
$archivedTenant->delete();
|
|
|
|
$run = OperationRun::factory()->for($archivedTenant)->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'type' => 'policy.sync',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
|
->get(OperationRunLinks::tenantlessView($run))
|
|
->assertOk()
|
|
->assertSee('Operation tenant is not available in the current tenant selector')
|
|
->assertSee('This tenant is currently archived')
|
|
->assertSee('Back to Operations')
|
|
->assertDontSee('← Back to Archived Tenant');
|
|
});
|
|
|
|
it('resolves legacy operation values to canonical operation metadata on read paths', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$run = OperationRun::factory()->for($tenant)->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'backup_schedule_run',
|
|
]);
|
|
|
|
expect($run->canonicalOperationType())->toBe('backup.schedule.execute');
|
|
|
|
$this->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get(OperationRunLinks::tenantlessView($run))
|
|
->assertOk()
|
|
->assertSee('Backup schedule run')
|
|
->assertDontSee('backup_schedule_run');
|
|
});
|