Some checks failed
Main Confidence / confidence (push) Failing after 53s
## Summary This PR delivers three related improvements: ### 1. Finding Ownership Semantics (Spec 219) - Add responsibility/accountability labels to findings and finding exceptions - `owner_user_id` = accountable party (governance owner) - `assignee_user_id` = responsible party (technical implementer) - Expose Assign/Reassign actions in FindingResource with audit logging - Add ownership columns and filters to finding list - Propagate owner from finding to exception on creation - Tests: ownership semantics, assignment audit, workflow actions ### 2. Constitution v2.7.0 — LEAN-001 Pre-Production Lean Doctrine - New principle forbidding legacy aliases, migration shims, dual-write logic, and compatibility fixtures in a pre-production codebase - AI-agent 4-question verification gate before adding any compatibility path - Review rule: compatibility shims without answering the gate questions = merge blocker - Exit condition: LEAN-001 expires at first production deployment - Spec template: added default "Compatibility posture" block - Agent instructions: added "Pre-production compatibility check" section ### 3. Backup Set Operation Type Unification - Unified `backup_set.add_policies` and `backup_set.remove_policies` into single canonical `backup_set.update` - Removed all legacy aliases, constants, and test fixtures - Added lifecycle coverage for `backup_set.update` in config - Updated all 14+ test files referencing legacy types ### Spec Artifacts - `specs/219-finding-ownership-semantics/` — full spec, plan, tasks, research, data model, contracts, checklist ### Tests - All affected tests pass (OperationCatalog, backup set, finding workflow, ownership semantics) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #256
160 lines
6.0 KiB
PHP
160 lines
6.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\BaselineSnapshotResource;
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\BaselineSnapshot;
|
|
use App\Models\Finding;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Services\Auth\WorkspaceCapabilityResolver;
|
|
use App\Support\Navigation\CrossResourceNavigationMatrix;
|
|
use App\Support\Navigation\RelatedNavigationResolver;
|
|
use App\Support\Ui\DerivedState\DerivedStateFamily;
|
|
use App\Support\Ui\DerivedState\DerivedStateKey;
|
|
use App\Support\Ui\DerivedState\RequestScopedDerivedStateStore;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('reuses finding related navigation and caches deterministic negative results', function (): void {
|
|
[$user, $tenant] = createMinimalUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Security Baseline',
|
|
]);
|
|
|
|
$snapshot = BaselineSnapshot::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
]);
|
|
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
]);
|
|
|
|
$run = OperationRun::factory()->minimal()->forTenant($tenant)->create([
|
|
'type' => 'baseline_compare',
|
|
]);
|
|
|
|
$finding = Finding::factory()->for($tenant)->create([
|
|
'current_operation_run_id' => (int) $run->getKey(),
|
|
'evidence_jsonb' => [
|
|
'current' => [
|
|
'policy_version_id' => (int) $version->getKey(),
|
|
],
|
|
'provenance' => [
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
'baseline_snapshot_id' => (int) $snapshot->getKey(),
|
|
'compare_operation_run_id' => (int) $run->getKey(),
|
|
],
|
|
],
|
|
]);
|
|
|
|
$resolver = app(RelatedNavigationResolver::class);
|
|
$first = $resolver->primaryListAction(CrossResourceNavigationMatrix::SOURCE_FINDING, $finding);
|
|
$second = $resolver->primaryListAction(CrossResourceNavigationMatrix::SOURCE_FINDING, $finding);
|
|
|
|
expect($first?->targetUrl)->toBe($second?->targetUrl);
|
|
|
|
$store = app(RequestScopedDerivedStateStore::class);
|
|
|
|
expect($store->countStored(
|
|
DerivedStateFamily::RelatedNavigationPrimary,
|
|
Finding::class,
|
|
(string) $finding->getKey(),
|
|
CrossResourceNavigationMatrix::SOURCE_FINDING,
|
|
))->toBe(1);
|
|
|
|
$orphanedFinding = Finding::factory()->for($tenant)->create([
|
|
'evidence_jsonb' => [],
|
|
]);
|
|
|
|
expect($resolver->primaryListAction(CrossResourceNavigationMatrix::SOURCE_FINDING, $orphanedFinding))->toBeNull()
|
|
->and($resolver->primaryListAction(CrossResourceNavigationMatrix::SOURCE_FINDING, $orphanedFinding))->toBeNull();
|
|
|
|
$negativeKey = DerivedStateKey::fromModel(
|
|
DerivedStateFamily::RelatedNavigationPrimary,
|
|
$orphanedFinding,
|
|
CrossResourceNavigationMatrix::SOURCE_FINDING,
|
|
[
|
|
'source_type' => CrossResourceNavigationMatrix::SOURCE_FINDING,
|
|
'surface' => CrossResourceNavigationMatrix::SURFACE_LIST_ROW,
|
|
'active_tenant_id' => (int) $tenant->getKey(),
|
|
'route_name' => null,
|
|
'user_id' => (int) $user->getKey(),
|
|
],
|
|
);
|
|
|
|
expect($store->resolutionRecord($negativeKey)['negative_result'])->toBeTrue();
|
|
});
|
|
|
|
it('reuses operation-run related context across detail and header consumers', function (): void {
|
|
[$user, $tenant] = createMinimalUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->minimal()->forTenant($tenant)->create([
|
|
'type' => 'backup_set.update',
|
|
'context' => [
|
|
'backup_set_id' => 123,
|
|
],
|
|
]);
|
|
|
|
$resolver = app(RelatedNavigationResolver::class);
|
|
|
|
$resolver->detailEntries(CrossResourceNavigationMatrix::SOURCE_OPERATION_RUN, $run);
|
|
$resolver->operationLinks($run, $tenant);
|
|
|
|
expect(app(RequestScopedDerivedStateStore::class)->countStored(
|
|
DerivedStateFamily::RelatedNavigationDetail,
|
|
OperationRun::class,
|
|
(string) $run->getKey(),
|
|
CrossResourceNavigationMatrix::SOURCE_OPERATION_RUN,
|
|
))->toBe(1);
|
|
});
|
|
|
|
it('keeps related-navigation target routes tenant-safe for non-members and capability-limited members', function (): void {
|
|
$workspaceTenant = \App\Models\Tenant::factory()->create();
|
|
[$member, $workspaceTenant] = createMinimalUserWithTenant(tenant: $workspaceTenant, role: 'readonly');
|
|
$nonMember = \App\Models\User::factory()->create();
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $workspaceTenant->workspace_id,
|
|
]);
|
|
|
|
$snapshot = BaselineSnapshot::factory()->create([
|
|
'workspace_id' => (int) $workspaceTenant->workspace_id,
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($nonMember)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspaceTenant->workspace_id])
|
|
->get(BaselineSnapshotResource::getUrl('view', ['record' => $snapshot], panel: 'admin'))
|
|
->assertNotFound();
|
|
|
|
$resolver = \Mockery::mock(WorkspaceCapabilityResolver::class);
|
|
$resolver->shouldReceive('isMember')->andReturnTrue();
|
|
$resolver->shouldReceive('can')->andReturnFalse();
|
|
app()->instance(WorkspaceCapabilityResolver::class, $resolver);
|
|
|
|
$this->actingAs($member)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspaceTenant->workspace_id])
|
|
->get(BaselineSnapshotResource::getUrl('view', ['record' => $snapshot], panel: 'admin'))
|
|
->assertForbidden();
|
|
});
|