Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
172 lines
6.1 KiB
PHP
172 lines
6.1 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\TenantResource\Pages\ListTenants;
|
|
use App\Jobs\BulkTenantSyncJob;
|
|
use App\Models\Tenant;
|
|
use App\Support\Auth\UiTooltips;
|
|
use Filament\Events\TenantSet;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Bus;
|
|
use Illuminate\Support\Facades\Http;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function (): void {
|
|
Http::preventStrayRequests();
|
|
});
|
|
|
|
test('tenant-scoped pages return 404 for unauthorized tenant', function () {
|
|
[$user, $authorizedTenant] = createUserWithTenant();
|
|
$unauthorizedTenant = Tenant::factory()->create();
|
|
|
|
$this->actingAs($user)
|
|
->get(route('filament.tenant.resources.policies.index', filamentTenantRouteParams($unauthorizedTenant)))
|
|
->assertNotFound();
|
|
});
|
|
|
|
test('tenant portfolio tenant view returns 404 for non-member tenant record', function () {
|
|
$authorizedTenant = Tenant::factory()->create(['tenant_id' => 'tenant-portfolio-authorized-view']);
|
|
$unauthorizedTenant = Tenant::factory()->create(['tenant_id' => 'tenant-portfolio-unauthorized-view']);
|
|
|
|
[$user, $authorizedTenant] = createUserWithTenant($authorizedTenant, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$this->get(route('filament.admin.resources.tenants.view', array_merge(
|
|
filamentTenantRouteParams($unauthorizedTenant),
|
|
['record' => $unauthorizedTenant],
|
|
)))->assertNotFound();
|
|
});
|
|
|
|
test('tenant portfolio tenant edit returns 404 for non-member tenant record', function () {
|
|
$authorizedTenant = Tenant::factory()->create(['tenant_id' => 'tenant-portfolio-authorized-edit']);
|
|
$unauthorizedTenant = Tenant::factory()->create(['tenant_id' => 'tenant-portfolio-unauthorized-edit']);
|
|
|
|
[$user, $authorizedTenant] = createUserWithTenant($authorizedTenant, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$this->get(route('filament.admin.resources.tenants.edit', array_merge(
|
|
filamentTenantRouteParams($unauthorizedTenant),
|
|
['record' => $unauthorizedTenant],
|
|
)))->assertNotFound();
|
|
});
|
|
|
|
test('tenant portfolio lists only tenants the user can access', function () {
|
|
$authorizedTenant = Tenant::factory()->create([
|
|
'tenant_id' => 'tenant-portfolio-authorized',
|
|
'name' => 'Authorized Tenant',
|
|
]);
|
|
|
|
$unauthorizedTenant = Tenant::factory()->create([
|
|
'tenant_id' => 'tenant-portfolio-unauthorized',
|
|
'name' => 'Unauthorized Tenant',
|
|
]);
|
|
|
|
[$user, $authorizedTenant] = createUserWithTenant($authorizedTenant, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$this->get(route('filament.admin.resources.tenants.index', filamentTenantRouteParams($authorizedTenant)))
|
|
->assertOk()
|
|
->assertSee($authorizedTenant->name)
|
|
->assertDontSee($unauthorizedTenant->name);
|
|
});
|
|
|
|
test('tenant portfolio bulk sync dispatches one job per eligible tenant', function () {
|
|
Bus::fake();
|
|
|
|
$tenantA = Tenant::factory()->create(['tenant_id' => 'tenant-bulk-a']);
|
|
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'tenant_id' => 'tenant-bulk-b',
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'operator'],
|
|
]);
|
|
|
|
Filament::setTenant($tenantA, true);
|
|
|
|
Livewire::test(ListTenants::class)
|
|
->assertTableBulkActionVisible('syncSelected')
|
|
->callTableBulkAction('syncSelected', collect([$tenantA, $tenantB]));
|
|
|
|
Bus::assertDispatchedTimes(BulkTenantSyncJob::class, 1);
|
|
|
|
$this->assertDatabaseHas('operation_runs', [
|
|
'tenant_id' => $tenantA->id,
|
|
'user_id' => $user->id,
|
|
'type' => 'tenant.sync',
|
|
'status' => 'queued',
|
|
]);
|
|
});
|
|
|
|
test('tenant portfolio bulk sync is disabled for readonly users', function () {
|
|
Bus::fake();
|
|
|
|
$tenant = Tenant::factory()->create(['tenant_id' => 'tenant-bulk-readonly']);
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'readonly');
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$livewire = Livewire::actingAs($user)
|
|
->test(ListTenants::class)
|
|
->selectTableRecords([$tenant])
|
|
->assertTableBulkActionVisible('syncSelected')
|
|
->assertTableBulkActionDisabled('syncSelected');
|
|
|
|
$actions = $livewire->parseNestedTableBulkActions('syncSelected');
|
|
$livewire->assertActionExists($actions, fn ($action): bool => $action->getTooltip() === UiTooltips::insufficientPermission());
|
|
|
|
$livewire->callTableBulkAction('syncSelected', collect([$tenant]));
|
|
|
|
Bus::assertNotDispatched(BulkTenantSyncJob::class);
|
|
});
|
|
|
|
test('tenant portfolio bulk sync is disabled when selection includes unauthorized tenants', function () {
|
|
Bus::fake();
|
|
|
|
$tenantA = Tenant::factory()->create(['tenant_id' => 'tenant-bulk-mixed-a']);
|
|
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'tenant_id' => 'tenant-bulk-mixed-b',
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
Filament::setTenant($tenantA, true);
|
|
|
|
$livewire = Livewire::actingAs($user)
|
|
->test(ListTenants::class)
|
|
->selectTableRecords([$tenantA, $tenantB])
|
|
->assertTableBulkActionVisible('syncSelected')
|
|
->assertTableBulkActionDisabled('syncSelected');
|
|
|
|
$actions = $livewire->parseNestedTableBulkActions('syncSelected');
|
|
$livewire->assertActionExists($actions, fn ($action): bool => $action->getTooltip() === UiTooltips::insufficientPermission());
|
|
|
|
$livewire->callTableBulkAction('syncSelected', collect([$tenantA, $tenantB]));
|
|
|
|
Bus::assertNotDispatched(BulkTenantSyncJob::class);
|
|
});
|
|
|
|
test('tenant set event updates user tenant preference last used timestamp', function () {
|
|
[$user, $tenant] = createUserWithTenant();
|
|
|
|
TenantSet::dispatch($tenant, $user);
|
|
|
|
$this->assertDatabaseHas('user_tenant_preferences', [
|
|
'user_id' => $user->id,
|
|
'tenant_id' => $tenant->id,
|
|
]);
|
|
});
|