ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
84 lines
2.8 KiB
PHP
84 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Tenant;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Http;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function (): void {
|
|
Http::preventStrayRequests();
|
|
});
|
|
|
|
it('renders tenant scope label and CTAs when tenant context is active and entitled', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee('Scope: Tenant — '.$tenant->name)
|
|
->assertSee('Back to '.$tenant->name)
|
|
->assertSee('Show all tenants');
|
|
});
|
|
|
|
it('treats stale tenant context as workspace-wide without tenant identity hints', function (): void {
|
|
$entitledTenant = Tenant::factory()->create();
|
|
[$user, $entitledTenant] = createUserWithTenant($entitledTenant, role: 'owner', workspaceRole: 'readonly');
|
|
|
|
$staleTenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $entitledTenant->workspace_id,
|
|
]);
|
|
|
|
Filament::setTenant($staleTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $entitledTenant->workspace_id])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee('Scope: Workspace — all tenants')
|
|
->assertDontSee('Back to '.$staleTenant->name)
|
|
->assertDontSee($staleTenant->name)
|
|
->assertDontSee('Show all tenants');
|
|
});
|
|
|
|
it('clears filament tenant context and last-tenant session state via clear-tenant-context endpoint', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$workspaceId = (int) $tenant->workspace_id;
|
|
$lastTenantIds = [
|
|
(string) $workspaceId => (int) $tenant->getKey(),
|
|
];
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => $workspaceId,
|
|
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => $lastTenantIds,
|
|
])
|
|
->from('/admin/alerts')
|
|
->post('/admin/clear-tenant-context')
|
|
->assertRedirect('/admin/alerts');
|
|
|
|
expect(Filament::getTenant())->toBeNull();
|
|
expect(session()->get(WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY, []))
|
|
->not->toHaveKey((string) $workspaceId);
|
|
|
|
$this->withSession([
|
|
WorkspaceContext::SESSION_KEY => $workspaceId,
|
|
])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee('Scope: Workspace — all tenants')
|
|
->assertDontSee('Scope: Tenant — '.$tenant->name);
|
|
});
|