ahmido
da1adbdeb5
Implements Spec 119 (Drift Golden Master Cutover): - Baseline Compare is the only drift writer (`source = baseline.compare`). - Drift findings now store diff-compatible `evidence_jsonb` (summary.kind, baseline/current policy_version_id refs, fidelity + provenance). - Findings UI renders one-sided diffs for `missing_policy`/`unexpected_policy` when a single ref exists; otherwise shows explicit “diff unavailable”. - Removes legacy drift generator runtime (jobs/services/UI) and related tests. - Adds one-time migration to delete legacy drift findings (`finding_type=drift` where source is null or != baseline.compare). - Scopes baseline capture & landing duplicate warnings to latest completed inventory sync. - Canonicalizes compliance `scheduledActionsForRule` drift signal and keeps legacy snapshots comparable. Tests: - `vendor/bin/sail artisan test --compact` (full suite per tasks) - Focused pack: BaselinePolicyVersionResolverTest, BaselineCompareDriftEvidenceContractTest, DriftFindingDiffUnavailableTest, LegacyDriftFindingsCleanupMigrationTest, ComplianceNoncomplianceActionsDriftTest Notes: - Livewire v4+ / Filament v5 compatible (no legacy APIs). - No new external dependencies. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #144
47 lines
1.3 KiB
PHP
47 lines
1.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Services\System\AllowedTenantUniverse;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Validation\ValidationException;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('excludes the platform tenant from the allowed universe query (picker)', function () {
|
|
$platformTenant = Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$customerTenant = Tenant::factory()->create([
|
|
'external_id' => 'tenant-1',
|
|
'name' => 'Tenant One',
|
|
]);
|
|
|
|
$universe = app(AllowedTenantUniverse::class);
|
|
|
|
$ids = $universe->query()->orderBy('id')->pluck('id')->all();
|
|
|
|
expect($ids)->toContain((int) $customerTenant->getKey());
|
|
expect($ids)->not->toContain((int) $platformTenant->getKey());
|
|
});
|
|
|
|
it('rejects attempts to target the platform tenant', function () {
|
|
$platformTenant = Tenant::factory()->create([
|
|
'tenant_id' => null,
|
|
'external_id' => 'platform',
|
|
'name' => 'Platform',
|
|
]);
|
|
|
|
$universe = app(AllowedTenantUniverse::class);
|
|
|
|
expect(fn () => $universe->ensureAllowed($platformTenant))
|
|
->toThrow(ValidationException::class);
|
|
|
|
expect(OperationRun::query()->count())->toBe(0);
|
|
});
|