## Summary - replace broad substring-based masking with a shared exact/path-based secret classifier and workspace-scoped fingerprint hashing - persist protected snapshot metadata on `policy_versions` and keep secret-only changes visible in compare, drift, restore, review, verification, and ops surfaces - add Spec 120 artifacts, audit documentation, and focused Pest regression coverage for snapshot, audit, verification, review-pack, and notification behavior ## Validation - `vendor/bin/sail artisan test --compact tests/Feature/Intune/PolicySnapshotRedactionTest.php tests/Feature/Intune/PolicySnapshotFingerprintIsolationTest.php tests/Feature/ReviewPack/ReviewPackRedactionIntegrityTest.php tests/Feature/OpsUx/OperationRunNotificationRedactionTest.php tests/Feature/Verification/VerificationReportViewerDbOnlyTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Spec / checklist status | Checklist | Total | Completed | Incomplete | Status | |-----------|-------|-----------|------------|--------| | requirements.md | 16 | 16 | 0 | ✓ PASS | - `tasks.md`: T001-T032 complete - `tasks.md`: T033 manual quickstart validation is still open and noted for follow-up ## Filament / platform notes - Livewire v4 compliance is unchanged - no panel provider changes; `bootstrap/providers.php` remains the registration location - no new globally searchable resources were introduced, so global search requirements are unchanged - no new destructive Filament actions were added - no new Filament assets were added; no `filament:assets` deployment change is required ## Testing coverage touched - snapshot persistence and fingerprint isolation - compare/drift protected-change evidence - audit, verification, review-pack, ops-failure, and notification sanitization - viewer/read-only Filament presentation updates Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #146
22 lines
909 B
PHP
22 lines
909 B
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Services\Intune\SecretClassificationService;
|
|
|
|
it('protects exact secret fields and keeps safe configuration language visible', function (): void {
|
|
$service = app(SecretClassificationService::class);
|
|
|
|
expect($service->protectsField('snapshot', 'password'))->toBeTrue();
|
|
expect($service->protectsField('snapshot', 'clientSecret'))->toBeTrue();
|
|
expect($service->protectsField('snapshot', 'passwordMinimumLength'))->toBeFalse();
|
|
expect($service->protectsField('snapshot', 'tokenType'))->toBeFalse();
|
|
});
|
|
|
|
it('supports exact path-based protection decisions', function (): void {
|
|
$service = app(SecretClassificationService::class);
|
|
|
|
expect($service->protectsField('snapshot', 'password', '/wifi/password'))->toBeTrue();
|
|
expect($service->protectsField('snapshot', 'passwordMinimumLength', '/settings/passwordMinimumLength'))->toBeFalse();
|
|
});
|