Kontext / Ziel Diese PR standardisiert Tenant‑RBAC Enforcement in der Filament‑UI: statt ad-hoc Gate::*, abort_if/abort_unless und kopierten ->visible()/->disabled()‑Closures gibt es jetzt eine zentrale, wiederverwendbare Implementierung für Actions (Header/Table/Bulk). Links zur Spec: spec.md plan.md quickstart.md Was ist drin Neue zentrale Helper-API: UiEnforcement (Tenant-plane RBAC‑UX “source of truth” für Filament Actions) Standardisierte Tooltip-Texte und Context-DTO (UiTooltips, TenantAccessContext) Migration vieler tenant‑scoped Filament Action-Surfaces auf das Standardpattern (ohne ad-hoc Auth-Patterns) CI‑Guard (Test) gegen neue ad-hoc Patterns in app/Filament/**: verbietet Gate::allows/denies/check/authorize, use Illuminate\Support\Facades\Gate, abort_if/abort_unless Legacy-Allowlist ist aktuell leer (neue Verstöße failen sofort) RBAC-UX Semantik (konsequent & testbar) Non-member: UI Actions hidden (kein Tenant‑Leak); Execution wird blockiert (Filament hidden→disabled chain), Defense‑in‑depth enthält zusätzlich serverseitige Guards. Member ohne Capability: Action visible aber disabled + Standard-Tooltip; Execution wird blockiert (keine Side Effects). Member mit Capability: Action enabled und ausführbar. Destructive actions: über ->destructive() immer mit ->requiresConfirmation() + klare Warntexte (Execution bleibt über ->action(...)). Wichtig: In Filament v5 sind hidden/disabled Actions typischerweise “silently blocked” (200, keine Ausführung). Die Tests prüfen daher UI‑State + “no side effects”, nicht nur HTTP‑Statuscodes. Sicherheit / Scope Keine neuen DB-Tabellen, keine Migrations, keine Microsoft Graph Calls (DB‑only bei Render; kein outbound HTTP). Tenant Isolation bleibt Isolation‑Boundary (deny-as-not-found auf Tenant‑Ebene, Capability erst nach Membership). Kein Asset-Setup erforderlich; keine neuen Filament Assets. Compliance Notes (Repo-Regeln) Filament v5 / Livewire v4.0+ kompatibel. Keine Änderungen an Provider‑Registrierung (Laravel 11+/12: providers.php bleibt der Ort; hier unverändert). Global Search: keine gezielte Änderung am Global‑Search-Verhalten in dieser PR. Tests / Qualität Pest Feature/Unit Tests für Member/Non-member/Tooltip/Destructive/Regression‑Guard. Guard-Test: “No ad-hoc Filament auth patterns”. Full suite laut Tasks: vendor/bin/sail artisan test --compact → 837 passed, 5 skipped. Checklist: requirements.md vollständig (16/16). Review-Fokus API‑Usage in neuen/angepassten Filament Actions: UiEnforcement::forAction/forTableAction/forBulkAction(...)->requireCapability(...)->apply() Guard-Test soll “red” werden, sobald jemand neue ad-hoc Auth‑Patterns einführt (by design). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #81
207 lines
8.9 KiB
PHP
207 lines
8.9 KiB
PHP
<?php
|
|
|
|
namespace App\Filament\Resources\TenantResource\RelationManagers;
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\TenantMembership;
|
|
use App\Models\User;
|
|
use App\Services\Auth\TenantMembershipManager;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\Rbac\UiEnforcement;
|
|
use Filament\Actions\Action;
|
|
use Filament\Forms;
|
|
use Filament\Notifications\Notification;
|
|
use Filament\Resources\RelationManagers\RelationManager;
|
|
use Filament\Tables;
|
|
use Filament\Tables\Table;
|
|
use Illuminate\Database\Eloquent\Builder;
|
|
|
|
class TenantMembershipsRelationManager extends RelationManager
|
|
{
|
|
protected static string $relationship = 'memberships';
|
|
|
|
public function table(Table $table): Table
|
|
{
|
|
return $table
|
|
->modifyQueryUsing(fn (Builder $query) => $query->with('user'))
|
|
->columns([
|
|
Tables\Columns\TextColumn::make('user.name')
|
|
->label(__('User'))
|
|
->searchable(),
|
|
Tables\Columns\TextColumn::make('user.email')
|
|
->label(__('Email'))
|
|
->toggleable(isToggledHiddenByDefault: true),
|
|
Tables\Columns\TextColumn::make('role')
|
|
->badge()
|
|
->sortable(),
|
|
Tables\Columns\TextColumn::make('source')
|
|
->badge()
|
|
->toggleable(isToggledHiddenByDefault: true),
|
|
Tables\Columns\TextColumn::make('created_at')->since(),
|
|
])
|
|
->headerActions([
|
|
UiEnforcement::forTableAction(
|
|
Action::make('add_member')
|
|
->label(__('Add member'))
|
|
->icon('heroicon-o-plus')
|
|
->form([
|
|
Forms\Components\Select::make('user_id')
|
|
->label(__('User'))
|
|
->required()
|
|
->searchable()
|
|
->options(fn () => User::query()->orderBy('name')->pluck('name', 'id')->all()),
|
|
Forms\Components\Select::make('role')
|
|
->label(__('Role'))
|
|
->required()
|
|
->options([
|
|
'owner' => __('Owner'),
|
|
'manager' => __('Manager'),
|
|
'operator' => __('Operator'),
|
|
'readonly' => __('Readonly'),
|
|
]),
|
|
])
|
|
->action(function (array $data, TenantMembershipManager $manager): void {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
abort(404);
|
|
}
|
|
|
|
$actor = auth()->user();
|
|
if (! $actor instanceof User) {
|
|
abort(403);
|
|
}
|
|
|
|
$member = User::query()->find((int) $data['user_id']);
|
|
if (! $member) {
|
|
Notification::make()->title(__('User not found'))->danger()->send();
|
|
|
|
return;
|
|
}
|
|
|
|
try {
|
|
$manager->addMember(
|
|
tenant: $tenant,
|
|
actor: $actor,
|
|
member: $member,
|
|
role: (string) $data['role'],
|
|
source: 'manual',
|
|
);
|
|
} catch (\Throwable $throwable) {
|
|
Notification::make()
|
|
->title(__('Failed to add member'))
|
|
->body($throwable->getMessage())
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
Notification::make()->title(__('Member added'))->success()->send();
|
|
$this->resetTable();
|
|
}),
|
|
fn () => $this->getOwnerRecord(),
|
|
)
|
|
->requireCapability(Capabilities::TENANT_MEMBERSHIP_MANAGE)
|
|
->tooltip('You do not have permission to manage tenant memberships.')
|
|
->apply(),
|
|
])
|
|
->actions([
|
|
UiEnforcement::forTableAction(
|
|
Action::make('change_role')
|
|
->label(__('Change role'))
|
|
->icon('heroicon-o-pencil')
|
|
->requiresConfirmation()
|
|
->form([
|
|
Forms\Components\Select::make('role')
|
|
->label(__('Role'))
|
|
->required()
|
|
->options([
|
|
'owner' => __('Owner'),
|
|
'manager' => __('Manager'),
|
|
'operator' => __('Operator'),
|
|
'readonly' => __('Readonly'),
|
|
]),
|
|
])
|
|
->action(function (TenantMembership $record, array $data, TenantMembershipManager $manager): void {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
abort(404);
|
|
}
|
|
|
|
$actor = auth()->user();
|
|
if (! $actor instanceof User) {
|
|
abort(403);
|
|
}
|
|
|
|
try {
|
|
$manager->changeRole(
|
|
tenant: $tenant,
|
|
actor: $actor,
|
|
membership: $record,
|
|
newRole: (string) $data['role'],
|
|
);
|
|
} catch (\Throwable $throwable) {
|
|
Notification::make()
|
|
->title(__('Failed to change role'))
|
|
->body($throwable->getMessage())
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
Notification::make()->title(__('Role updated'))->success()->send();
|
|
$this->resetTable();
|
|
}),
|
|
fn () => $this->getOwnerRecord(),
|
|
)
|
|
->requireCapability(Capabilities::TENANT_MEMBERSHIP_MANAGE)
|
|
->tooltip('You do not have permission to manage tenant memberships.')
|
|
->apply(),
|
|
|
|
UiEnforcement::forTableAction(
|
|
Action::make('remove')
|
|
->label(__('Remove'))
|
|
->color('danger')
|
|
->icon('heroicon-o-x-mark')
|
|
->requiresConfirmation()
|
|
->action(function (TenantMembership $record, TenantMembershipManager $manager): void {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
abort(404);
|
|
}
|
|
|
|
$actor = auth()->user();
|
|
if (! $actor instanceof User) {
|
|
abort(403);
|
|
}
|
|
|
|
try {
|
|
$manager->removeMember($tenant, $actor, $record);
|
|
} catch (\Throwable $throwable) {
|
|
Notification::make()
|
|
->title(__('Failed to remove member'))
|
|
->body($throwable->getMessage())
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
Notification::make()->title(__('Member removed'))->success()->send();
|
|
$this->resetTable();
|
|
}),
|
|
fn () => $this->getOwnerRecord(),
|
|
)
|
|
->requireCapability(Capabilities::TENANT_MEMBERSHIP_MANAGE)
|
|
->tooltip('You do not have permission to manage tenant memberships.')
|
|
->destructive()
|
|
->apply(),
|
|
])
|
|
->bulkActions([]);
|
|
}
|
|
}
|