## Summary - stabilize the active spec 293 post-cutover suite baseline around the current admin-panel and workspace-first runtime - align operations, provider, required-permissions, and action-surface expectations to canonical workspace-aware routes - add the monitoring operations workspace-membership guard and update the spec 293 classification artifacts - include the browser smoke screenshots captured during verification ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/PanelNavigationSegregationTest.php tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/OpsUx/CanonicalViewRunLinksTest.php tests/Feature/OpsUx/OperateHubShellTest.php tests/Feature/OpsUx/FailureSanitizationTest.php tests/Feature/OpsUx/NonLeakageWorkspaceOperationsTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/ActionSurfaceContractTest.php tests/Feature/ProviderConnections/NavigationPlacementTest.php tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php tests/Feature/Verification/VerificationAuthorizationTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php tests/Feature/Guards/Spec288ProviderCoreAndRoleAuthorityGuardTest.php tests/Feature/Guards/AdminWorkspaceRoutesGuardTest.php tests/Feature/Guards/ProviderBoundaryPlatformCoreGuardTest.php tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/Spec080WorkspaceManagedTenantAdminMigrationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Guards/BrowserLaneIsolationTest.php tests/Feature/Guards/CiLaneFailureClassificationContractTest.php tests/Feature/Guards/CiHeavyBrowserWorkflowContractTest.php tests/Unit/Auth/NoRoleStringChecksTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - remaining provider/verification failures are classified in `specs/293-post-cutover-suite-stabilization/failure-classification.md` as unrelated existing debt and are not folded into this slice Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #348
110 lines
3.9 KiB
PHP
110 lines
3.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Clusters\Inventory\InventoryCluster;
|
|
use App\Filament\Pages\InventoryCoverage;
|
|
use App\Filament\Resources\BackupScheduleResource;
|
|
use App\Filament\Resources\BackupSetResource;
|
|
use App\Filament\Resources\BaselineProfileResource;
|
|
use App\Filament\Resources\BaselineSnapshotResource;
|
|
use App\Filament\Resources\EntraGroupResource;
|
|
use App\Filament\Resources\FindingResource;
|
|
use App\Filament\Resources\InventoryItemResource;
|
|
use App\Filament\Resources\PolicyResource;
|
|
use App\Filament\Resources\PolicyVersionResource;
|
|
use App\Filament\Resources\RestoreRunResource;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
afterEach(function (): void {
|
|
Filament::setCurrentPanel(null);
|
|
});
|
|
|
|
dataset('admin hidden navigation classes', [
|
|
InventoryCluster::class,
|
|
InventoryCoverage::class,
|
|
EntraGroupResource::class,
|
|
]);
|
|
|
|
dataset('admin visible navigation classes', [
|
|
InventoryItemResource::class,
|
|
PolicyResource::class,
|
|
PolicyVersionResource::class,
|
|
BackupScheduleResource::class,
|
|
BackupSetResource::class,
|
|
RestoreRunResource::class,
|
|
FindingResource::class,
|
|
]);
|
|
|
|
it('keeps admin-hidden tenant surfaces out of navigation registration', function (string $class): void {
|
|
Filament::setCurrentPanel('admin');
|
|
|
|
expect($class::shouldRegisterNavigation())->toBeFalse();
|
|
})->with('admin hidden navigation classes');
|
|
|
|
it('registers current tenant-owned surfaces on the admin navigation', function (string $class): void {
|
|
Filament::setCurrentPanel('admin');
|
|
|
|
expect($class::shouldRegisterNavigation())->toBeTrue();
|
|
})->with('admin visible navigation classes');
|
|
|
|
it('keeps retired tenant-panel entry routes unavailable', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
])
|
|
->get("/admin/t/{$tenant->external_id}")
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('keeps baseline navigation on the admin panel and off retired tenant routes', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
Filament::setCurrentPanel('admin');
|
|
|
|
expect(BaselineProfileResource::shouldRegisterNavigation())->toBeTrue();
|
|
expect(BaselineSnapshotResource::shouldRegisterNavigation())->toBeTrue();
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
])
|
|
->get("/admin/t/{$tenant->external_id}/baseline-profiles")
|
|
->assertNotFound();
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
])
|
|
->get("/admin/t/{$tenant->external_id}/baseline-snapshots")
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('keeps the workspace panel sidebar free of tenant-sensitive entries even with a remembered tenant', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$response = $this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
|
|
(string) $tenant->workspace_id => (int) $tenant->getKey(),
|
|
],
|
|
])
|
|
->get(route('admin.workspace.home', ['workspace' => $tenant->workspace_id]))
|
|
->assertOk();
|
|
|
|
$response->assertDontSee('>Items</span>', false);
|
|
$response->assertDontSee('>Policies</span>', false);
|
|
$response->assertDontSee('>Policy Versions</span>', false);
|
|
$response->assertDontSee('>Backup Schedules</span>', false);
|
|
$response->assertDontSee('>Backup Sets</span>', false);
|
|
$response->assertDontSee('>Restore Runs</span>', false);
|
|
$response->assertDontSee('>Findings</span>', false);
|
|
});
|