ahmido
d3158f5103
## Summary - align verification-start tests with the canonical credential-enabled provider fixture - seed required tenant-permission evidence for provider operation start tests so inventory/compliance assertions exercise the real queued and `scopeBusy` contracts - refresh stale provider-connection and verification-report test baselines to current shared output - add the complete Spec 294 artifacts for the bounded provider/verification stabilization follow-up ## Scope - bounded to `apps/platform/tests`, shared Pest test helpers, and `specs/294-provider-verification-runtime-semantics` - no runtime application code changes under `apps/platform/app` - no schema, route-cutover, framework, or asset changes ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Verification/VerificationAuthorizationTest.php tests/Feature/Verification/VerificationStartAfterCompletionTest.php tests/Feature/Verification/VerificationStartDedupeTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderDispatchGateStartSurfaceTest.php tests/Feature/ProviderConnections/ProviderOperationConcurrencyTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionNeutralitySpec238Test.php tests/Feature/Verification/ProviderConnectionHealthCheckWritesReportTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections tests/Feature/Verification` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - browser smoke was not run because the final diff contains no runtime app or UI changes; only tests, shared test helpers, and spec artifacts changed - provider registration remains unchanged in `apps/platform/bootstrap/providers.php` - no new globally searchable resource or destructive action behavior was introduced Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #349
95 lines
2.9 KiB
PHP
95 lines
2.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\ProviderConnectionHealthCheckJob;
|
|
use App\Models\OperationRun;
|
|
use App\Models\ProviderConnection;
|
|
use App\Services\Verification\StartVerification;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
it('dedupes verification starts while a run is active', function (): void {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'operator', fixtureProfile: 'credential-enabled');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$connection = ProviderConnection::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('provider', 'microsoft')
|
|
->where('is_default', true)
|
|
->firstOrFail();
|
|
|
|
$starter = app(StartVerification::class);
|
|
|
|
$first = $starter->providerConnectionCheck(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
initiator: $user,
|
|
extraContext: ['wizard' => ['flow' => 'managed_tenant_onboarding']],
|
|
);
|
|
|
|
$second = $starter->providerConnectionCheck(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
initiator: $user,
|
|
extraContext: ['wizard' => ['flow' => 'managed_tenant_onboarding']],
|
|
);
|
|
|
|
expect($first->run->getKey())->toBe($second->run->getKey());
|
|
expect($first->status)->toBe('started');
|
|
expect($second->status)->toBe('deduped');
|
|
|
|
expect(OperationRun::query()
|
|
->where('managed_environment_id', $tenant->getKey())
|
|
->where('type', 'provider.connection.check')
|
|
->count())->toBe(1);
|
|
|
|
Queue::assertPushed(ProviderConnectionHealthCheckJob::class, 1);
|
|
});
|
|
|
|
it('dedupes tenant-default verification starts while a run is active', function (): void {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'operator', fixtureProfile: 'credential-enabled');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$connection = ProviderConnection::query()
|
|
->where('managed_environment_id', (int) $tenant->getKey())
|
|
->where('provider', 'microsoft')
|
|
->where('is_default', true)
|
|
->firstOrFail();
|
|
|
|
$starter = app(StartVerification::class);
|
|
|
|
$first = $starter->providerConnectionCheckForTenant(
|
|
tenant: $tenant,
|
|
initiator: $user,
|
|
extraContext: ['surface' => ['kind' => 'tenant_view_header']],
|
|
);
|
|
|
|
$second = $starter->providerConnectionCheckForTenant(
|
|
tenant: $tenant,
|
|
initiator: $user,
|
|
extraContext: ['surface' => ['kind' => 'tenant_view_header']],
|
|
);
|
|
|
|
expect($first->run->getKey())->toBe($second->run->getKey());
|
|
expect($first->status)->toBe('started');
|
|
expect($second->status)->toBe('deduped');
|
|
|
|
expect(OperationRun::query()
|
|
->where('managed_environment_id', $tenant->getKey())
|
|
->where('type', 'provider.connection.check')
|
|
->count())->toBe(1);
|
|
|
|
Queue::assertPushed(ProviderConnectionHealthCheckJob::class, 1);
|
|
});
|