ahmido
4d3fcd28a9
What Implements tenant-scoped backup scheduling end-to-end: schedules CRUD, minute-based dispatch, queued execution, run history, manual “Run now/Retry”, retention (keep last N), and auditability. Key changes Filament UI: Backup Schedules resource with tenant scoping + SEC-002 role gating. Scheduler + queue: tenantpilot:schedules:dispatch command wired in scheduler (runs every minute), creates idempotent BackupScheduleRun records and dispatches jobs. Execution: RunBackupScheduleJob syncs policies, creates immutable backup sets, updates run status, writes audit logs, applies retry/backoff mapping, and triggers retention. Run history: Relation manager + “View” modal rendering run details. UX polish: row actions grouped; bulk actions grouped (run now / retry / delete). Bulk dispatch writes DB notifications (shows in notifications panel). Validation: policy type hard-validation on save; unknown policy types handled safely at runtime (skipped/partial). Tests: comprehensive Pest coverage for CRUD/scoping/validation, idempotency, job outcomes, error mapping, retention, view modal, run-now/retry notifications, bulk delete (incl. operator forbidden). Files / Areas Filament: BackupScheduleResource.php and app/Filament/Resources/BackupScheduleResource/* Scheduling/Jobs: app/Console/Commands/TenantpilotDispatchBackupSchedules.php, app/Jobs/RunBackupScheduleJob.php, app/Jobs/ApplyBackupScheduleRetentionJob.php, console.php Models/Migrations: app/Models/BackupSchedule.php, app/Models/BackupScheduleRun.php, database/migrations/backup_schedules, backup_schedule_runs Notifications: BackupScheduleRunDispatchedNotification.php Specs: specs/032-backup-scheduling-mvp/* (tasks/checklist/quickstart updates) How to test (Sail) Run tests: ./vendor/bin/sail artisan test tests/Feature/BackupScheduling Run formatter: ./vendor/bin/sail php ./vendor/bin/pint --dirty Apply migrations: ./vendor/bin/sail artisan migrate Manual dispatch: ./vendor/bin/sail artisan tenantpilot:schedules:dispatch Notes Uses DB notifications for queued UI actions to ensure they appear in the notifications panel even under queue fakes in tests. Checklist gate for 032 is PASS; tasks updated accordingly. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #34
87 lines
2.6 KiB
PHP
87 lines
2.6 KiB
PHP
<?php
|
|
|
|
namespace App\Services\BackupScheduling;
|
|
|
|
use App\Services\Graph\GraphException;
|
|
use Throwable;
|
|
|
|
class RunErrorMapper
|
|
{
|
|
public const ERROR_TOKEN_EXPIRED = 'TOKEN_EXPIRED';
|
|
|
|
public const ERROR_PERMISSION_MISSING = 'PERMISSION_MISSING';
|
|
|
|
public const ERROR_GRAPH_THROTTLE = 'GRAPH_THROTTLE';
|
|
|
|
public const ERROR_GRAPH_UNAVAILABLE = 'GRAPH_UNAVAILABLE';
|
|
|
|
public const ERROR_UNKNOWN = 'UNKNOWN';
|
|
|
|
/**
|
|
* @return array{shouldRetry: bool, delay: int, error_code: string, error_message: string, final_status: string}
|
|
*/
|
|
public function map(Throwable $throwable, int $attempt, int $maxAttempts = 3): array
|
|
{
|
|
$attempt = max(1, $attempt);
|
|
|
|
if ($throwable instanceof GraphException) {
|
|
$status = $throwable->status;
|
|
|
|
if ($status === 401) {
|
|
return $this->final(self::ERROR_TOKEN_EXPIRED, $throwable->getMessage());
|
|
}
|
|
|
|
if ($status === 403) {
|
|
return $this->final(self::ERROR_PERMISSION_MISSING, $throwable->getMessage());
|
|
}
|
|
|
|
if ($status === 429) {
|
|
return $this->retry(self::ERROR_GRAPH_THROTTLE, $throwable->getMessage(), $attempt, $maxAttempts);
|
|
}
|
|
|
|
if ($status === 503) {
|
|
return $this->retry(self::ERROR_GRAPH_UNAVAILABLE, $throwable->getMessage(), $attempt, $maxAttempts);
|
|
}
|
|
|
|
return $this->retry(self::ERROR_UNKNOWN, $throwable->getMessage(), $attempt, $maxAttempts);
|
|
}
|
|
|
|
return $this->retry(self::ERROR_UNKNOWN, $throwable->getMessage(), $attempt, $maxAttempts);
|
|
}
|
|
|
|
/**
|
|
* @return array{shouldRetry: bool, delay: int, error_code: string, error_message: string, final_status: string}
|
|
*/
|
|
private function retry(string $code, string $message, int $attempt, int $maxAttempts): array
|
|
{
|
|
if ($attempt >= $maxAttempts) {
|
|
return $this->final($code, $message);
|
|
}
|
|
|
|
$delays = [60, 300, 900];
|
|
$delay = $delays[min($attempt - 1, count($delays) - 1)];
|
|
|
|
return [
|
|
'shouldRetry' => true,
|
|
'delay' => $delay,
|
|
'error_code' => $code,
|
|
'error_message' => $message,
|
|
'final_status' => 'failed',
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return array{shouldRetry: bool, delay: int, error_code: string, error_message: string, final_status: string}
|
|
*/
|
|
private function final(string $code, string $message): array
|
|
{
|
|
return [
|
|
'shouldRetry' => false,
|
|
'delay' => 0,
|
|
'error_code' => $code,
|
|
'error_message' => $message,
|
|
'final_status' => 'failed',
|
|
];
|
|
}
|
|
}
|