ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
91 lines
2.7 KiB
PHP
91 lines
2.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Support\Verification;
|
|
|
|
use App\Models\OperationRun;
|
|
|
|
final class StaleQueuedVerificationReportFactory
|
|
{
|
|
/**
|
|
* @return array<int, array<string, mixed>>
|
|
*/
|
|
public static function checks(OperationRun $run): array
|
|
{
|
|
$context = is_array($run->context ?? null) ? $run->context : [];
|
|
|
|
return [[
|
|
'key' => 'provider.connection.check',
|
|
'title' => 'Provider connection check',
|
|
'status' => 'fail',
|
|
'severity' => 'critical',
|
|
'blocking' => true,
|
|
'reason_code' => 'unknown_error',
|
|
'message' => 'Run was queued but never started. A queue worker may not be running.',
|
|
'evidence' => self::evidence($run, $context),
|
|
'next_steps' => [],
|
|
]];
|
|
}
|
|
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
public static function identity(OperationRun $run): array
|
|
{
|
|
$context = is_array($run->context ?? null) ? $run->context : [];
|
|
|
|
$identity = [];
|
|
|
|
$providerConnectionId = $context['provider_connection_id'] ?? null;
|
|
if (is_numeric($providerConnectionId)) {
|
|
$identity['provider_connection_id'] = (int) $providerConnectionId;
|
|
}
|
|
|
|
$targetScope = $context['target_scope'] ?? [];
|
|
$targetScope = is_array($targetScope) ? $targetScope : [];
|
|
|
|
$entraTenantId = $targetScope['entra_tenant_id'] ?? null;
|
|
if (is_string($entraTenantId) && trim($entraTenantId) !== '') {
|
|
$identity['entra_tenant_id'] = trim($entraTenantId);
|
|
}
|
|
|
|
return $identity;
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $context
|
|
* @return array<int, array{kind: string, value: int|string}>
|
|
*/
|
|
private static function evidence(OperationRun $run, array $context): array
|
|
{
|
|
$evidence = [];
|
|
|
|
$providerConnectionId = $context['provider_connection_id'] ?? null;
|
|
if (is_numeric($providerConnectionId)) {
|
|
$evidence[] = [
|
|
'kind' => 'provider_connection_id',
|
|
'value' => (int) $providerConnectionId,
|
|
];
|
|
}
|
|
|
|
$targetScope = $context['target_scope'] ?? [];
|
|
$targetScope = is_array($targetScope) ? $targetScope : [];
|
|
|
|
$entraTenantId = $targetScope['entra_tenant_id'] ?? null;
|
|
if (is_string($entraTenantId) && trim($entraTenantId) !== '') {
|
|
$evidence[] = [
|
|
'kind' => 'entra_tenant_id',
|
|
'value' => trim($entraTenantId),
|
|
];
|
|
}
|
|
|
|
$evidence[] = [
|
|
'kind' => 'operation_run_id',
|
|
'value' => (int) $run->getKey(),
|
|
];
|
|
|
|
return $evidence;
|
|
}
|
|
}
|