Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
94 lines
2.9 KiB
PHP
94 lines
2.9 KiB
PHP
<?php
|
|
|
|
use App\Jobs\ApplyBackupScheduleRetentionJob;
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\BackupSet;
|
|
use App\Models\OperationRun;
|
|
use Filament\Facades\Filament;
|
|
|
|
test('retention keeps last N backup sets per schedule', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$schedule = BackupSchedule::query()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Nightly',
|
|
'is_enabled' => true,
|
|
'timezone' => 'UTC',
|
|
'frequency' => 'daily',
|
|
'time_of_day' => '01:00:00',
|
|
'days_of_week' => null,
|
|
'policy_types' => ['deviceConfiguration'],
|
|
'include_foundations' => true,
|
|
'retention_keep_last' => 2,
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$sets = collect(range(1, 5))->map(function (int $i) use ($tenant): BackupSet {
|
|
return BackupSet::query()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Set '.$i,
|
|
'status' => 'completed',
|
|
'item_count' => 0,
|
|
'completed_at' => now()->subMinutes(10 - $i),
|
|
]);
|
|
});
|
|
|
|
$completedAt = now('UTC')->startOfMinute()->subMinutes(10);
|
|
|
|
foreach ($sets as $set) {
|
|
OperationRun::query()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->id,
|
|
'user_id' => null,
|
|
'initiator_name' => 'System',
|
|
'type' => 'backup_schedule_run',
|
|
'status' => 'completed',
|
|
'outcome' => 'succeeded',
|
|
'run_identity_hash' => hash('sha256', 'retention-test:'.$schedule->id.':'.$set->id),
|
|
'summary_counts' => [
|
|
'total' => 0,
|
|
'processed' => 0,
|
|
'succeeded' => 0,
|
|
],
|
|
'failure_summary' => [],
|
|
'context' => [
|
|
'backup_schedule_id' => (int) $schedule->id,
|
|
'backup_set_id' => (int) $set->id,
|
|
],
|
|
'started_at' => $completedAt,
|
|
'completed_at' => $completedAt,
|
|
]);
|
|
|
|
$completedAt = $completedAt->addMinute();
|
|
}
|
|
|
|
ApplyBackupScheduleRetentionJob::dispatchSync($schedule->id);
|
|
|
|
$kept = $sets->take(-2);
|
|
$deleted = $sets->take(3);
|
|
|
|
foreach ($kept as $set) {
|
|
$this->assertDatabaseHas('backup_sets', [
|
|
'id' => $set->id,
|
|
'deleted_at' => null,
|
|
]);
|
|
}
|
|
|
|
foreach ($deleted as $set) {
|
|
$this->assertSoftDeleted('backup_sets', ['id' => $set->id]);
|
|
}
|
|
|
|
$retentionRun = OperationRun::query()
|
|
->where('tenant_id', (int) $tenant->id)
|
|
->where('type', 'backup_schedule_retention')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($retentionRun)->not->toBeNull();
|
|
expect($retentionRun?->status)->toBe('completed');
|
|
expect($retentionRun?->outcome)->toBe('succeeded');
|
|
expect($retentionRun?->summary_counts['succeeded'] ?? null)->toBe(3);
|
|
});
|