ahmido
292d555eac
## Summary - consolidate internal platform naming from `Tenant` to `Environment` / `ManagedEnvironment` across models, controllers, services, and Filament resources - rename environment-scoped UI surfaces such as dashboards, chooser flows, navigation, and related widgets to match the updated environment-first domain language - align middleware, onboarding/review lifecycle services, jobs, and route/context controllers with the new environment-scoped architecture ## Validation - not rerun as part of this commit/push/PR request ## Notes - branch is 1 commit ahead of `platform-dev` - main commit: `refactor: consolidate internal tenant model naming` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #355
99 lines
3.9 KiB
PHP
99 lines
3.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\ProductUsageEvent;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Services\Onboarding\OnboardingDraftMutationService;
|
|
use App\Support\Onboarding\OnboardingCheckpoint;
|
|
use App\Support\Onboarding\OnboardingLifecycleState;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\ProductTelemetry\ProductUsageEventCatalog;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('records onboarding checkpoint telemetry after a tenant-linked checkpoint transition persists', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$connection = ProviderConnection::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
]);
|
|
|
|
$verificationRun = OperationRun::factory()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'user_id' => (int) $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
'context' => [
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
],
|
|
]);
|
|
|
|
$draft = createOnboardingDraft([
|
|
'workspace' => $tenant->workspace,
|
|
'tenant' => $tenant,
|
|
'started_by' => $user,
|
|
'updated_by' => $user,
|
|
'current_step' => 'verify',
|
|
'state' => [
|
|
'entra_tenant_id' => (string) $tenant->managed_environment_id,
|
|
'environment_name' => (string) $tenant->name,
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
'verification_operation_run_id' => (int) $verificationRun->getKey(),
|
|
],
|
|
]);
|
|
|
|
app(OnboardingDraftMutationService::class)->mutate(
|
|
draft: $draft,
|
|
actor: $user,
|
|
mutator: static function (): void {},
|
|
);
|
|
|
|
$event = ProductUsageEvent::query()->sole();
|
|
$serializedEvent = json_encode($event->toArray(), JSON_THROW_ON_ERROR);
|
|
|
|
expect($event->event_name)->toBe(ProductUsageEventCatalog::ONBOARDING_CHECKPOINT_COMPLETED)
|
|
->and($event->workspace_id)->toBe((int) $tenant->workspace_id)
|
|
->and($event->managed_environment_id)->toBe((int) $tenant->getKey())
|
|
->and($event->user_id)->toBe((int) $user->getKey())
|
|
->and($event->subject_type)->toBe('managed_environment_onboarding_session')
|
|
->and($event->subject_id)->toBe((string) $draft->getKey())
|
|
->and($event->metadata['checkpoint_key'] ?? null)->toBe(OnboardingCheckpoint::VerifyAccess->value)
|
|
->and($event->metadata['lifecycle_state'] ?? null)->toBe(OnboardingLifecycleState::ReadyForActivation->value)
|
|
->and($event->metadata['completed_at'] ?? null)->not->toBeNull()
|
|
->and($serializedEvent)->not->toContain('@')
|
|
->and($serializedEvent)->not->toContain((string) $tenant->name)
|
|
->and($serializedEvent)->not->toContain((string) ($draft->state['environment_name'] ?? ''));
|
|
});
|
|
|
|
it('does not record onboarding telemetry for pre-tenant drafts', function (): void {
|
|
$workspace = \App\Models\Workspace::factory()->create();
|
|
$user = \App\Models\User::factory()->create();
|
|
|
|
$draft = createOnboardingDraft([
|
|
'workspace' => $workspace,
|
|
'started_by' => $user,
|
|
'updated_by' => $user,
|
|
'current_step' => 'identify',
|
|
'state' => [
|
|
'entra_tenant_id' => fake()->uuid(),
|
|
'environment_name' => 'Pre ManagedEnvironment Draft',
|
|
],
|
|
]);
|
|
|
|
app(OnboardingDraftMutationService::class)->mutate(
|
|
draft: $draft,
|
|
actor: $user,
|
|
mutator: static function (): void {},
|
|
);
|
|
|
|
expect(ProductUsageEvent::query()->count())->toBe(0);
|
|
}); |