TenantAtlas/apps/platform/tests/Feature/PermissionPosture/GeneratePermissionPostureFindingsJobTest.php
ahmido 3c38192405 Spec 206: implement test suite governance foundation (#239)
## Summary

This PR implements Spec 206 end to end and establishes the first checked-in test suite governance foundation for the platform app.

Key changes:
- add manifest-backed test lanes for fast-feedback, confidence, browser, heavy-governance, profiling, and junit
- add budget and report helpers plus app-local artifact generation under `apps/platform/storage/logs/test-lanes`
- add repo-root Sail-friendly lane/report wrappers
- switch the default contributor test path to the fast-feedback lane
- introduce explicit fixture profiles and cheaper defaults for shared tenant/provider test setup
- add minimal/heavy factory states for tenant and provider connection setup
- migrate the first high-usage and provider-sensitive tests to explicit fixture profiles
- document budgets, taxonomy rules, DB reset guidance, and the full Spec 206 plan/contracts/tasks set

## Validation

Executed during implementation:
- focused Spec 206 guard/support/factory validation pack: 31 passed
- provider-sensitive regression pack: 29 passed
- first high-usage caller migration pack: 120 passed
- lane routing and wrapper validation succeeded
- pint completed successfully

Measured lane baselines captured in docs:
- fast-feedback: 176.74s
- confidence: 394.38s
- heavy-governance: 83.66s
- browser: 128.87s
- junit: 380.14s
- profiling: 2701.51s
- full-suite baseline anchor: 2624.60s

## Notes

- Livewire v4 / Filament v5 runtime behavior is unchanged by this PR.
- No new runtime routes, product UI flows, or database migrations are introduced.
- Panel provider registration remains unchanged in `bootstrap/providers.php`.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #239
2026-04-16 13:58:50 +00:00

149 lines
5.4 KiB
PHP

<?php
declare(strict_types=1);
use App\Jobs\GeneratePermissionPostureFindingsJob;
use App\Jobs\ProviderConnectionHealthCheckJob;
use App\Models\Finding;
use App\Models\OperationRun;
use App\Models\StoredReport;
use App\Models\Tenant;
use App\Services\PermissionPosture\FindingGeneratorContract;
use App\Support\OperationCatalog;
use App\Support\OperationRunOutcome;
use App\Support\OperationRunStatus;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\Queue;
use Mockery\MockInterface;
uses(RefreshDatabase::class);
function buildJobComparison(array $permissions = [], string $overallStatus = 'missing'): array
{
return [
'overall_status' => $overallStatus,
'permissions' => $permissions,
'last_refreshed_at' => now()->toIso8601String(),
];
}
// (1) Successful run creates OperationRun with correct type and outcome
it('creates OperationRun with correct type and outcome on success', function (): void {
[$user, $tenant] = createUserWithTenant(fixtureProfile: 'provider-enabled');
$comparison = buildJobComparison([
['key' => 'Perm.A', 'type' => 'application', 'status' => 'missing', 'features' => ['a']],
]);
$job = new GeneratePermissionPostureFindingsJob($tenant->getKey(), $comparison);
$job->handle(
app(FindingGeneratorContract::class),
app(\App\Services\OperationRunService::class),
);
$run = OperationRun::query()
->where('tenant_id', $tenant->getKey())
->where('type', OperationCatalog::TYPE_PERMISSION_POSTURE_CHECK)
->first();
expect($run)->not->toBeNull()
->and($run->status)->toBe(OperationRunStatus::Completed->value)
->and($run->outcome)->toBe(OperationRunOutcome::Succeeded->value);
});
// (2) Skips tenant without provider connection
it('skips tenant without provider connection', function (): void {
$tenant = Tenant::factory()->create();
// Ensure workspace is set
$workspace = \App\Models\Workspace::factory()->create();
$tenant->forceFill(['workspace_id' => $workspace->getKey()])->save();
// Explicitly delete any provider connections
$tenant->providerConnections()->delete();
$comparison = buildJobComparison([
['key' => 'Perm.A', 'type' => 'application', 'status' => 'missing', 'features' => ['a']],
]);
$job = new GeneratePermissionPostureFindingsJob($tenant->getKey(), $comparison);
$job->handle(
app(FindingGeneratorContract::class),
app(\App\Services\OperationRunService::class),
);
expect(Finding::query()->where('tenant_id', $tenant->getKey())->count())->toBe(0)
->and(StoredReport::query()->where('tenant_id', $tenant->getKey())->count())->toBe(0)
->and(OperationRun::query()->where('tenant_id', $tenant->getKey())->where('type', OperationCatalog::TYPE_PERMISSION_POSTURE_CHECK)->count())->toBe(0);
});
// (3) Records summary counts on OperationRun
it('records summary counts on OperationRun', function (): void {
[$user, $tenant] = createUserWithTenant(fixtureProfile: 'provider-enabled');
$comparison = buildJobComparison([
['key' => 'Perm.A', 'type' => 'application', 'status' => 'missing', 'features' => ['a']],
['key' => 'Perm.B', 'type' => 'application', 'status' => 'granted', 'features' => ['b']],
]);
$job = new GeneratePermissionPostureFindingsJob($tenant->getKey(), $comparison);
$job->handle(
app(FindingGeneratorContract::class),
app(\App\Services\OperationRunService::class),
);
$run = OperationRun::query()
->where('tenant_id', $tenant->getKey())
->where('type', OperationCatalog::TYPE_PERMISSION_POSTURE_CHECK)
->first();
$counts = is_array($run->summary_counts) ? $run->summary_counts : [];
expect($counts)->toHaveKey('findings_created')
->and($counts['findings_created'])->toBe(1)
->and($counts)->toHaveKey('posture_score')
->and($counts['posture_score'])->toBe(50);
});
// (4) Handles generator exceptions gracefully
it('marks OperationRun as failed on exception', function (): void {
[$user, $tenant] = createUserWithTenant(fixtureProfile: 'provider-enabled');
$this->mock(FindingGeneratorContract::class, function (MockInterface $mock): void {
$mock->shouldReceive('generate')->andThrow(new RuntimeException('Test error'));
});
$comparison = buildJobComparison([
['key' => 'Perm.A', 'type' => 'application', 'status' => 'missing', 'features' => ['a']],
]);
$job = new GeneratePermissionPostureFindingsJob($tenant->getKey(), $comparison);
try {
$job->handle(
app(FindingGeneratorContract::class),
app(\App\Services\OperationRunService::class),
);
} catch (RuntimeException) {
// Expected
}
$run = OperationRun::query()
->where('tenant_id', $tenant->getKey())
->where('type', OperationCatalog::TYPE_PERMISSION_POSTURE_CHECK)
->first();
expect($run->outcome)->toBe(OperationRunOutcome::Failed->value);
});
// (5) Dispatched from ProviderConnectionHealthCheckJob after successful compare
it('dispatches posture job from health check job', function (): void {
Queue::fake([GeneratePermissionPostureFindingsJob::class]);
[$user, $tenant] = createUserWithTenant(fixtureProfile: 'provider-enabled');
// The actual dispatch is tested by verifying the hook exists in the source
// (integration test will cover the full flow in T033)
Queue::assertNothingPushed();
});