PR Body Implements Spec 065 “Tenant RBAC v1” with capabilities-first RBAC, tenant membership scoping (Option 3), and consistent Filament action semantics. Key decisions / rules Tenancy Option 3: tenant switching is tenantless (ChooseTenant), tenant-scoped routes stay scoped, non-members get 404 (not 403). RBAC model: canonical capability registry + role→capability map + Gates for each capability (no role-string checks in UI logic). UX policy: for tenant members lacking permission → actions are visible but disabled + tooltip (avoid click→403). Security still enforced server-side. What’s included Capabilities foundation: Central capability registry (Capabilities::*) Role→capability mapping (RoleCapabilityMap) Gate registration + resolver/manager updates to support tenant-scoped authorization Filament enforcement hardening across the app: Tenant registration & tenant CRUD properly gated Backup/restore/policy flows aligned to “visible-but-disabled” where applicable Provider operations (health check / inventory sync / compliance snapshot) guarded and normalized Directory groups + inventory sync start surfaces normalized Policy version maintenance actions (archive/restore/prune/force delete) gated SpecKit artifacts for 065: spec.md, plan/tasks updates, checklists, enforcement hitlist Security guarantees Non-member → 404 via tenant scoping/membership guards. Member without capability → 403 on execution, even if UI is disabled. No destructive actions execute without proper authorization checks. Tests Adds/updates Pest coverage for: Tenant scoping & membership denial behavior Role matrix expectations (owner/manager/operator/readonly) Filament surface checks (visible/disabled actions, no side effects) Provider/Inventory/Groups run-start authorization Verified locally with targeted vendor/bin/sail artisan test --compact … Deployment / ops notes No new services required. Safe change: behavior is authorization + UI semantics; no breaking route changes intended. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #79
226 lines
8.9 KiB
PHP
226 lines
8.9 KiB
PHP
<?php
|
|
|
|
namespace App\Filament\Resources\TenantResource\RelationManagers;
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\TenantMembership;
|
|
use App\Models\User;
|
|
use App\Services\Auth\TenantMembershipManager;
|
|
use App\Support\Auth\Capabilities;
|
|
use Filament\Actions;
|
|
use Filament\Forms;
|
|
use Filament\Notifications\Notification;
|
|
use Filament\Resources\RelationManagers\RelationManager;
|
|
use Filament\Tables;
|
|
use Filament\Tables\Table;
|
|
use Illuminate\Database\Eloquent\Builder;
|
|
use Illuminate\Support\Facades\Gate;
|
|
|
|
class TenantMembershipsRelationManager extends RelationManager
|
|
{
|
|
protected static string $relationship = 'memberships';
|
|
|
|
public function table(Table $table): Table
|
|
{
|
|
return $table
|
|
->modifyQueryUsing(fn (Builder $query) => $query->with('user'))
|
|
->columns([
|
|
Tables\Columns\TextColumn::make('user.name')
|
|
->label(__('User'))
|
|
->searchable(),
|
|
Tables\Columns\TextColumn::make('user.email')
|
|
->label(__('Email'))
|
|
->toggleable(isToggledHiddenByDefault: true),
|
|
Tables\Columns\TextColumn::make('role')
|
|
->badge()
|
|
->sortable(),
|
|
Tables\Columns\TextColumn::make('source')
|
|
->badge()
|
|
->toggleable(isToggledHiddenByDefault: true),
|
|
Tables\Columns\TextColumn::make('created_at')->since(),
|
|
])
|
|
->headerActions([
|
|
Actions\Action::make('add_member')
|
|
->label(__('Add member'))
|
|
->icon('heroicon-o-plus')
|
|
->visible(function (): bool {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return false;
|
|
}
|
|
|
|
return Gate::allows(Capabilities::TENANT_MEMBERSHIP_MANAGE, $tenant);
|
|
})
|
|
->form([
|
|
Forms\Components\Select::make('user_id')
|
|
->label(__('User'))
|
|
->required()
|
|
->searchable()
|
|
->options(fn () => User::query()->orderBy('name')->pluck('name', 'id')->all()),
|
|
Forms\Components\Select::make('role')
|
|
->label(__('Role'))
|
|
->required()
|
|
->options([
|
|
'owner' => __('Owner'),
|
|
'manager' => __('Manager'),
|
|
'operator' => __('Operator'),
|
|
'readonly' => __('Readonly'),
|
|
]),
|
|
])
|
|
->action(function (array $data, TenantMembershipManager $manager): void {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
abort(404);
|
|
}
|
|
|
|
$actor = auth()->user();
|
|
if (! $actor instanceof User) {
|
|
abort(403);
|
|
}
|
|
|
|
if (! Gate::allows(Capabilities::TENANT_MEMBERSHIP_MANAGE, $tenant)) {
|
|
abort(403);
|
|
}
|
|
|
|
$member = User::query()->find((int) $data['user_id']);
|
|
if (! $member) {
|
|
Notification::make()->title(__('User not found'))->danger()->send();
|
|
|
|
return;
|
|
}
|
|
|
|
try {
|
|
$manager->addMember(
|
|
tenant: $tenant,
|
|
actor: $actor,
|
|
member: $member,
|
|
role: (string) $data['role'],
|
|
source: 'manual',
|
|
);
|
|
} catch (\Throwable $throwable) {
|
|
Notification::make()
|
|
->title(__('Failed to add member'))
|
|
->body($throwable->getMessage())
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
Notification::make()->title(__('Member added'))->success()->send();
|
|
$this->resetTable();
|
|
}),
|
|
])
|
|
->actions([
|
|
Actions\Action::make('change_role')
|
|
->label(__('Change role'))
|
|
->icon('heroicon-o-pencil')
|
|
->requiresConfirmation()
|
|
->visible(function (): bool {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return false;
|
|
}
|
|
|
|
return Gate::allows(Capabilities::TENANT_MEMBERSHIP_MANAGE, $tenant);
|
|
})
|
|
->form([
|
|
Forms\Components\Select::make('role')
|
|
->label(__('Role'))
|
|
->required()
|
|
->options([
|
|
'owner' => __('Owner'),
|
|
'manager' => __('Manager'),
|
|
'operator' => __('Operator'),
|
|
'readonly' => __('Readonly'),
|
|
]),
|
|
])
|
|
->action(function (TenantMembership $record, array $data, TenantMembershipManager $manager): void {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
abort(404);
|
|
}
|
|
|
|
$actor = auth()->user();
|
|
if (! $actor instanceof User) {
|
|
abort(403);
|
|
}
|
|
|
|
if (! Gate::allows(Capabilities::TENANT_MEMBERSHIP_MANAGE, $tenant)) {
|
|
abort(403);
|
|
}
|
|
|
|
try {
|
|
$manager->changeRole(
|
|
tenant: $tenant,
|
|
actor: $actor,
|
|
membership: $record,
|
|
newRole: (string) $data['role'],
|
|
);
|
|
} catch (\Throwable $throwable) {
|
|
Notification::make()
|
|
->title(__('Failed to change role'))
|
|
->body($throwable->getMessage())
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
Notification::make()->title(__('Role updated'))->success()->send();
|
|
$this->resetTable();
|
|
}),
|
|
Actions\Action::make('remove')
|
|
->label(__('Remove'))
|
|
->color('danger')
|
|
->icon('heroicon-o-x-mark')
|
|
->requiresConfirmation()
|
|
->visible(function (): bool {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return false;
|
|
}
|
|
|
|
return Gate::allows(Capabilities::TENANT_MEMBERSHIP_MANAGE, $tenant);
|
|
})
|
|
->action(function (TenantMembership $record, TenantMembershipManager $manager): void {
|
|
$tenant = $this->getOwnerRecord();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
abort(404);
|
|
}
|
|
|
|
$actor = auth()->user();
|
|
if (! $actor instanceof User) {
|
|
abort(403);
|
|
}
|
|
|
|
if (! Gate::allows(Capabilities::TENANT_MEMBERSHIP_MANAGE, $tenant)) {
|
|
abort(403);
|
|
}
|
|
|
|
try {
|
|
$manager->removeMember($tenant, $actor, $record);
|
|
} catch (\Throwable $throwable) {
|
|
Notification::make()
|
|
->title(__('Failed to remove member'))
|
|
->body($throwable->getMessage())
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
Notification::make()->title(__('Member removed'))->success()->send();
|
|
$this->resetTable();
|
|
}),
|
|
])
|
|
->bulkActions([]);
|
|
}
|
|
}
|