Some checks failed
Main Confidence / confidence (push) Failing after 1m23s
Removes the Findings lifecycle backfill from the Operational Controls UI and OperationalControlCatalog. This patch is a safe, controls-only change; runbooks, jobs and other runtime artifacts are NOT removed yet. Follow-up work will delete the runbook service/scope, jobs, commands, and update tests. Files changed: - apps/platform/app/Filament/System/Pages/Ops/Controls.php - apps/platform/app/Support/OperationalControls/OperationalControlCatalog.php - apps/platform/tests/Feature/System/OpsControls/OperationalControlManagementTest.php - apps/platform/tests/Unit/Support/OperationalControls/OperationalControlCatalogTest.php - apps/platform/tests/Unit/Support/OperationalControls/OperationalControlScopeResolutionTest.php Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #280
133 lines
4.3 KiB
PHP
133 lines
4.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\RestoreRunResource;
|
|
use App\Filament\Resources\RestoreRunResource\Pages\CreateRestoreRun;
|
|
use App\Models\BackupItem;
|
|
use App\Models\BackupSet;
|
|
use App\Models\OperationalControlActivation;
|
|
use App\Models\Policy;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function (): void {
|
|
putenv('INTUNE_TENANT_ID');
|
|
unset($_ENV['INTUNE_TENANT_ID'], $_SERVER['INTUNE_TENANT_ID']);
|
|
});
|
|
|
|
function seedRestoreAuthorizationContext(): array
|
|
{
|
|
$tenant = Tenant::factory()->create([
|
|
'tenant_id' => fake()->uuid(),
|
|
'name' => 'Authorization Tenant',
|
|
'rbac_status' => 'ok',
|
|
'rbac_last_checked_at' => now(),
|
|
]);
|
|
|
|
$tenant->makeCurrent();
|
|
ensureDefaultProviderConnection($tenant, 'microsoft');
|
|
|
|
$policy = Policy::create([
|
|
'tenant_id' => $tenant->id,
|
|
'external_id' => fake()->uuid(),
|
|
'policy_type' => 'deviceConfiguration',
|
|
'display_name' => 'Authorization Restore Policy',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
$backupSet = BackupSet::create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Authorization Backup',
|
|
'status' => 'completed',
|
|
'item_count' => 1,
|
|
]);
|
|
|
|
$backupItem = BackupItem::create([
|
|
'tenant_id' => $tenant->id,
|
|
'backup_set_id' => $backupSet->id,
|
|
'policy_id' => $policy->id,
|
|
'policy_identifier' => $policy->external_id,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'payload' => ['id' => $policy->external_id],
|
|
'metadata' => ['displayName' => 'Authorization Restore Policy'],
|
|
]);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
return [$tenant, $backupSet, $backupItem];
|
|
}
|
|
|
|
it('keeps non-members at 404 even when restore execution is paused', function (): void {
|
|
[$tenant] = seedRestoreAuthorizationContext();
|
|
|
|
OperationalControlActivation::factory()->workspaceScoped()->create([
|
|
'control_key' => 'restore.execute',
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'reason_text' => 'Paused while access is under review.',
|
|
]);
|
|
|
|
$user = User::factory()->create();
|
|
|
|
$this->actingAs($user)
|
|
->get(RestoreRunResource::getUrl('create', panel: 'tenant', tenant: $tenant))
|
|
->assertNotFound();
|
|
});
|
|
|
|
it('keeps members without tenant-manage at 403 even when restore execution is paused', function (): void {
|
|
[$tenant] = seedRestoreAuthorizationContext();
|
|
|
|
OperationalControlActivation::factory()->workspaceScoped()->create([
|
|
'control_key' => 'restore.execute',
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'reason_text' => 'Paused while access is under review.',
|
|
]);
|
|
|
|
[$user] = createUserWithTenant(tenant: $tenant, role: 'operator');
|
|
|
|
$this->actingAs($user)
|
|
->get(RestoreRunResource::getUrl('create', panel: 'tenant', tenant: $tenant))
|
|
->assertForbidden();
|
|
});
|
|
|
|
it('shows paused-state feedback only to entitled users blocked by an operational control', function (): void {
|
|
[$tenant, $backupSet, $backupItem] = seedRestoreAuthorizationContext();
|
|
|
|
OperationalControlActivation::factory()->workspaceScoped()->create([
|
|
'control_key' => 'restore.execute',
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'reason_text' => 'Paused for tenant-safe validation.',
|
|
]);
|
|
|
|
[$user] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
|
|
Livewire::test(CreateRestoreRun::class)
|
|
->fillForm([
|
|
'backup_set_id' => $backupSet->id,
|
|
])
|
|
->goToNextWizardStep()
|
|
->fillForm([
|
|
'scope_mode' => 'selected',
|
|
'backup_item_ids' => [$backupItem->id],
|
|
])
|
|
->goToNextWizardStep()
|
|
->callFormComponentAction('check_results', 'run_restore_checks')
|
|
->goToNextWizardStep()
|
|
->callFormComponentAction('preview_diffs', 'run_restore_preview')
|
|
->goToNextWizardStep()
|
|
->fillForm([
|
|
'is_dry_run' => false,
|
|
'acknowledged_impact' => true,
|
|
'tenant_confirm' => 'Authorization Tenant',
|
|
])
|
|
->call('create')
|
|
->assertNotified('Restore execution paused');
|
|
}); |