ahmido
dc46c4fa58
## Summary
- implement Spec 179 to make tenant lifecycle, provider consent, and provider verification the primary truth axes on the targeted Filament surfaces
- demote legacy tenant app status and legacy provider status and health to diagnostic-only roles, add centralized badge mappings for provider consent and verification, and keep provider connections excluded from global search
- add the full Spec 179 artifact set under `specs/179-provider-truth-cleanup/` plus focused Pest coverage for tenant truth cleanup, provider truth cleanup, RBAC, discovery safety, and badge semantics
- fix the numeric out-of-scope tenant route regression so inaccessible `/admin/tenants/{id}` paths return `404 Not Found` instead of `500`
## Testing
- `vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantTruthCleanupSpec179Test.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php`
- `vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/RequiredFiltersTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Rbac/TenantResourceAuthorizationTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Rbac/AdminGlobalSearchContextSafetyTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php`
- `vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantScopingTest.php`
- `vendor/bin/sail artisan test --compact tests/Unit/Badges/TenantBadgesTest.php`
- `vendor/bin/sail artisan test --compact tests/Unit/Badges/ProviderConnectionBadgesTest.php`
## Manual validation
- integrated-browser smoke on `/admin/tenants`, tenant detail, `/admin/provider-connections`, provider detail, and provider edit
- verified out-of-scope tenant and provider URLs return `404 Not Found` with the current session
## Notes
- branch: `179-provider-truth-cleanup`
- commit: `e54c6632`
- target: `dev`
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #207
71 lines
2.6 KiB
PHP
71 lines
2.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\BaselineSnapshotResource;
|
|
use App\Filament\Resources\EvidenceSnapshotResource;
|
|
use App\Filament\Resources\OperationRunResource;
|
|
use App\Filament\Resources\TenantResource;
|
|
use App\Filament\Resources\TenantReviewResource;
|
|
use App\Models\Tenant;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function tenantSearchTitles($results): array
|
|
{
|
|
return collect($results)->map(fn ($result): string => (string) $result->title)->all();
|
|
}
|
|
|
|
it('keeps tenant global-search aligned with administrative discoverability in the current workspace', function (): void {
|
|
$active = Tenant::factory()->active()->create(['name' => 'Lifecycle Active']);
|
|
[$user, $active] = createUserWithTenant(tenant: $active, role: 'owner');
|
|
|
|
$onboarding = Tenant::factory()->onboarding()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Lifecycle Onboarding',
|
|
]);
|
|
$draft = Tenant::factory()->draft()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Lifecycle Draft',
|
|
]);
|
|
$archived = Tenant::factory()->archived()->create([
|
|
'workspace_id' => (int) $active->workspace_id,
|
|
'name' => 'Lifecycle Archived',
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $onboarding, user: $user, role: 'owner');
|
|
createUserWithTenant(tenant: $draft, user: $user, role: 'owner');
|
|
createUserWithTenant(tenant: $archived, user: $user, role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $active->workspace_id);
|
|
|
|
$results = TenantResource::getGlobalSearchResults('Lifecycle');
|
|
|
|
expect(tenantSearchTitles($results))->toEqualCanonicalizing([
|
|
'Lifecycle Active',
|
|
'Lifecycle Onboarding',
|
|
'Lifecycle Draft',
|
|
'Lifecycle Archived',
|
|
]);
|
|
|
|
expect($results->first()?->url)
|
|
->not->toBeNull();
|
|
expect(collect($results)->filter(fn ($result): bool => filled($result->url))->count())
|
|
->toBe($results->count());
|
|
});
|
|
|
|
it('keeps first-slice taxonomy resources out of global search', function (): void {
|
|
expect(OperationRunResource::canGloballySearch())->toBeFalse()
|
|
->and(EvidenceSnapshotResource::canGloballySearch())->toBeFalse()
|
|
->and(BaselineSnapshotResource::canGloballySearch())->toBeFalse()
|
|
->and(TenantReviewResource::canGloballySearch())->toBeFalse();
|
|
});
|