## Summary - harden the workspace overview into a governance-aware attention surface that separates governance risk from activity and keeps calm states honest - add tenant-bound attention, workspace-wide operations continuity, and low-permission fallback behavior for workspace-originated operations drill-through - add the full Spec 175 artifact set and focused workspace overview regression coverage, plus align remaining operation-viewer wording and guard expectations so the suite stays green ## Testing - `vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewAccessTest.php tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php tests/Feature/Filament/WorkspaceOverviewLandingTest.php tests/Feature/Filament/WorkspaceOverviewNavigationTest.php tests/Feature/Filament/WorkspaceOverviewContentTest.php tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php tests/Feature/Filament/WorkspaceOverviewOperationsTest.php tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php` - `vendor/bin/sail artisan test --compact tests/Unit/Support/RelatedActionLabelCatalogTest.php tests/Feature/078/VerificationReportTenantlessTest.php tests/Feature/144/CanonicalOperationViewerContextMismatchTest.php tests/Feature/Baselines/BaselineCompareSummaryAssessmentTest.php tests/Feature/Baselines/TenantGovernanceAggregateResolverTest.php tests/Feature/Filament/ReferencedTenantLifecyclePresentationTest.php tests/Feature/Guards/NoAdHocFilamentAuthPatternsTest.php tests/Feature/Monitoring/AuditLogInspectFlowTest.php tests/Feature/Monitoring/HeaderContextBarTest.php tests/Feature/Monitoring/OperationLifecycleFreshnessPresentationTest.php tests/Feature/Monitoring/OperationRunResolvedReferencePresentationTest.php tests/Feature/Notifications/OperationRunNotificationTest.php tests/Feature/OpsUx/QueuedToastCopyTest.php tests/Feature/OpsUx/TerminalNotificationFailureMessageTest.php tests/Feature/System/OpsRunbooks/OpsUxStartSurfaceContractTest.php tests/Feature/Verification/VerificationReportRedactionTest.php` - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact` ## Notes - branch pushed as `175-workspace-governance-attention` - full suite result: `3235 passed, 8 skipped` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #206
127 lines
5.6 KiB
PHP
127 lines
5.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\AlertDelivery;
|
|
use App\Models\Finding;
|
|
use App\Models\FindingException;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\Workspaces\WorkspaceOverviewBuilder;
|
|
|
|
it('counts governance attention by affected tenant instead of raw issue totals', function (): void {
|
|
$tenantOverdue = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenantOverdue] = createUserWithTenant($tenantOverdue, role: 'owner', workspaceRole: 'readonly');
|
|
[$overdueProfile, $overdueSnapshot] = seedActiveBaselineForTenant($tenantOverdue);
|
|
seedBaselineCompareRun($tenantOverdue, $overdueProfile, $overdueSnapshot, workspaceOverviewCompareCoverage());
|
|
|
|
Finding::factory()->count(3)->for($tenantOverdue)->create([
|
|
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
|
'status' => Finding::STATUS_TRIAGED,
|
|
'due_at' => now()->subDay(),
|
|
]);
|
|
|
|
$tenantExpiring = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
|
'name' => 'Expiring Tenant',
|
|
]);
|
|
createUserWithTenant($tenantExpiring, $user, role: 'owner', workspaceRole: 'readonly');
|
|
[$expiringProfile, $expiringSnapshot] = seedActiveBaselineForTenant($tenantExpiring);
|
|
seedBaselineCompareRun($tenantExpiring, $expiringProfile, $expiringSnapshot, workspaceOverviewCompareCoverage());
|
|
|
|
$finding = Finding::factory()->riskAccepted()->create([
|
|
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
|
'tenant_id' => (int) $tenantExpiring->getKey(),
|
|
]);
|
|
|
|
FindingException::query()->create([
|
|
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
|
'tenant_id' => (int) $tenantExpiring->getKey(),
|
|
'finding_id' => (int) $finding->getKey(),
|
|
'requested_by_user_id' => (int) $user->getKey(),
|
|
'owner_user_id' => (int) $user->getKey(),
|
|
'approved_by_user_id' => (int) $user->getKey(),
|
|
'status' => FindingException::STATUS_EXPIRING,
|
|
'current_validity_state' => FindingException::VALIDITY_EXPIRING,
|
|
'request_reason' => 'Pending governance review',
|
|
'approval_reason' => 'Short lived exception',
|
|
'requested_at' => now()->subDays(2),
|
|
'approved_at' => now()->subDay(),
|
|
'effective_from' => now()->subDay(),
|
|
'expires_at' => now()->addDay(),
|
|
'review_due_at' => now()->addDay(),
|
|
'evidence_summary' => ['reference_count' => 0],
|
|
]);
|
|
|
|
$tenantStale = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
|
'name' => 'Stale Tenant',
|
|
]);
|
|
createUserWithTenant($tenantStale, $user, role: 'owner', workspaceRole: 'readonly');
|
|
[$staleProfile, $staleSnapshot] = seedActiveBaselineForTenant($tenantStale);
|
|
seedBaselineCompareRun(
|
|
$tenantStale,
|
|
$staleProfile,
|
|
$staleSnapshot,
|
|
workspaceOverviewCompareCoverage(),
|
|
completedAt: now()->subDays(10),
|
|
);
|
|
|
|
$tenantFailedCompare = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
|
'name' => 'Failed Compare Tenant',
|
|
]);
|
|
createUserWithTenant($tenantFailedCompare, $user, role: 'owner', workspaceRole: 'readonly');
|
|
[$failedProfile, $failedSnapshot] = seedActiveBaselineForTenant($tenantFailedCompare);
|
|
seedBaselineCompareRun(
|
|
$tenantFailedCompare,
|
|
$failedProfile,
|
|
$failedSnapshot,
|
|
workspaceOverviewCompareCoverage(),
|
|
outcome: \App\Support\OperationRunOutcome::Failed->value,
|
|
);
|
|
|
|
$workspace = $tenantOverdue->workspace()->firstOrFail();
|
|
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
|
$metrics = collect($overview['summary_metrics'])->keyBy('key');
|
|
|
|
expect($metrics->get('governance_attention_tenants')['value'])->toBe(4)
|
|
->and($metrics->get('governance_attention_tenants')['category'])->toBe('governance_risk')
|
|
->and($metrics->get('governance_attention_tenants')['destination']['kind'])->toBe('choose_tenant');
|
|
});
|
|
|
|
it('keeps activity and alerts metrics separate from governance risk', function (): void {
|
|
$tenant = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner', workspaceRole: 'readonly');
|
|
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
|
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
|
|
|
OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'status' => \App\Support\OperationRunStatus::Running->value,
|
|
'outcome' => \App\Support\OperationRunOutcome::Pending->value,
|
|
]);
|
|
|
|
AlertDelivery::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'status' => AlertDelivery::STATUS_FAILED,
|
|
'created_at' => now(),
|
|
]);
|
|
|
|
$workspace = $tenant->workspace()->firstOrFail();
|
|
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
|
$metrics = collect($overview['summary_metrics'])->keyBy('key');
|
|
|
|
expect($metrics->get('governance_attention_tenants')['value'])->toBe(0)
|
|
->and($metrics->get('active_operations')['value'])->toBe(1)
|
|
->and($metrics->get('active_operations')['category'])->toBe('activity')
|
|
->and($metrics->get('active_operations')['destination']['kind'])->toBe('operations_index')
|
|
->and($metrics->get('alert_failures')['value'])->toBe(1)
|
|
->and($metrics->get('alert_failures')['category'])->toBe('alerts');
|
|
});
|