ahmido
ddf7c15c52
## Summary - move Baseline Compare onto the canonical workspace plus environment owned route instead of workspace-style access - remove legacy environment query and remembered-context fallback paths from the affected Baseline Compare entry points and shell handling - update related navigation, support links, and regression coverage for admin surface scope and managed environment route contracts - add Spec 319 artifacts for the environment-owned surface routing and shell context contract ## Testing - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/BaselineCompareEnvironmentRouteContractTest.php tests/Feature/Filament/BaselineCompareLandingAdminTenantParityTest.php tests/Feature/Filament/BaselineCompareLandingDuplicateNamesBannerTest.php tests/Feature/Filament/BaselineCompareLandingRbacLabelsTest.php tests/Feature/Filament/BaselineCompareLandingStartSurfaceTest.php tests/Feature/Filament/BaselineCompareLandingWhyNoFindingsTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php tests/Feature/Guards/ManagedEnvironmentCanonicalRouteContractTest.php tests/Feature/Navigation/WorkspaceHubRegistryTest.php tests/Feature/Rbac/BaselineCompareMatrixAuthorizationTest.php tests/Feature/Rbac/DriftLandingUiEnforcementTest.php tests/Unit/Tenants/AdminSurfaceScopeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #374
64 lines
3.3 KiB
PHP
64 lines
3.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Navigation\WorkspaceHubRegistry;
|
|
|
|
it('Spec314 lists workspace hubs and explicit exclusions', function (): void {
|
|
expect(array_keys(WorkspaceHubRegistry::entries()))
|
|
->toContain(
|
|
'workspace_home',
|
|
'workspace_overview',
|
|
'operations',
|
|
'provider_connections',
|
|
'finding_exceptions_queue',
|
|
'evidence_overview',
|
|
'review_register',
|
|
'customer_review_workspace',
|
|
'governance_inbox',
|
|
'decision_register',
|
|
'audit_log',
|
|
'alerts',
|
|
'alert_deliveries',
|
|
'alert_rules',
|
|
'alert_destinations',
|
|
'workspace_settings',
|
|
'manage_workspaces',
|
|
'managed_environments_landing',
|
|
)
|
|
->and(array_keys(WorkspaceHubRegistry::exclusions()))
|
|
->toContain(
|
|
'environment_dashboard',
|
|
'stored_reports_environment_routes',
|
|
'support_request_action_surface',
|
|
);
|
|
});
|
|
|
|
it('Spec314 classifies workspace hubs without classifying environment-owned pages', function (): void {
|
|
expect(WorkspaceHubRegistry::isWorkspaceHubPath('/admin'))->toBeTrue()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/workspaces/1/overview'))->toBeTrue()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/workspaces/1/operations'))->toBeTrue()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/workspaces/1/environments'))->toBeTrue()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/workspaces/1/environments/2'))->toBeFalse()
|
|
->and(WorkspaceHubRegistry::isExplicitlyExcludedPath('/admin/workspaces/1/environments/2'))->toBeTrue()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/workspaces/1/environments/2/baseline-compare'))->toBeFalse()
|
|
->and(WorkspaceHubRegistry::isExplicitlyExcludedPath('/admin/workspaces/1/environments/2/baseline-compare'))->toBeTrue()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/baseline-compare-landing'))->toBeFalse()
|
|
->and(WorkspaceHubRegistry::isWorkspaceHubPath('/admin/workspaces/1/environments/2/stored-reports'))->toBeFalse()
|
|
->and(WorkspaceHubRegistry::isExplicitlyExcludedPath('/admin/workspaces/1/environments/2/stored-reports'))->toBeTrue();
|
|
});
|
|
|
|
it('Spec314 owns forbidden query keys and environment-like filter keys', function (): void {
|
|
expect(WorkspaceHubRegistry::forbiddenQueryKeys())
|
|
->toBe(['tenant', 'tenant_id', 'managed_environment_id', 'environment_id', 'environment', 'tenant_scope', 'tableFilters'])
|
|
->and(WorkspaceHubRegistry::environmentLikeFilterKeys())
|
|
->toBe(['tenant', 'tenant_id', 'managed_environment_id', 'environment_id', 'environment', 'tenant_scope']);
|
|
});
|
|
|
|
it('Spec314 strips forbidden workspace hub query keys without touching unrelated navigation state', function (): void {
|
|
$url = WorkspaceHubRegistry::cleanUrl('/admin/provider-connections?tenant=a&tenant_id=1&managed_environment_id=2&environment_id=3&tenant_scope=all&tableFilters%5Btenant%5D=x&activeTab=failed&family=alerts');
|
|
|
|
expect($url)->toBe('/admin/provider-connections?activeTab=failed&family=alerts')
|
|
->and(WorkspaceHubRegistry::hasForbiddenQuery($url))->toBeFalse();
|
|
});
|