ahmido
440e63edff
## Summary
Implements Spec 145 for tenant action taxonomy and lifecycle-safe visibility.
This PR:
- adds a central tenant action policy surface and supporting value objects
- aligns tenant list, detail, edit, onboarding, and widget surfaces around lifecycle-safe actions
- standardizes operator-facing lifecycle wording around View, Resume onboarding, Archive, Restore, and Complete onboarding
- tightens onboarding and tenant lifecycle authorization semantics, including honest 404 vs 403 behavior
- updates related regression coverage and spec artifacts for Spec 145
- fixes follow-on full-suite regressions uncovered during validation, including onboarding browser flows, provider consent fixtures, workspace redirect DI expectations, and critical table/action/UI expectation drift
## Validation
Executed and passed:
- vendor/bin/sail bin pint --dirty --format agent
- vendor/bin/sail artisan test --compact
Result:
- 2581 passed
- 8 skipped
- 13534 assertions
## Notes
- Base branch: dev
- Feature branch commit: a33a41b
- Filament v5 / Livewire v4 compliance preserved
- No panel provider registration changes; Laravel 12 provider registration remains in bootstrap/providers.php
- No new globally searchable resource behavior added in this slice
- Destructive lifecycle actions remain confirmation-gated and authorization-protected
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #174
85 lines
3.2 KiB
PHP
85 lines
3.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\TenantResource\Pages\EditTenant;
|
|
use App\Models\Tenant;
|
|
use Filament\Actions\Action;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
describe('Edit tenant archive action UI enforcement', function () {
|
|
it('shows archive action as visible but disabled for manager members', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant(tenant: $tenant, role: 'manager');
|
|
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditTenant::class, ['record' => $tenant->getRouteKey()])
|
|
->assertActionVisible('archive')
|
|
->assertActionDisabled('archive')
|
|
->assertActionExists('archive', function (Action $action): bool {
|
|
return $action->getLabel() === 'Archive'
|
|
&& $action->isConfirmationRequired()
|
|
&& $action->getTooltip() === 'You do not have permission to archive tenants.';
|
|
})
|
|
->mountAction('archive')
|
|
->callMountedAction()
|
|
->assertSuccessful();
|
|
|
|
$tenant->refresh();
|
|
expect($tenant->trashed())->toBeFalse();
|
|
});
|
|
|
|
it('allows owner members to archive tenant', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditTenant::class, ['record' => $tenant->getRouteKey()])
|
|
->assertActionVisible('archive')
|
|
->assertActionEnabled('archive')
|
|
->assertActionExists('archive', fn (Action $action): bool => $action->getLabel() === 'Archive' && $action->isConfirmationRequired())
|
|
->mountAction('archive')
|
|
->callMountedAction()
|
|
->assertHasNoActionErrors();
|
|
|
|
$tenant->refresh();
|
|
expect($tenant->trashed())->toBeTrue();
|
|
});
|
|
|
|
it('hides the archive action once the tenant is already archived', function () {
|
|
$tenant = Tenant::factory()->archived()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditTenant::class, ['record' => $tenant->getRouteKey()])
|
|
->assertActionHidden('archive');
|
|
});
|
|
|
|
it('uses restore naming and confirmation copy for archived tenants', function () {
|
|
$tenant = Tenant::factory()->archived()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditTenant::class, ['record' => $tenant->getRouteKey()])
|
|
->assertActionVisible('restore')
|
|
->assertActionEnabled('restore')
|
|
->assertActionExists('restore', fn (Action $action): bool => $action->getLabel() === 'Restore' && $action->isConfirmationRequired())
|
|
->assertActionHidden('archive');
|
|
});
|
|
});
|