ahmido
440e63edff
## Summary
Implements Spec 145 for tenant action taxonomy and lifecycle-safe visibility.
This PR:
- adds a central tenant action policy surface and supporting value objects
- aligns tenant list, detail, edit, onboarding, and widget surfaces around lifecycle-safe actions
- standardizes operator-facing lifecycle wording around View, Resume onboarding, Archive, Restore, and Complete onboarding
- tightens onboarding and tenant lifecycle authorization semantics, including honest 404 vs 403 behavior
- updates related regression coverage and spec artifacts for Spec 145
- fixes follow-on full-suite regressions uncovered during validation, including onboarding browser flows, provider consent fixtures, workspace redirect DI expectations, and critical table/action/UI expectation drift
## Validation
Executed and passed:
- vendor/bin/sail bin pint --dirty --format agent
- vendor/bin/sail artisan test --compact
Result:
- 2581 passed
- 8 skipped
- 13534 assertions
## Notes
- Base branch: dev
- Feature branch commit: a33a41b
- Filament v5 / Livewire v4 compliance preserved
- No panel provider registration changes; Laravel 12 provider registration remains in bootstrap/providers.php
- No new globally searchable resource behavior added in this slice
- Destructive lifecycle actions remain confirmation-gated and authorization-protected
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #174
97 lines
3.1 KiB
PHP
97 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Tenant;
|
|
use App\Services\Tenants\TenantOperabilityService;
|
|
use App\Support\Tenants\TenantLifecycle;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('returns lifecycle-aware operability decisions for every canonical tenant state', function (
|
|
\Closure $tenantFactory,
|
|
TenantLifecycle $expectedLifecycle,
|
|
bool $canSelectAsContext,
|
|
bool $canOperate,
|
|
bool $canArchive,
|
|
bool $canRestore,
|
|
bool $canResumeOnboarding,
|
|
): void {
|
|
$tenant = $tenantFactory();
|
|
$decision = app(TenantOperabilityService::class)->decisionFor($tenant);
|
|
|
|
expect($decision->lifecycle)->toBe($expectedLifecycle)
|
|
->and($decision->canViewTenantSurface)->toBeTrue()
|
|
->and($decision->canSelectAsContext)->toBe($canSelectAsContext)
|
|
->and($decision->canOperate)->toBe($canOperate)
|
|
->and($decision->canArchive)->toBe($canArchive)
|
|
->and($decision->canRestore)->toBe($canRestore)
|
|
->and($decision->canResumeOnboarding)->toBe($canResumeOnboarding)
|
|
->and($decision->canReferenceInWorkspaceMonitoring)->toBeTrue();
|
|
})->with([
|
|
'draft' => [
|
|
fn (): Tenant => Tenant::factory()->draft()->create(),
|
|
TenantLifecycle::Draft,
|
|
false,
|
|
false,
|
|
false,
|
|
false,
|
|
true,
|
|
],
|
|
'onboarding' => [
|
|
fn (): Tenant => Tenant::factory()->onboarding()->create(),
|
|
TenantLifecycle::Onboarding,
|
|
false,
|
|
false,
|
|
false,
|
|
false,
|
|
true,
|
|
],
|
|
'active' => [
|
|
fn (): Tenant => Tenant::factory()->active()->create(),
|
|
TenantLifecycle::Active,
|
|
true,
|
|
true,
|
|
true,
|
|
false,
|
|
false,
|
|
],
|
|
'archived' => [
|
|
fn (): Tenant => Tenant::factory()->archived()->create(),
|
|
TenantLifecycle::Archived,
|
|
false,
|
|
false,
|
|
false,
|
|
true,
|
|
false,
|
|
],
|
|
]);
|
|
|
|
it('returns lifecycle-safe primary management action keys', function (
|
|
\Closure $tenantFactory,
|
|
?string $expectedActionKey,
|
|
): void {
|
|
$tenant = $tenantFactory();
|
|
|
|
expect(app(TenantOperabilityService::class)->primaryManagementActionKey($tenant))
|
|
->toBe($expectedActionKey);
|
|
})->with([
|
|
'draft-primary' => [fn (): Tenant => Tenant::factory()->draft()->create(), null],
|
|
'onboarding-primary' => [fn (): Tenant => Tenant::factory()->onboarding()->create(), null],
|
|
'active-primary' => [fn (): Tenant => Tenant::factory()->active()->create(), 'archive'],
|
|
'archived-primary' => [fn (): Tenant => Tenant::factory()->archived()->create(), 'restore'],
|
|
]);
|
|
|
|
it('can prefer onboarding as the primary management action for draft-like tenants', function (
|
|
\Closure $tenantFactory,
|
|
): void {
|
|
$tenant = $tenantFactory();
|
|
|
|
expect(app(TenantOperabilityService::class)->primaryManagementActionKey($tenant, preferOnboarding: true))
|
|
->toBe('resume_onboarding');
|
|
})->with([
|
|
'draft-prefers-onboarding' => [fn (): Tenant => Tenant::factory()->draft()->create()],
|
|
'onboarding-prefers-onboarding' => [fn (): Tenant => Tenant::factory()->onboarding()->create()],
|
|
]);
|