ahmido
bc846d7c5c
Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
51 lines
1.5 KiB
PHP
51 lines
1.5 KiB
PHP
<?php
|
|
|
|
use App\Models\EntraGroup;
|
|
use App\Models\Tenant;
|
|
use App\Services\Directory\EntraGroupLabelResolver;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('formats unresolved labels using an ellipsis + last 8 chars', function () {
|
|
$id = '11111111-2222-3333-4444-555555555555';
|
|
|
|
expect(EntraGroupLabelResolver::formatLabel(null, $id))
|
|
->toBe('Unresolved (…55555555)');
|
|
});
|
|
|
|
it('resolves labels from the tenant cache (tenant-scoped)', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
|
|
$entraId = '11111111-2222-3333-4444-555555555555';
|
|
|
|
EntraGroup::factory()->create([
|
|
'tenant_id' => $tenantA->getKey(),
|
|
'entra_id' => $entraId,
|
|
'display_name' => 'Alpha Team',
|
|
]);
|
|
|
|
EntraGroup::factory()->create([
|
|
'tenant_id' => $tenantB->getKey(),
|
|
'entra_id' => $entraId,
|
|
'display_name' => 'Beta Team',
|
|
]);
|
|
|
|
$resolver = app(EntraGroupLabelResolver::class);
|
|
|
|
expect($resolver->resolveOne($tenantA, $entraId))
|
|
->toBe('Alpha Team (…55555555)')
|
|
->and($resolver->resolveOne($tenantB, $entraId))
|
|
->toBe('Beta Team (…55555555)');
|
|
});
|
|
|
|
it('returns a fallback without querying invalid UUIDs', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$resolver = app(EntraGroupLabelResolver::class);
|
|
|
|
expect($resolver->resolveOne($tenant, 'group-123'))
|
|
->toBe('Unresolved (group123)');
|
|
});
|