## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
73 lines
2.5 KiB
PHP
73 lines
2.5 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\Workspace;
|
|
use App\Support\WorkspaceIsolation\WorkspaceIsolationViolation;
|
|
|
|
it('derives workspace_id from tenant when missing on create', function (): void {
|
|
$workspace = Workspace::factory()->create();
|
|
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
]);
|
|
|
|
$policy = Policy::query()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'external_id' => 'policy-derived-workspace',
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Derived Workspace Policy',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
expect((int) $policy->workspace_id)->toBe((int) $tenant->workspace_id);
|
|
});
|
|
|
|
it('rejects create when workspace_id mismatches tenant workspace', function (): void {
|
|
$workspaceA = Workspace::factory()->create();
|
|
$workspaceB = Workspace::factory()->create();
|
|
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $workspaceA->getKey(),
|
|
]);
|
|
|
|
expect(fn () => Policy::query()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $workspaceB->getKey(),
|
|
'external_id' => 'policy-workspace-mismatch',
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Workspace Mismatch Policy',
|
|
'platform' => 'windows',
|
|
]))->toThrow(WorkspaceIsolationViolation::class);
|
|
});
|
|
|
|
it('rejects managed_environment_id changes after create', function (): void {
|
|
$workspaceA = Workspace::factory()->create();
|
|
$workspaceB = Workspace::factory()->create();
|
|
|
|
$tenantA = ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $workspaceA->getKey(),
|
|
]);
|
|
|
|
$tenantB = ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $workspaceB->getKey(),
|
|
]);
|
|
|
|
$policy = Policy::query()->create([
|
|
'managed_environment_id' => (int) $tenantA->getKey(),
|
|
'external_id' => 'policy-tenant-immutable',
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'ManagedEnvironment Immutable Policy',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
expect(fn () => $policy->update([
|
|
'managed_environment_id' => (int) $tenantB->getKey(),
|
|
]))->toThrow(WorkspaceIsolationViolation::class);
|
|
|
|
$policy->refresh();
|
|
|
|
expect((int) $policy->managed_environment_id)->toBe((int) $tenantA->getKey());
|
|
expect((int) $policy->workspace_id)->toBe((int) $tenantA->workspace_id);
|
|
});
|