## Summary - standardize Microsoft provider connections around explicit platform vs dedicated identity modes - centralize admin-consent URL and runtime identity resolution so platform flows no longer fall back to tenant-local credentials - add migration classification, richer consent and verification state handling, dedicated override management, and focused regression coverage ## Validation - focused repo test coverage was added across provider identity, onboarding, audit, policy, guard, and migration flows - latest explicit passing run in the workspace: `vendor/bin/sail artisan test --compact tests/Feature/AdminConsentCallbackTest.php tests/Feature/Audit/ProviderConnectionConsentAuditTest.php` ## Notes - branch includes the full Spec 137 artifact set under `specs/137-platform-provider-identity/` - target base branch: `dev` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #166
57 lines
1.7 KiB
PHP
57 lines
1.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Illuminate\Support\Collection;
|
|
|
|
it('blocks legacy tenant app fallback reads in standard provider surfaces', function (): void {
|
|
$root = base_path();
|
|
$self = realpath(__FILE__);
|
|
|
|
$files = collect([
|
|
'app/Filament/Resources/TenantResource.php',
|
|
'app/Http/Controllers/TenantOnboardingController.php',
|
|
'app/Services/Providers/AdminConsentUrlFactory.php',
|
|
'app/Services/Providers/MicrosoftGraphOptionsResolver.php',
|
|
'app/Services/Providers/ProviderConnectionResolver.php',
|
|
'app/Services/Providers/ProviderGateway.php',
|
|
'app/Services/Providers/ProviderIdentityResolver.php',
|
|
])
|
|
->map(fn (string $relative): string => $root.'/'.$relative)
|
|
->filter(fn (string $absolute): bool => is_file($absolute))
|
|
->values();
|
|
|
|
$patterns = [
|
|
'/->app_client_id\b/',
|
|
'/->app_client_secret\b/',
|
|
];
|
|
|
|
$hits = [];
|
|
|
|
/** @var Collection<int, string> $files */
|
|
foreach ($files as $path) {
|
|
if ($self && realpath($path) === $self) {
|
|
continue;
|
|
}
|
|
|
|
$contents = file_get_contents($path);
|
|
|
|
if (! is_string($contents) || $contents === '') {
|
|
continue;
|
|
}
|
|
|
|
$relative = str_replace($root.'/', '', $path);
|
|
$lines = preg_split('/\R/', $contents) ?: [];
|
|
|
|
foreach ($patterns as $pattern) {
|
|
foreach ($lines as $index => $line) {
|
|
if (preg_match($pattern, $line) === 1) {
|
|
$hits[] = $relative.':'.($index + 1).' -> '.trim($line);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
expect($hits)->toBeEmpty("Legacy tenant provider fallback detected:\n".implode("\n", $hits));
|
|
});
|