ahmido
bab01f07a9
## Summary - standardize Microsoft provider connections around explicit platform vs dedicated identity modes - centralize admin-consent URL and runtime identity resolution so platform flows no longer fall back to tenant-local credentials - add migration classification, richer consent and verification state handling, dedicated override management, and focused regression coverage ## Validation - focused repo test coverage was added across provider identity, onboarding, audit, policy, guard, and migration flows - latest explicit passing run in the workspace: `vendor/bin/sail artisan test --compact tests/Feature/AdminConsentCallbackTest.php tests/Feature/Audit/ProviderConnectionConsentAuditTest.php` ## Notes - branch includes the full Spec 137 artifact set under `specs/137-platform-provider-identity/` - target base branch: `dev` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #166
75 lines
2.9 KiB
PHP
75 lines
2.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ProviderConnectionResource\Pages\EditProviderConnection;
|
|
use App\Models\ProviderConnection;
|
|
use App\Support\Auth\UiTooltips;
|
|
use Filament\Actions\Action;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
it('shows dedicated override actions as enabled for tenant owners', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
$connection = ProviderConnection::factory()->platform()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditProviderConnection::class, ['record' => $connection->getRouteKey()])
|
|
->assertActionVisible('enable_dedicated_override')
|
|
->assertActionEnabled('enable_dedicated_override');
|
|
});
|
|
|
|
it('shows dedicated override actions as disabled for tenant managers without the stronger capability', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
$connection = ProviderConnection::factory()->platform()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditProviderConnection::class, ['record' => $connection->getRouteKey()])
|
|
->assertActionVisible('enable_dedicated_override')
|
|
->assertActionDisabled('enable_dedicated_override')
|
|
->assertActionExists('enable_dedicated_override', function (Action $action): bool {
|
|
return $action->getTooltip() === UiTooltips::insufficientPermission();
|
|
});
|
|
});
|
|
|
|
it('does not mutate the connection when a tenant manager attempts a dedicated override action', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
$connection = ProviderConnection::factory()->platform()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::test(EditProviderConnection::class, ['record' => $connection->getRouteKey()])
|
|
->callAction('enable_dedicated_override', data: [
|
|
'client_id' => 'manager-dedicated-client',
|
|
'client_secret' => 'manager-dedicated-secret',
|
|
]);
|
|
|
|
$connection->refresh();
|
|
|
|
expect($connection->connection_type)->toBe(\App\Support\Providers\ProviderConnectionType::Platform)
|
|
->and($connection->credential)->toBeNull();
|
|
});
|