## Summary - introduce a shared tenant-owned query and record-resolution canon for first-slice Filament resources - harden direct views, row actions, bulk actions, relation managers, and workspace-admin canonical viewers against wrong-tenant access - add registry-backed rollout metadata, search posture handling, architectural guards, and focused Pest coverage for scope parity and 404/403 semantics ## Included - Spec 150 package under `specs/150-tenant-owned-query-canon-and-wrong-tenant-guards/` - shared support classes: `TenantOwnedModelFamilies`, `TenantOwnedQueryScope`, `TenantOwnedRecordResolver` - shared Filament concern: `InteractsWithTenantOwnedRecords` - resource/page/policy hardening across findings, policies, policy versions, backup schedules, backup sets, restore runs, inventory items, and Entra groups - additional regression coverage for canonical tenant state, wrong-tenant record resolution, relation-manager congruence, and action-surface guardrails ## Validation - `vendor/bin/sail artisan test --compact` passed - full suite result: `2733 passed, 8 skipped` - formatting applied with `vendor/bin/sail bin pint --dirty --format agent` ## Notes - Livewire v4.0+ compliant via existing Filament v5 stack - provider registration remains in `bootstrap/providers.php` - globally searchable first-slice posture: Entra groups scoped; policies and policy versions explicitly disabled - destructive actions continue to use confirmation and policy authorization - no new Filament assets added; existing deployment flow remains unchanged, including `php artisan filament:assets` when registered assets are used Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #180
162 lines
5.8 KiB
PHP
162 lines
5.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\InventoryItemResource;
|
|
use App\Filament\Resources\InventoryItemResource\Pages\ListInventoryItems;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
describe('Inventory item resource authorization', function () {
|
|
it('is not visible for non-members', function () {
|
|
$user = User::factory()->create();
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
|
|
expect(InventoryItemResource::canViewAny())->toBeFalse();
|
|
});
|
|
|
|
it('is visible for readonly members', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
|
|
expect(InventoryItemResource::canViewAny())->toBeTrue();
|
|
});
|
|
|
|
it('prevents viewing inventory items from other tenants', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$otherTenant = Tenant::factory()->create();
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
|
|
$record = InventoryItem::factory()->create([
|
|
'tenant_id' => $otherTenant->getKey(),
|
|
]);
|
|
|
|
expect(InventoryItemResource::canView($record))->toBeFalse();
|
|
});
|
|
|
|
it('allows viewing inventory items from the current tenant', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
|
|
$record = InventoryItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
]);
|
|
|
|
expect(InventoryItemResource::canView($record))->toBeTrue();
|
|
});
|
|
|
|
it('keeps composed persisted inventory filters scoped to the active tenant', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
|
|
|
$tenantAFresh = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'display_name' => 'Tenant A Fresh Windows',
|
|
'platform' => 'windows',
|
|
'last_seen_at' => now(),
|
|
]);
|
|
|
|
$tenantAStale = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'display_name' => 'Tenant A Stale Windows',
|
|
'platform' => 'windows',
|
|
'last_seen_at' => now()->subDays(3),
|
|
]);
|
|
|
|
$tenantBStale = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenantB->getKey(),
|
|
'display_name' => 'Tenant B Stale Windows',
|
|
'platform' => 'windows',
|
|
'last_seen_at' => now()->subDays(3),
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
$tenantA->makeCurrent();
|
|
Filament::setTenant($tenantA, true);
|
|
|
|
Livewire::test(ListInventoryItems::class)
|
|
->filterTable('platform', 'windows')
|
|
->filterTable('stale', '1')
|
|
->assertCanSeeTableRecords([$tenantAStale])
|
|
->assertCanNotSeeTableRecords([$tenantAFresh, $tenantBStale]);
|
|
|
|
Livewire::test(ListInventoryItems::class)
|
|
->assertSet('tableFilters.platform.value', 'windows')
|
|
->assertSet('tableFilters.stale.value', '1')
|
|
->assertCanSeeTableRecords([$tenantAStale])
|
|
->assertCanNotSeeTableRecords([$tenantAFresh, $tenantBStale]);
|
|
});
|
|
|
|
it('keeps persisted admin inventory search and filters inside the remembered canonical tenant after tenant changes', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
|
|
|
$tenantARecord = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'display_name' => 'Shared Windows Device',
|
|
'platform' => 'windows',
|
|
'last_seen_at' => now()->subDays(3),
|
|
]);
|
|
|
|
$tenantBRecord = InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenantB->getKey(),
|
|
'display_name' => 'Shared Windows Device',
|
|
'platform' => 'windows',
|
|
'last_seen_at' => now()->subDays(3),
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenantA->workspace_id);
|
|
session()->put(WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY, [
|
|
(string) $tenantA->workspace_id => (int) $tenantA->getKey(),
|
|
]);
|
|
|
|
Livewire::actingAs($user)->test(ListInventoryItems::class)
|
|
->searchTable('Shared Windows')
|
|
->filterTable('platform', 'windows')
|
|
->filterTable('stale', '1')
|
|
->assertCanSeeTableRecords([$tenantARecord])
|
|
->assertCanNotSeeTableRecords([$tenantBRecord]);
|
|
|
|
session()->put(WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY, [
|
|
(string) $tenantA->workspace_id => (int) $tenantB->getKey(),
|
|
]);
|
|
|
|
Livewire::actingAs($user)->test(ListInventoryItems::class)
|
|
->assertSet('tableSearch', 'Shared Windows')
|
|
->assertSet('tableFilters.platform.value', 'windows')
|
|
->assertSet('tableFilters.stale.value', '1')
|
|
->assertCanSeeTableRecords([$tenantBRecord])
|
|
->assertCanNotSeeTableRecords([$tenantARecord]);
|
|
});
|
|
});
|