Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
63 lines
2.1 KiB
PHP
63 lines
2.1 KiB
PHP
<?php
|
|
|
|
namespace App\Services\Inventory;
|
|
|
|
use App\Models\InventoryItem;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Services\BackupScheduling\PolicyTypeResolver;
|
|
use Illuminate\Database\Eloquent\Collection;
|
|
|
|
class InventoryMissingService
|
|
{
|
|
public function __construct(
|
|
private readonly InventorySelectionHasher $selectionHasher,
|
|
private readonly PolicyTypeResolver $policyTypeResolver,
|
|
) {}
|
|
|
|
/**
|
|
* @param array<string, mixed> $selectionPayload
|
|
* @return array{latestRun: OperationRun|null, missing: Collection<int, InventoryItem>, lowConfidence: bool}
|
|
*/
|
|
public function missingForSelection(Tenant $tenant, array $selectionPayload): array
|
|
{
|
|
$normalized = $this->selectionHasher->normalize($selectionPayload);
|
|
$normalized['policy_types'] = $this->policyTypeResolver->filterRuntime($normalized['policy_types']);
|
|
$selectionHash = $this->selectionHasher->hash($normalized);
|
|
|
|
$latestRun = OperationRun::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('type', 'inventory_sync')
|
|
->where('status', 'completed')
|
|
->where('context->selection_hash', $selectionHash)
|
|
->orderByDesc('completed_at')
|
|
->orderByDesc('id')
|
|
->first();
|
|
|
|
if (! $latestRun) {
|
|
return [
|
|
'latestRun' => null,
|
|
'missing' => InventoryItem::query()->whereRaw('1 = 0')->get(),
|
|
'lowConfidence' => true,
|
|
];
|
|
}
|
|
|
|
$missingQuery = InventoryItem::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->whereIn('policy_type', $normalized['policy_types'])
|
|
->where(function ($query) use ($latestRun): void {
|
|
$query
|
|
->whereNull('last_seen_operation_run_id')
|
|
->orWhere('last_seen_operation_run_id', '!=', $latestRun->getKey());
|
|
});
|
|
|
|
$lowConfidence = $latestRun->outcome !== 'succeeded';
|
|
|
|
return [
|
|
'latestRun' => $latestRun,
|
|
'missing' => $missingQuery->get(),
|
|
'lowConfidence' => $lowConfidence,
|
|
];
|
|
}
|
|
}
|