Implements Spec 104: Provider Permission Posture. What changed - Generates permission posture findings after each tenant permission compare (queued) - Stores immutable posture snapshots as StoredReports (JSONB payload) - Adds global Finding resolved lifecycle (`resolved_at`, `resolved_reason`) with `resolve()` / `reopen()` - Adds alert pipeline event type `permission_missing` (Alerts v1) and Filament option for Alert Rules - Adds retention pruning command + daily schedule for StoredReports - Adds badge mappings for `resolved` finding status and `permission_posture` finding type UX fixes discovered during manual verification - Hide “Diff” section for non-drift findings (only drift findings show diff) - Required Permissions page: “Re-run verification” now links to Tenant view (not onboarding) - Preserve Technical Details `<details>` open state across Livewire re-renders (Alpine state) Verification - Ran `vendor/bin/sail artisan test --compact --filter=PermissionPosture` (50 tests) - Ran `vendor/bin/sail artisan test --compact --filter="FindingResolved|FindingBadge|PermissionMissingAlert"` (20 tests) - Ran `vendor/bin/sail bin pint --dirty` Filament v5 / Livewire v4 compliance - Filament v5 + Livewire v4: no Livewire v3 usage. Panel provider registration (Laravel 11+) - No new panels added. Existing panel providers remain registered via `bootstrap/providers.php`. Global search rule - No changes to global-searchable resources. Destructive actions - No new destructive Filament actions were added in this PR. Assets / deploy notes - No new Filament assets registered. Existing deploy step `php artisan filament:assets` remains unchanged. Test coverage - New/updated Pest feature tests cover generator behavior, job integration, alerting, retention pruning, and resolved lifecycle. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #127
92 lines
3.3 KiB
PHP
92 lines
3.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Finding;
|
|
use App\Models\User;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('resolves a finding with reason', function (): void {
|
|
$finding = Finding::factory()->permissionPosture()->create();
|
|
|
|
$finding->resolve('permission_granted');
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and($finding->resolved_at)->not->toBeNull()
|
|
->and($finding->resolved_reason)->toBe('permission_granted');
|
|
|
|
$fresh = Finding::query()->find($finding->getKey());
|
|
expect($fresh->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and($fresh->resolved_at)->not->toBeNull();
|
|
});
|
|
|
|
it('reopens a resolved finding', function (): void {
|
|
$finding = Finding::factory()->permissionPosture()->resolved()->create();
|
|
|
|
$newEvidence = [
|
|
'permission_key' => 'DeviceManagementConfiguration.ReadWrite.All',
|
|
'permission_type' => 'application',
|
|
'expected_status' => 'granted',
|
|
'actual_status' => 'missing',
|
|
'blocked_features' => ['policy-sync'],
|
|
'checked_at' => now()->toIso8601String(),
|
|
];
|
|
|
|
$finding->reopen($newEvidence);
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_NEW)
|
|
->and($finding->resolved_at)->toBeNull()
|
|
->and($finding->resolved_reason)->toBeNull()
|
|
->and($finding->evidence_jsonb)->toBe($newEvidence);
|
|
});
|
|
|
|
it('preserves acknowledged metadata when resolving an acknowledged finding', function (): void {
|
|
$user = User::factory()->create();
|
|
$finding = Finding::factory()->permissionPosture()->create();
|
|
|
|
$finding->acknowledge($user);
|
|
expect($finding->status)->toBe(Finding::STATUS_ACKNOWLEDGED);
|
|
|
|
$finding->resolve('permission_granted');
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and($finding->acknowledged_at)->not->toBeNull()
|
|
->and($finding->acknowledged_by_user_id)->toBe($user->getKey())
|
|
->and($finding->resolved_at)->not->toBeNull();
|
|
});
|
|
|
|
it('has STATUS_RESOLVED constant', function (): void {
|
|
expect(Finding::STATUS_RESOLVED)->toBe('resolved');
|
|
});
|
|
|
|
it('has FINDING_TYPE_PERMISSION_POSTURE constant', function (): void {
|
|
expect(Finding::FINDING_TYPE_PERMISSION_POSTURE)->toBe('permission_posture');
|
|
});
|
|
|
|
it('casts resolved_at as datetime', function (): void {
|
|
$finding = Finding::factory()->permissionPosture()->resolved()->create();
|
|
$fresh = Finding::query()->find($finding->getKey());
|
|
|
|
expect($fresh->resolved_at)->toBeInstanceOf(\Illuminate\Support\Carbon::class);
|
|
});
|
|
|
|
it('creates permission posture findings via factory state', function (): void {
|
|
$finding = Finding::factory()->permissionPosture()->create();
|
|
|
|
expect($finding->finding_type)->toBe(Finding::FINDING_TYPE_PERMISSION_POSTURE)
|
|
->and($finding->source)->toBe('permission_check')
|
|
->and($finding->subject_type)->toBe('permission')
|
|
->and($finding->severity)->toBe(Finding::SEVERITY_MEDIUM)
|
|
->and($finding->evidence_jsonb)->toHaveKey('permission_key');
|
|
});
|
|
|
|
it('creates resolved findings via factory state', function (): void {
|
|
$finding = Finding::factory()->resolved()->create();
|
|
|
|
expect($finding->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and($finding->resolved_at)->not->toBeNull()
|
|
->and($finding->resolved_reason)->toBe('permission_granted');
|
|
});
|