ahmido
f52d52540c
## Summary - implement Spec 177 inventory coverage truth across resolver, badges, KPIs, coverage page, and operation run detail surfaces - add repo-native spec artifacts for the feature under `specs/177-inventory-coverage-truth` - add unit, feature, and browser coverage for truth derivation, continuity, and inventory item filter/pagination smoke paths ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - focused Spec 177 browser smoke file passed with 2 tests / 57 assertions - extended inventory-focused test pack passed with 52 tests / 434 assertions Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #208
111 lines
4.1 KiB
PHP
111 lines
4.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\InventoryCoverage;
|
|
use App\Filament\Resources\InventoryItemResource;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\Inventory\InventoryCoverage as InventoryCoveragePayload;
|
|
use App\Support\Inventory\InventoryPolicyTypeMeta;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function seedInventoryCoverageBasis(Tenant $tenant): OperationRun
|
|
{
|
|
InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'display_name' => 'Conditional Access Prod',
|
|
'policy_type' => 'conditionalAccessPolicy',
|
|
'external_id' => 'ca-1',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
InventoryItem::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'display_name' => 'Device Compliance Legacy',
|
|
'policy_type' => 'deviceCompliancePolicy',
|
|
'external_id' => 'dc-1',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
return OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'inventory_sync',
|
|
'status' => 'completed',
|
|
'outcome' => 'partially_succeeded',
|
|
'context' => [
|
|
'inventory' => [
|
|
'coverage' => InventoryCoveragePayload::buildPayload([
|
|
'conditionalAccessPolicy' => [
|
|
'status' => InventoryCoveragePayload::StatusSucceeded,
|
|
'item_count' => 1,
|
|
],
|
|
'deviceConfiguration' => [
|
|
'status' => InventoryCoveragePayload::StatusFailed,
|
|
'item_count' => 0,
|
|
'error_code' => 'graph_forbidden',
|
|
],
|
|
'roleScopeTag' => [
|
|
'status' => InventoryCoveragePayload::StatusSkipped,
|
|
'item_count' => 0,
|
|
],
|
|
], ['roleScopeTag']),
|
|
],
|
|
],
|
|
'completed_at' => now(),
|
|
]);
|
|
}
|
|
|
|
test('inventory hub pages render truthful coverage-first summaries and basis continuity', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$basisRun = seedInventoryCoverageBasis($tenant);
|
|
|
|
$itemsUrl = InventoryItemResource::getUrl('index', tenant: $tenant);
|
|
$coverageUrl = InventoryCoverage::getUrl(tenant: $tenant);
|
|
|
|
$this->actingAs($user)
|
|
->get($itemsUrl)
|
|
->assertOk()
|
|
->assertSee('Run Inventory Sync')
|
|
->assertSee('Total items')
|
|
->assertSee('Covered types')
|
|
->assertSee('Need follow-up')
|
|
->assertSee('Coverage basis')
|
|
->assertSee('Active ops')
|
|
->assertSee('Open basis run')
|
|
->assertSee(route('admin.operations.view', ['run' => (int) $basisRun->getKey()]), false)
|
|
->assertSee('Conditional Access Prod');
|
|
|
|
$this->actingAs($user)
|
|
->get($coverageUrl)
|
|
->assertOk()
|
|
->assertSee('Tenant coverage truth')
|
|
->assertSee('Covered types')
|
|
->assertSee('Need follow-up')
|
|
->assertSee('Observed items')
|
|
->assertSee('Inventory sync history')
|
|
->assertSee('Open inventory items')
|
|
->assertSee((string) InventoryPolicyTypeMeta::label('conditionalAccessPolicy'))
|
|
->assertSee((string) InventoryPolicyTypeMeta::label('deviceConfiguration'))
|
|
->assertSee((string) InventoryPolicyTypeMeta::label('deviceCompliancePolicy'))
|
|
->assertSee('Review provider consent or permissions, then rerun inventory sync.');
|
|
});
|
|
|
|
test('inventory coverage page makes the no-basis fallback explicit', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get(InventoryCoverage::getUrl(tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('No current coverage basis')
|
|
->assertSee('Run Inventory Sync from Inventory Items to establish current tenant coverage truth.')
|
|
->assertSee('Open inventory items');
|
|
});
|