Summary This PR implements Spec 049 – Backup/Restore Job Orchestration: all critical Backup/Restore execution paths are job-only, idempotent, tenant-scoped, and observable via run records + DB notifications (Phase 1). The UI no longer performs heavy Graph work inside request/Filament actions for these flows. Why We want predictable UX and operations at MSP scale: • no timeouts / long-running requests • reproducible run state + per-item results • safe error persistence (no secrets / no token leakage) • strict tenant isolation + auditability for write paths What changed Foundational (Runs + Idempotency + Observability) • Added a shared RunIdempotency helper (dedupe while queued/running). • Added a read-only BulkOperationRuns surface (list + view) for status/progress. • Added DB notifications for run status changes (with “View run” link). US1 – Policy “Capture snapshot” is job-only • Policy detail “Capture snapshot” now: • creates/reuses a run (dedupe key: tenant + policy.capture_snapshot + policy DB id) • dispatches a queued job • returns immediately with notification + link to run detail • Graph capture work moved fully into the job; request path stays Graph-free. US3 – Restore runs orchestration is job-only + safe • Live restore execution is queued and updates RestoreRun status/progress. • Per-item outcomes are persisted deterministically (per internal DB record). • Audit logging is written for live restore. • Preview/dry-run is enforced as read-only (no writes). Tenant isolation / authorization (non-negotiable) • Run list/view/start are tenant-scoped and policy-guarded (cross-tenant access => 403, not 404). • Explicit Pest tests cover cross-tenant denial and start authorization. Tests / Verification • ./vendor/bin/pint --dirty • Targeted suite (examples): • policy capture snapshot queued + idempotency tests • restore orchestration + audit logging + preview read-only tests • run authorization / tenant isolation tests Notes / Scope boundaries • Phase 1 UX = DB notifications + run detail page. A global “progress widget” is tracked as Phase 2 and not required for merge. • Resilience/backoff is tracked in tasks but can be iterated further after merge. Review focus • Dedupe behavior for queued/running runs (reuse vs create-new) • Tenant scoping & policy gates for all run surfaces • Restore safety: audit event + preview no-writes Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #56
95 lines
2.8 KiB
PHP
95 lines
2.8 KiB
PHP
<?php
|
|
|
|
namespace App\Notifications;
|
|
|
|
use App\Filament\Resources\BulkOperationRunResource;
|
|
use App\Filament\Resources\RestoreRunResource;
|
|
use App\Models\Tenant;
|
|
use Filament\Actions\Action;
|
|
use Illuminate\Notifications\Notification;
|
|
|
|
class RunStatusChangedNotification extends Notification
|
|
{
|
|
/**
|
|
* @param array{
|
|
* tenant_id:int,
|
|
* run_type:string,
|
|
* run_id:int,
|
|
* status:string,
|
|
* counts?:array{total?:int, processed?:int, succeeded?:int, failed?:int, skipped?:int}
|
|
* } $metadata
|
|
*/
|
|
public function __construct(public array $metadata) {}
|
|
|
|
/**
|
|
* @return array<int, string>
|
|
*/
|
|
public function via(object $notifiable): array
|
|
{
|
|
return ['database'];
|
|
}
|
|
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
public function toDatabase(object $notifiable): array
|
|
{
|
|
$status = (string) ($this->metadata['status'] ?? 'queued');
|
|
$runType = (string) ($this->metadata['run_type'] ?? 'run');
|
|
$tenantId = (int) ($this->metadata['tenant_id'] ?? 0);
|
|
$runId = (int) ($this->metadata['run_id'] ?? 0);
|
|
|
|
$title = match ($status) {
|
|
'queued' => 'Run queued',
|
|
'running' => 'Run started',
|
|
'completed', 'succeeded' => 'Run completed',
|
|
'partial', 'completed_with_errors' => 'Run completed (partial)',
|
|
'failed' => 'Run failed',
|
|
default => 'Run updated',
|
|
};
|
|
|
|
$body = sprintf('A %s run changed status to: %s.', str_replace('_', ' ', $runType), $status);
|
|
|
|
$color = match ($status) {
|
|
'queued', 'running' => 'gray',
|
|
'completed', 'succeeded' => 'success',
|
|
'partial', 'completed_with_errors' => 'warning',
|
|
'failed' => 'danger',
|
|
default => 'gray',
|
|
};
|
|
|
|
$actions = [];
|
|
|
|
if (in_array($runType, ['bulk_operation', 'restore'], true) && $tenantId > 0 && $runId > 0) {
|
|
$tenant = Tenant::query()->find($tenantId);
|
|
|
|
if ($tenant) {
|
|
$url = $runType === 'bulk_operation'
|
|
? BulkOperationRunResource::getUrl('view', ['record' => $runId], tenant: $tenant)
|
|
: RestoreRunResource::getUrl('view', ['record' => $runId], tenant: $tenant);
|
|
|
|
$actions[] = Action::make('view_run')
|
|
->label('View run')
|
|
->url($url)
|
|
->toArray();
|
|
}
|
|
}
|
|
|
|
return [
|
|
'format' => 'filament',
|
|
'title' => $title,
|
|
'body' => $body,
|
|
'color' => $color,
|
|
'duration' => 'persistent',
|
|
'actions' => $actions,
|
|
'icon' => null,
|
|
'iconColor' => null,
|
|
'status' => null,
|
|
'view' => null,
|
|
'viewData' => [
|
|
'metadata' => $this->metadata,
|
|
],
|
|
];
|
|
}
|
|
}
|