ahmido
da1adbdeb5
Implements Spec 119 (Drift Golden Master Cutover): - Baseline Compare is the only drift writer (`source = baseline.compare`). - Drift findings now store diff-compatible `evidence_jsonb` (summary.kind, baseline/current policy_version_id refs, fidelity + provenance). - Findings UI renders one-sided diffs for `missing_policy`/`unexpected_policy` when a single ref exists; otherwise shows explicit “diff unavailable”. - Removes legacy drift generator runtime (jobs/services/UI) and related tests. - Adds one-time migration to delete legacy drift findings (`finding_type=drift` where source is null or != baseline.compare). - Scopes baseline capture & landing duplicate warnings to latest completed inventory sync. - Canonicalizes compliance `scheduledActionsForRule` drift signal and keeps legacy snapshots comparable. Tests: - `vendor/bin/sail artisan test --compact` (full suite per tasks) - Focused pack: BaselinePolicyVersionResolverTest, BaselineCompareDriftEvidenceContractTest, DriftFindingDiffUnavailableTest, LegacyDriftFindingsCleanupMigrationTest, ComplianceNoncomplianceActionsDriftTest Notes: - Livewire v4+ / Filament v5 compatible (no legacy APIs). - No new external dependencies. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #144
134 lines
4.2 KiB
PHP
134 lines
4.2 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\Tenant;
|
|
use App\Services\Baselines\Evidence\BaselinePolicyVersionResolver;
|
|
use App\Support\Baselines\BaselineSubjectKey;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
$this->resolver = new BaselinePolicyVersionResolver;
|
|
});
|
|
|
|
test('resolves baseline policy version id within observed second', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$displayName = 'Policy Alpha';
|
|
$subjectKey = BaselineSubjectKey::fromDisplayName($displayName);
|
|
|
|
expect($subjectKey)->not->toBeNull();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => $displayName,
|
|
]);
|
|
|
|
$capturedAt = CarbonImmutable::parse('2026-03-05 12:00:00.123456');
|
|
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'version_number' => 1,
|
|
'captured_at' => $capturedAt,
|
|
]);
|
|
|
|
$resolved = $this->resolver->resolve(
|
|
tenant: $tenant,
|
|
policyType: (string) $policy->policy_type,
|
|
subjectKey: (string) $subjectKey,
|
|
observedAt: $capturedAt->toIso8601String(),
|
|
);
|
|
|
|
expect($resolved)->toBe((int) $version->getKey());
|
|
});
|
|
|
|
test('returns null when no policy matches subject key', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Some Other Policy',
|
|
]);
|
|
|
|
$resolved = $this->resolver->resolve(
|
|
tenant: $tenant,
|
|
policyType: 'settingsCatalogPolicy',
|
|
subjectKey: 'missing-subject-key',
|
|
observedAt: CarbonImmutable::parse('2026-03-05 12:00:00')->toIso8601String(),
|
|
);
|
|
|
|
expect($resolved)->toBeNull();
|
|
});
|
|
|
|
test('returns null when observed_at is invalid', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Policy Alpha',
|
|
]);
|
|
|
|
$subjectKey = BaselineSubjectKey::fromDisplayName((string) $policy->display_name);
|
|
|
|
expect($subjectKey)->not->toBeNull();
|
|
|
|
$resolved = $this->resolver->resolve(
|
|
tenant: $tenant,
|
|
policyType: (string) $policy->policy_type,
|
|
subjectKey: (string) $subjectKey,
|
|
observedAt: 'not-a-date',
|
|
);
|
|
|
|
expect($resolved)->toBeNull();
|
|
});
|
|
|
|
test('uses a deterministic tie-breaker when multiple candidates exist', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$displayName = 'Policy Alpha';
|
|
$subjectKey = BaselineSubjectKey::fromDisplayName($displayName);
|
|
|
|
expect($subjectKey)->not->toBeNull();
|
|
|
|
$policy = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => $displayName,
|
|
]);
|
|
|
|
$versionEarly = PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'version_number' => 1,
|
|
'captured_at' => CarbonImmutable::parse('2026-03-05 12:00:00.100000'),
|
|
]);
|
|
|
|
$versionLate = PolicyVersion::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'policy_id' => (int) $policy->getKey(),
|
|
'policy_type' => (string) $policy->policy_type,
|
|
'version_number' => 2,
|
|
'captured_at' => CarbonImmutable::parse('2026-03-05 12:00:00.900000'),
|
|
]);
|
|
|
|
$resolved = $this->resolver->resolve(
|
|
tenant: $tenant,
|
|
policyType: (string) $policy->policy_type,
|
|
subjectKey: (string) $subjectKey,
|
|
observedAt: CarbonImmutable::parse('2026-03-05 12:00:00')->toIso8601String(),
|
|
);
|
|
|
|
expect($resolved)
|
|
->toBe((int) $versionLate->getKey())
|
|
->and($resolved)->not->toBe((int) $versionEarly->getKey());
|
|
});
|