ahmido
1655cc481e
## Summary - migrate provider connections to the canonical three-dimension state model: lifecycle via `is_enabled`, consent via `consent_status`, and verification via `verification_status` - remove legacy provider status and health badge paths, update admin and system directory surfaces, and align onboarding, consent callback, verification, resolver, and mutation flows with the new model - add the Spec 188 artifact set, schema migrations, guard coverage, and expanded provider-state tests across admin, system, onboarding, verification, and rendering paths ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/SystemPanelAuthTest.php tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php tests/Feature/ProviderConnections/ProviderConnectionEnableDisableTest.php tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` - integrated browser smoke: validated admin provider list/detail/edit, tenant provider summary, system directory tenant detail, provider-connection search exclusion, and cleaned up the temporary smoke record afterward ## Filament / implementation notes - Livewire v4.0+ compliance: preserved; this change targets Filament v5 on Livewire v4 and does not introduce older APIs - Provider registration location: unchanged; Laravel 11+ panel providers remain registered in `bootstrap/providers.php` - Globally searchable resources: `ProviderConnectionResource` remains intentionally excluded from global search; tenant global search remains enabled and continues to resolve to view pages - Destructive actions: no new destructive action surface was introduced without confirmation or authorization; existing capability checks continue to gate provider mutations - Asset strategy: unchanged; no new Filament assets were added, so deploy behavior for `php artisan filament:assets` remains unchanged - Testing plan covered: system auth, tenant global search, provider lifecycle enable/disable behavior, and provider truth cleanup cutover behavior Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #219
52 lines
2.0 KiB
PHP
52 lines
2.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
it('keeps targeted provider-state runtime paths free of legacy provider status fallbacks', function (): void {
|
|
$guardedFiles = [
|
|
'apps/platform/app/Models/ProviderConnection.php',
|
|
'apps/platform/app/Services/Providers/Contracts/HealthResult.php',
|
|
'apps/platform/app/Services/Providers/MicrosoftProviderHealthCheck.php',
|
|
'apps/platform/app/Services/Providers/ProviderConnectionMutationService.php',
|
|
'apps/platform/app/Services/Providers/ProviderConnectionResolver.php',
|
|
'apps/platform/app/Services/Providers/ProviderConnectionStateProjector.php',
|
|
'apps/platform/app/Jobs/ProviderConnectionHealthCheckJob.php',
|
|
'apps/platform/app/Filament/Resources/ProviderConnectionResource.php',
|
|
'apps/platform/app/Filament/Resources/TenantResource.php',
|
|
'apps/platform/app/Filament/System/Pages/Directory/Tenants.php',
|
|
'apps/platform/app/Filament/System/Pages/Directory/ViewTenant.php',
|
|
'apps/platform/resources/views/filament/infolists/entries/provider-connection-state.blade.php',
|
|
'apps/platform/resources/views/filament/system/pages/directory/view-tenant.blade.php',
|
|
];
|
|
|
|
$forbiddenNeedles = [
|
|
'health_status',
|
|
'BadgeDomain::ProviderConnectionStatus',
|
|
'BadgeDomain::ProviderConnectionHealth',
|
|
'ProviderConnectionStatusBadge',
|
|
'ProviderConnectionHealthBadge',
|
|
"'status' => 'connected'",
|
|
"'status' => 'needs_consent'",
|
|
"'status' => 'disabled'",
|
|
"'status' => 'error'",
|
|
];
|
|
|
|
$violations = [];
|
|
|
|
foreach ($guardedFiles as $relativePath) {
|
|
$contents = file_get_contents(repo_path($relativePath));
|
|
|
|
expect($contents)->toBeString();
|
|
|
|
foreach ($forbiddenNeedles as $needle) {
|
|
if (! str_contains($contents, $needle)) {
|
|
continue;
|
|
}
|
|
|
|
$violations[] = sprintf('%s contains forbidden legacy provider-state marker "%s".', $relativePath, $needle);
|
|
}
|
|
}
|
|
|
|
expect($violations)->toBe([]);
|
|
});
|