## Summary - harden nested Filament and Livewire tenant-context handling across the backup schedule operation runs relation manager, managed-environment triage arrival continuity, the backup set policy picker table, and the Operate Hub shell - add architecture, feature, and browser coverage for nested Filament tenant-context continuity and restore-run resource behavior - add the Spec 334 artifacts (`spec.md`, `plan.md`, `tasks.md`, and the requirements checklist) ## Testing - Not run as part of this commit/push/PR workflow Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #395
130 lines
4.6 KiB
PHP
130 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\BackupScheduleResource\Pages\EditBackupSchedule;
|
|
use App\Filament\Resources\BackupScheduleResource\RelationManagers\BackupScheduleOperationRunsRelationManager;
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\OperationRun;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
function makeBackupScheduleForTenant(\App\Models\ManagedEnvironment $tenant, string $name): BackupSchedule
|
|
{
|
|
return BackupSchedule::query()->create([
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'name' => $name,
|
|
'is_enabled' => true,
|
|
'timezone' => 'UTC',
|
|
'frequency' => 'daily',
|
|
'time_of_day' => '01:00:00',
|
|
'days_of_week' => null,
|
|
'policy_types' => ['deviceConfiguration'],
|
|
'include_foundations' => true,
|
|
'retention_keep_last' => 30,
|
|
]);
|
|
}
|
|
|
|
it('shows only operation runs belonging to the owner backup schedule', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$scheduleA = makeBackupScheduleForTenant($tenant, 'Schedule A');
|
|
$scheduleB = makeBackupScheduleForTenant($tenant, 'Schedule B');
|
|
|
|
$runA = OperationRun::factory()->forTenant($tenant)->create([
|
|
'type' => 'backup_schedule_run',
|
|
'context' => ['backup_schedule_id' => (int) $scheduleA->getKey()],
|
|
]);
|
|
$runB = OperationRun::factory()->forTenant($tenant)->create([
|
|
'type' => 'backup_schedule_run',
|
|
'context' => ['backup_schedule_id' => (int) $scheduleB->getKey()],
|
|
]);
|
|
|
|
Livewire::test(BackupScheduleOperationRunsRelationManager::class, [
|
|
'ownerRecord' => $scheduleA,
|
|
'pageClass' => EditBackupSchedule::class,
|
|
])
|
|
->assertCanSeeTableRecords([$runA])
|
|
->assertCanNotSeeTableRecords([$runB]);
|
|
});
|
|
|
|
it('renders operation runs when ambient Filament tenant context is missing', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
setAdminPanelContext(null);
|
|
|
|
$schedule = makeBackupScheduleForTenant($tenant, 'Schedule A');
|
|
|
|
$run = OperationRun::factory()->forTenant($tenant)->create([
|
|
'type' => 'backup_schedule_run',
|
|
'context' => ['backup_schedule_id' => (int) $schedule->getKey()],
|
|
]);
|
|
|
|
Livewire::test(BackupScheduleOperationRunsRelationManager::class, [
|
|
'ownerRecord' => $schedule,
|
|
'pageClass' => EditBackupSchedule::class,
|
|
])
|
|
->assertCanSeeTableRecords([$run]);
|
|
});
|
|
|
|
it('does not broaden scope when ambient Filament tenant context is wrong', function (): void {
|
|
$tenantA = \App\Models\ManagedEnvironment::factory()->create();
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$tenantB = \App\Models\ManagedEnvironment::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
setAdminPanelContext($tenantB);
|
|
|
|
$scheduleA = makeBackupScheduleForTenant($tenantA, 'Schedule A');
|
|
|
|
$runA = OperationRun::factory()->forTenant($tenantA)->create([
|
|
'type' => 'backup_schedule_run',
|
|
'context' => ['backup_schedule_id' => (int) $scheduleA->getKey()],
|
|
]);
|
|
|
|
Livewire::test(BackupScheduleOperationRunsRelationManager::class, [
|
|
'ownerRecord' => $scheduleA,
|
|
'pageClass' => EditBackupSchedule::class,
|
|
])
|
|
->assertCanSeeTableRecords([$runA]);
|
|
});
|
|
|
|
it('returns 404 when a forged same-tenant run key is mounted on the wrong schedule relation manager', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$scheduleA = makeBackupScheduleForTenant($tenant, 'Schedule A');
|
|
$scheduleB = makeBackupScheduleForTenant($tenant, 'Schedule B');
|
|
|
|
$foreignRun = OperationRun::factory()->forTenant($tenant)->create([
|
|
'type' => 'backup_schedule_run',
|
|
'context' => ['backup_schedule_id' => (int) $scheduleB->getKey()],
|
|
]);
|
|
|
|
$component = Livewire::test(BackupScheduleOperationRunsRelationManager::class, [
|
|
'ownerRecord' => $scheduleA,
|
|
'pageClass' => EditBackupSchedule::class,
|
|
]);
|
|
|
|
$table = $component->instance()->getTable();
|
|
|
|
expect(fn () => $table->getRecordUrl($foreignRun))
|
|
->toThrow(NotFoundHttpException::class);
|
|
});
|