ahmido
fb4de17c63
Implements Spec 089: moves Provider Connections to canonical tenantless route under `/admin/provider-connections`, enforces 404/403 semantics (workspace/tenant membership vs capability), adds tenant transparency (tenant column + filter + deep links), adds legacy redirects for old tenant-scoped URLs without leaking Location for 404 cases, and adds regression test coverage (RBAC semantics, filters, UI enforcement tooltips, Microsoft-only MVP scope, navigation placement). Notes: - Filament v5 / Livewire v4 compatible. - Global search remains disabled for Provider Connections. - Destructive/manage actions require confirmation and are policy-gated. Tests: - `vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #107
53 lines
1.7 KiB
PHP
53 lines
1.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ProviderConnectionResource;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\Tenant;
|
|
|
|
it('returns an empty canonical list for unauthorized tenant filters', function (): void {
|
|
$tenantA = Tenant::factory()->create(['name' => 'Tenant A']);
|
|
$tenantB = Tenant::factory()->create(['name' => 'Tenant B']);
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
ProviderConnection::factory()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'display_name' => 'Tenant A Connection',
|
|
]);
|
|
|
|
ProviderConnection::factory()->create([
|
|
'tenant_id' => (int) $tenantB->getKey(),
|
|
'workspace_id' => (int) $tenantB->workspace_id,
|
|
'display_name' => 'Tenant B Connection',
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get(ProviderConnectionResource::getUrl('index', tenant: $tenantB))
|
|
->assertOk()
|
|
->assertDontSee('Tenant A Connection')
|
|
->assertDontSee('Tenant B Connection');
|
|
});
|
|
|
|
it('does not show non-member tenants in the choose-tenant list', function (): void {
|
|
$tenantA = Tenant::factory()->create(['name' => 'Tenant A']);
|
|
$tenantB = Tenant::factory()->create(['name' => 'Tenant B']);
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/choose-tenant')
|
|
->assertOk()
|
|
->assertSee('Tenant A')
|
|
->assertDontSee('Tenant B');
|
|
});
|
|
|
|
it('keeps provider connections excluded from global search', function (): void {
|
|
$property = new ReflectionProperty(ProviderConnectionResource::class, 'isGloballySearchable');
|
|
$property->setAccessible(true);
|
|
|
|
expect($property->getValue())->toBeFalse();
|
|
});
|