ahmido
c57f680f39
Implements Spec 098: workspace-level settings slices for Backup retention, Drift severity mapping, and Operations retention/threshold. Spec - specs/098-settings-slices-v1-backup-drift-ops/spec.md What changed - Workspace Settings page: grouped Backup/Drift/Operations sections, unset-input UX w/ helper text, per-setting reset actions (confirmed) - Settings registry: adds/updates validation + normalization (incl. drift severity mapping normalization to lowercase) - Backup retention: adds workspace default + floor clamp; job clamps effective keep-last up to floor - Drift findings: optional workspace severity mapping; adds `critical` severity support + badge mapping - Operations pruning: retention computed per workspace via settings; scheduler unchanged; stuck threshold is storage-only Safety / Compliance notes - Filament v5 / Livewire v4: no Livewire v3 usage; relies on existing Filament v5 + Livewire v4 stack - Provider registration unchanged (Laravel 11+/12 uses bootstrap/providers.php) - Destructive actions: per-setting reset uses Filament actions with confirmation - Global search: not affected (no resource changes) - Assets: no new assets registered; no `filament:assets` changes Tests - vendor/bin/sail artisan test --compact tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php \ tests/Feature/SettingsFoundation/WorkspaceSettingsViewOnlyTest.php \ tests/Feature/BackupScheduling/BackupScheduleLifecycleTest.php \ tests/Feature/Drift/DriftPolicySnapshotDriftDetectionTest.php \ tests/Feature/Scheduling/PruneOldOperationRunsScheduleTest.php \ tests/Unit/Badges/FindingBadgesTest.php Formatting - vendor/bin/sail bin pint --dirty Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #120
74 lines
2.8 KiB
PHP
74 lines
2.8 KiB
PHP
<?php
|
|
|
|
use App\Jobs\PruneOldOperationRunsJob;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceSetting;
|
|
use Illuminate\Console\Scheduling\Schedule;
|
|
|
|
it('schedules pruning job daily without overlapping', function () {
|
|
/** @var Schedule $schedule */
|
|
$schedule = app(Schedule::class);
|
|
|
|
$event = collect($schedule->events())
|
|
->first(fn ($event) => ($event->description ?? null) === PruneOldOperationRunsJob::class);
|
|
|
|
expect($event)->not->toBeNull();
|
|
expect($event->withoutOverlapping)->toBeTrue();
|
|
});
|
|
|
|
it('prunes operation runs using per-workspace retention settings', function () {
|
|
$workspaceA = Workspace::factory()->create();
|
|
$workspaceB = Workspace::factory()->create();
|
|
|
|
WorkspaceSetting::query()->create([
|
|
'workspace_id' => (int) $workspaceA->getKey(),
|
|
'domain' => 'operations',
|
|
'key' => 'operation_run_retention_days',
|
|
'value' => 30,
|
|
'updated_by_user_id' => null,
|
|
]);
|
|
|
|
WorkspaceSetting::query()->create([
|
|
'workspace_id' => (int) $workspaceB->getKey(),
|
|
'domain' => 'operations',
|
|
'key' => 'operation_run_retention_days',
|
|
'value' => 120,
|
|
'updated_by_user_id' => null,
|
|
]);
|
|
|
|
$createRun = function (Workspace $workspace, int $ageDays, string $identitySuffix): OperationRun {
|
|
return OperationRun::query()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'tenant_id' => null,
|
|
'user_id' => null,
|
|
'initiator_name' => 'System',
|
|
'type' => 'maintenance',
|
|
'status' => 'completed',
|
|
'outcome' => 'succeeded',
|
|
'run_identity_hash' => hash('sha256', 'prune-workspace-'.$workspace->getKey().'-'.$identitySuffix),
|
|
'summary_counts' => [],
|
|
'failure_summary' => [],
|
|
'context' => [],
|
|
'started_at' => now()->subDays($ageDays),
|
|
'completed_at' => now()->subDays($ageDays),
|
|
'created_at' => now()->subDays($ageDays),
|
|
'updated_at' => now()->subDays($ageDays),
|
|
]);
|
|
};
|
|
|
|
$workspaceAOldRun = $createRun($workspaceA, 45, 'old');
|
|
$workspaceANewRun = $createRun($workspaceA, 10, 'new');
|
|
|
|
$workspaceBOldRun = $createRun($workspaceB, 140, 'old');
|
|
$workspaceBRecentRun = $createRun($workspaceB, 100, 'recent');
|
|
|
|
PruneOldOperationRunsJob::dispatchSync();
|
|
|
|
expect(OperationRun::query()->whereKey((int) $workspaceAOldRun->getKey())->exists())->toBeFalse();
|
|
expect(OperationRun::query()->whereKey((int) $workspaceANewRun->getKey())->exists())->toBeTrue();
|
|
|
|
expect(OperationRun::query()->whereKey((int) $workspaceBOldRun->getKey())->exists())->toBeFalse();
|
|
expect(OperationRun::query()->whereKey((int) $workspaceBRecentRun->getKey())->exists())->toBeTrue();
|
|
});
|