ahmido
ff671d8d4a
## Why
Some Microsoft Graph / Intune identifiers are not UUIDs (e.g. scope tag id "0"). With `inventory_links.source_id` / `target_id` typed as `uuid`, PostgreSQL fails when inventory dependency extraction tries to persist those edges.
## What
- PostgreSQL migration changes `inventory_links.source_id` and `inventory_links.target_id` to `text`.
- Regression test ensures a non-UUID id ("0") can be persisted; on pgsql it also asserts the columns are `text`.
## Notes
- UUID identifiers continue to work (stored as strings).
- No UI/Filament changes.
## Testing
- `vendor/bin/sail artisan test --compact tests/Feature/Inventory/InventoryLinksNonUuidIdsTest.php`
Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box>
Reviewed-on: #96
47 lines
1.6 KiB
PHP
47 lines
1.6 KiB
PHP
<?php
|
|
|
|
use App\Models\InventoryItem;
|
|
use App\Models\InventoryLink;
|
|
use App\Models\Tenant;
|
|
use App\Services\Inventory\DependencyExtractionService;
|
|
use App\Support\Enums\RelationshipType;
|
|
use Illuminate\Support\Facades\DB;
|
|
|
|
it('stores non-UUID identifiers in inventory_links on PostgreSQL', function () {
|
|
$driver = DB::getDriverName();
|
|
|
|
$tenant = Tenant::factory()->create();
|
|
$item = InventoryItem::factory()->for($tenant)->create([
|
|
'external_id' => '11111111-1111-1111-1111-111111111111',
|
|
]);
|
|
|
|
/** @var DependencyExtractionService $service */
|
|
$service = app(DependencyExtractionService::class);
|
|
|
|
$service->extractForPolicyData($item, [
|
|
'id' => $item->external_id,
|
|
'roleScopeTagIds' => ['0'],
|
|
'assignments' => [],
|
|
]);
|
|
|
|
if ($driver === 'pgsql') {
|
|
$columnTypes = collect(DB::select(
|
|
"select column_name, data_type from information_schema.columns where table_name = 'inventory_links' and column_name in ('source_id', 'target_id')"
|
|
))
|
|
->mapWithKeys(fn (object $row) => [(string) $row->column_name => (string) $row->data_type]);
|
|
|
|
expect($columnTypes->get('source_id'))->toBe('text')
|
|
->and($columnTypes->get('target_id'))->toBe('text');
|
|
}
|
|
|
|
expect(
|
|
InventoryLink::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('source_type', 'inventory_item')
|
|
->where('source_id', $item->external_id)
|
|
->where('relationship_type', RelationshipType::ScopedBy->value)
|
|
->where('target_id', '0')
|
|
->exists()
|
|
)->toBeTrue();
|
|
});
|