ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: restore full suite (Pest helper collision + ops-ux spec sync) #130

Merged
ahmido merged 1 commits from fix/pest-makeassignment-collision into dev 2026-02-22 11:36:28 +00:00
Conversation 0 Commits 1 Files Changed 3 +26 -27
ahmido commented 2026-02-22 03:11:23 +00:00
Owner
Copy Link

Why

dev full suite was hard-failing with PHP Fatal error: Cannot redeclare function makeAssignment() due to two Pest files defining the same global helper.

Additionally, Ops-UX tests were out of sync with the new summary rendering + new whitelisted keys.

What changed

  • Renamed the Entra Admin Roles test helper to makeEntraAssignment() to avoid global collision.
  • Updated Ops-UX canonical key list in specs/055-ops-ux-rollout/spec.md to include:
    • report_created, report_deduped, alert_events_produced
  • Updated SummaryCountsWhitelistTest to match the new summary rendering:
    • no Summary: prefix
    • humanized keys (Total, Processed)

Verification

  • vendor/bin/sail artisan test --compact:
    • 1572 passed, 7 skipped (8044 assertions)
## Why `dev` full suite was hard-failing with `PHP Fatal error: Cannot redeclare function makeAssignment()` due to two Pest files defining the same global helper. Additionally, Ops-UX tests were out of sync with the new summary rendering + new whitelisted keys. ## What changed - Renamed the Entra Admin Roles test helper to `makeEntraAssignment()` to avoid global collision. - Updated Ops-UX canonical key list in `specs/055-ops-ux-rollout/spec.md` to include: - `report_created`, `report_deduped`, `alert_events_produced` - Updated `SummaryCountsWhitelistTest` to match the new summary rendering: - no `Summary:` prefix - humanized keys (`Total`, `Processed`) ## Verification - `vendor/bin/sail artisan test --compact`: - **1572 passed**, **7 skipped** (8044 assertions)
ahmido added 1 commit 2026-02-22 03:11:23 +00:00
ahmido merged commit 8bee824966 into dev 2026-02-22 11:36:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#130
No description provided.
Delete Branch "fix/pest-makeassignment-collision"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?